From: Jack Yu <jack.yu@realtek.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"Flove(HsinFu)" <flove@realtek.com>,
"Oder Chiou" <oder_chiou@realtek.com>,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Derek [方德義]" <derek.fang@realtek.com>
Subject: RE: [PATCH] ASoC: rt5682s: Add LDO control for dacref
Date: Wed, 1 Nov 2023 02:52:20 +0000 [thread overview]
Message-ID: <28cf2cfcd7b047519811e201da2c2f9f@realtek.com> (raw)
In-Reply-To: <ad79bd27-5c1f-48b9-b0b5-bb5c48cbd56c@sirena.org.uk>
> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Tuesday, October 31, 2023 9:30 PM
> To: Jack Yu <jack.yu@realtek.com>
> Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org; lars@metafoo.de;
> Flove(HsinFu) <flove@realtek.com>; Oder Chiou <oder_chiou@realtek.com>;
> Shuming [范書銘] <shumingf@realtek.com>; Derek [方德義]
> <derek.fang@realtek.com>
> Subject: Re: [PATCH] ASoC: rt5682s: Add LDO control for dacref
>
> On Tue, Oct 31, 2023 at 02:08:10AM +0000, Jack Yu wrote:
>
> > +/* LDO output select */
> > +static const char * const rt5682s_ldo_output_select[] = {
> > + "1.607V", "1.5V", "1.406V", "1.731V"
> > +};
>
> This feels like something that might be a better fit for firmware based
> selection - how would someone set a value for this, and why might it vary at
> runtime? I'm a bit unclear as to what the control does so this might be the
> best thing but perhaps not.
This control is added for specific customers, it won't be changed during runtime,
but will be set in the initialization regarding to different customers,
they'll set it in their own ucm and have already been verified by customers.
next prev parent reply other threads:[~2023-11-01 2:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 2:08 [PATCH] ASoC: rt5682s: Add LDO control for dacref Jack Yu
2023-10-31 13:29 ` Mark Brown
2023-11-01 2:52 ` Jack Yu [this message]
2023-11-01 13:01 ` Mark Brown
2023-11-01 14:02 ` Jack Yu
2023-11-01 17:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28cf2cfcd7b047519811e201da2c2f9f@realtek.com \
--to=jack.yu@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.