From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 465A4C54E41 for ; Fri, 1 Mar 2024 09:24:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RpYdixyEn7ebhxxnJZk6D9j7rJ/3QP5c02sXUILXSe8=; b=JREL1Y6HQv+BmwsOHEvSOUQErB 2BN1UTEs5eEMUn5qYTsWGgjmMC9fc34ckAUEWsbnl34G0j//3aw+goiwhGp+0AuOaEmP/Xf1nstZA Xk+cI2G5qkqWnnYvEqdcAizmcY7lP7lJGjJnhHYmPUNmcy7n8WHL5WfMXTZbxq6b+eHNHnRldidqK GNNhWBZKpbwUf3WXZ6/qVlRFjhyQyeYp/yFCEAXdi61o0/vONPHZu6+OAqyicCfShxyMdCGvSf2OB KkOrHmwVq+4iAxd+6cQuss7JVctIWFDM86vRM78kQtE2E0028UOAsKS+UC6dBGKNVnVnOB7/Z/jtu FYaB5DxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfz7h-0000000H8kh-3lKq; Fri, 01 Mar 2024 09:24:09 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfz7d-0000000H8iu-1Z63; Fri, 01 Mar 2024 09:24:07 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709285043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+NwpU1T7X3OYWsftSxh0KjSAxoWEc7j9i7vGX3zBZjA=; b=OyVDsnqz/Bdtug2srvCc36iTvO6BLM+N1ix3Eu+NP1SmP+bHEKWOTSqyKbR71J1DY4p1Wh AZoq7L78ngdGocntVAHkAE4Oj2oFVGNSvP6tkkgHAQ6QH2Q4MmlYvRoASEjRiIBEd7xR0c MmpVeTgdReeTXjJ4YR/nQ2Xfn4wj2CodgUBUkeCi1GZ1IJzwvQdFNqIufPYu7OzVyrZtEO L56xEPnUeVCIQYr9GxorQzC/DBllYlT4jK2fYYaFIvvucIO0aQDQS8SKkhRx6339rXc3o9 f80W3/6xUGNs6CcfHS4n7kk2V4fo3SUR/KKQ4QNySLHRf7h8zxjZlEShweLUog== Date: Fri, 01 Mar 2024 10:24:01 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: <8b48eeac7b629c39adc6024ff418724c@manjaro.org> References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> <8b48eeac7b629c39adc6024ff418724c@manjaro.org> Message-ID: <28d44f6e2fcacfb58cd1fb0f7fd9bc69@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_012406_089441_8F16FE5E X-CRM114-Status: GOOD ( 40.43 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMy0wMSAwOTo1MiwgRHJhZ2FuIFNpbWljIHdyb3RlOgo+IE9uIDIwMjQtMDMtMDEg MDk6MjUsIEFsZXhleSBDaGFya292IHdyb3RlOgo+PiBPbiBGcmksIE1hciAxLCAyMDI0IGF0IDk6 NTHigK9BTSBEcmFnYW4gU2ltaWMgPGRzaW1pY0BtYW5qYXJvLm9yZz4gCj4+IHdyb3RlOgo+Pj4g T24gMjAyNC0wMy0wMSAwNjoxMiwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4+PiA+IFdpdGggYWxs IGR1ZSByZXNwZWN0LCBJIGRpc2FncmVlLCBoZXJlIGlzIHdoeToKPj4+ID4gIC0gTmVpdGhlciB0 aGUgc2NoZW1hdGljIG5vciB0aGUgaGFyZHdhcmUgZGVzaWduIGd1aWRlLCBvbiB3aGljaCB0aGUK Pj4+ID4gc2NoZW1hdGljIHNlZW1zIHRvIGJlIGJhc2VkLCBwcmVzY3JpYmVzIGEgcGFydGljdWxh ciB3YXkgdG8gaGFuZGxlCj4+PiA+IHRoZXJtYWwgcnVuYXdheXMuIFRoZXkgb25seSBwcm92aWRl IHRoZSBwb3NzaWJpbGl0eSBvZiBHUElPIGJhc2VkCj4+PiA+IHJlc2V0cywgYWxvbmcgd2l0aCB0 aGUgQ1JVIGJhc2VkIG9uZQo+Pj4gCj4+PiBQbGVhc2Ugbm90ZSB0aGF0IG90aGVyIGRvY3VtZW50 cyBmcm9tIFJvY2tjaGlwIGFsc28gZXhpc3QuICBCZWxvdyBpcwo+Pj4gYSBsaW5rIHRvIGEgc2Ny ZWVuc2hvdCBmcm9tIHRoZSBUaGVybWFsIGRldmVsb3BlciBndWlkZSwgdmVyc2lvbiAxLjAsCj4+ PiB3aGljaCBkZXNjcmliZXMgdGhlIHdob2xlIHRoaW5nIGZ1cnRoZXIuICBJIGJlbGlldmUgaXQn cyBvYnZpb3VzIHRoYXQKPj4+IHRoZSB0aGVybWFsIHJ1bmF3YXkgaXMgdG8gYmUgdHJlYXRlZCBh cyBhIGJvYXJkLWxldmVsIGZlYXR1cmUuCj4+PiAKPj4+IC0gaHR0cHM6Ly9pLmltZ3VyLmNvbS9J SjZkU0FjLnBuZwo+PiAKPj4gRnJhbmtseSwgdGhhdCBzdGlsbCBkb2Vzbid0IG1ha2UgVFNBREMg cGVyIHNlIGEgYm9hcmQtbGV2ZWwgdGhpbmcgSU1PLgo+PiBUaGUgb25seSB0aGluZyB0aGF0IGlz IGJvYXJkLWxldmVsIGlzIHRoZSB3aXJpbmcgb2YgR1BJTyBiYXNlZCByZXNldHMsCj4+IHdoaWNo IEkgZnVsbHkgYWdyZWUgc2hvdWxkIGdvIHRvIGJvYXJkIC5kdHMgZm9yIGJvYXJkcyB0aGF0IHN1 cHBvcnQKPj4gaXQsIGJ1dCB0aGF0J3Mgbm90IHBhcnQgb2YgdGhlIGN1cnJlbnQgZGVmYXVsdHMg YW5kIGNhbiBiZSBzYWZlbHkKPj4gYWRkZWQgbGF0ZXIuCj4+IAo+PiBUU0FEQyBpcyBpbnNpZGUg dGhlIFNvQy4gQ1JVIGlzIGluc2lkZSB0aGUgU29DLiBUaGV5IHdvcmsganVzdCBmaW5lCj4+IGZv ciBhIHRoZXJtYWwgcmVzZXQsIGV2ZW4gaWYgbm8gZGVkaWNhdGVkIHJlc2V0IGxvZ2ljIGlzIHdp cmVkIG9uIHRoZQo+PiBib2FyZC4gSSByZWFsbHkgZG9uJ3Qgc2VlIGFueSBkb3duc2lkZXMgaW4g aGF2aW5nIFRTQURDIGVuYWJsZWQgYnkKPj4gZGVmYXVsdCB3aXRoIENSVSBiYXNlZCByZXNldHM6 Cj4+IC0gaXQncyBhIHNhZmUgZGVmYXVsdCAoaS5lLiBJIGNhbm5vdCB0aGluayBvZiBhbnkgY29u ZmlndXJhdGlvbiBvciB1c2UKPj4gY2FzZSB3aGVyZSBlbmFibGVkLWJ5LWRlZmF1bHQgVFNBREMg ZG9lcyBhbnkgaGFybSkKPj4gLSBpdCdzIHNhZmVyIHRoYW4gYWNjaWRlbnRhbGx5IGZvcmdldHRp bmcgdG8gZW5hYmxlIFRTQURDIChhcyBpdCBhZGRzCj4+IHRoZXJtYWwgcHJvdGVjdGlvbiB3aGlj aCBpcyBvdGhlcndpc2UgbWlzc2luZykKPj4gLSBpdCB3aWxsIHdvcmsgb24gYWxsIGJvYXJkcyAo ZXZlbiBpZiBpdCBkb2Vzbid0IHV0aWxpemUgdGhlIGZ1bGwKPj4gaGFyZHdhcmUgZnVuY3Rpb25h bGl0eSBieSBpZ25vcmluZyBHUElPIHJlc2V0cyB0aGF0IHNvbWUgYm9hcmRzIGFsc28KPj4gaGF2 ZSBpbiBhZGRpdGlvbiB0byB0aGUgQ1JVKQo+PiAtIGFuZCBpdCByZXF1aXJlcyBmZXdlciBvdmVy cmlkZXMgaW4gYm9hcmQgLmR0cyBmaWxlcwo+PiAKPj4gU291bmRzIGxpa2UgYSBuby1yZWdyZXQg bW92ZSB0byBtZS4KPiAKPiBQbGVhc2Ugc2VlIG15IGNvbW1lbnRzIGJlbG93Lgo+IAo+Pj4gVG8g YmUgZmFpciwgdGhhdCB2ZXJzaW9uIG9mIHRoZSBUaGVybWFsIGRldmVsb3BlciBndWlkZSBkYXRl cyBiYWNrIHRvCj4+PiAyMDE5LCBtZWFuaW5nIHRoYXQgaXQgdGVjaG5pY2FsbHkgYXBwbGllcyB0 byB0aGUgUkszMzk5LCBmb3IgZXhhbXBsZSwKPj4+IGJ1dCB0aGUgVFNBREMgYW5kIHJlc2V0IGNp cmN1aXRyeSBkZXNpZ24gaGFzIGJhc2ljYWxseSByZW1haW5lZCB0aGUKPj4+IHNhbWUgZm9yIHRo ZSBSSzM1ODguCj4+PiAKPj4+ID4gIC0gTXkgc3Ryb25nIGJlbGllZiBpcyB0aGF0IGRlZmF1bHRz IChyZWdhcmRsZXNzIG9mIGNvbnRleHQpIHNob3VsZCBiZQo+Pj4gPiBzYWZlIGFuZCByZWFzb25h YmxlLCBhbmQgc2hvdWxkIGFsc28gbWluaW1pemUgdGhlIG5lZWQgdG8gb3ZlcnJpZGUKPj4+ID4g dGhlbQo+Pj4gCj4+PiBQbGVhc2Ugbm90ZSB0aGF0IHRoZSBUU0FEQyBpcyBkaXNhYmxlZCBpbiB0 aGUgUkszMzk5IFNvQyBkdHNpLCBzbyAKPj4+IGhhdmluZwo+Pj4gaXQgZGlzYWJsZWQgaW4gdGhl IFJLMzU4OChzKSBTb0MgZHRzaSB3b3VsZCBwcm92aWRlIHNvbWUgY29uc2lzdGVuY3kuCj4+IAo+ PiBJJ20gaGFwcHkgdG8gcHJvZHVjZSBhIHBhdGNoIHRvIHJldmVyc2UgdGhlIGxvZ2ljIGluIFJL MzM5OSAoYW5kIGFueQo+PiBvdGhlcnMgZm9yIHRoYXQgbWF0dGVyKSB0byBhbHNvIGhhdmUgVFNB REMgZW5hYmxlZCBieSBkZWZhdWx0IHRoZXJlLAo+PiB0aHVzIHNhdmluZyBzZXZlcmFsIGxpbmVz IG9mIGNvZGUsIGlmIGl0J3MganVzdCBhYm91dCBjb25zaXN0ZW5jeS4KPiAKPiBCdXQgd2h5IHNo b3VsZCB3ZSBjaGFuZ2Ugc29tZXRoaW5nIHRoYXQgaGFzIHNlcnZlZCB1cyBmb3IgeWVhcnMsIG9u Cj4gbXVsdGlwbGUgU29Dcywgd2l0aCB6ZXJvIHRyb3VibGVzIGFuZCB3aXRoIChBRkFJSykgemVy byBib2FyZHMgCj4gcHJvZHVjaW5nCj4gcHVmZnMgb2YgYmx1aXNoIHNtb2tlPwo+IAo+Pj4gVGhv dWdoLCB0aGUgUkszMzk5IHN0aWxsIGRvZXMgaXQgaW4gYSBzYWZlIHdheSwgYnkgbW92aW5nIHRo ZSBPUFBzIAo+Pj4gaW50bwo+Pj4gYSBzZXBhcmF0ZSBkdHNpIGZpbGUsIG5hbWVkIHJrMzM5OS1v cHAuZHRzaSwgd2hpY2ggdGhlIGJvYXJkIGR0cyAKPj4+IGZpbGVzCj4+PiB0aGVuIGluY2x1ZGUg dG9nZXRoZXIgd2l0aCBlbmFibGluZyB0aGUgVFNBREMuCj4+PiAKPj4+IElmIHlvdSBhZ3JlZSwg bGV0J3MgZW1wbG95IHRoZSBzYW1lIGFwcHJvYWNoIGZvciB0aGUgUkszNTg4KHMpLCBieQo+Pj4g aGF2aW5nCj4+PiB0aGUgaXRzIE9QUHMgZGVmaW5lZCBpbiBhIHNlcGFyYXRlIGZpbGUsIG5hbWVk IHJrMzU4OHMtb3BwLmR0c2ksIGV0Yy4KPj4gCj4+IFNlcGFyYXRlIGZpbGUgZm9yIE9QUHMgaXMg YSBnb29kIG5vLXJlZ3JldCBtb3ZlIHRvIGRlY2x1dHRlciB0aGUgU29DCj4+IGxldmVsIC5kdHNp IChhcyB0aGUgT1BQIHRhYmxlIGlzIGxvbmcgYW5kIGJvcmluZykgLSBoYXBweSB0byBtb3ZlIGl0 Cj4+IHJlZ2FyZGxlc3Mgb2YgdGhlIG91dGNvbWUgb2YgdGhlIGFib3ZlIFRTQURDIGRpc2N1c3Np b24uIFRoYW5rcyBmb3IKPj4gdGhlIHBvaW50ZXIhCj4gCj4gWWVhaCwgYnV0IEknbSBub3Qgc3Vy ZSB0aGF0IGV2ZXJ5b25lIHdvdWxkIGxpa2UgdGhhdCBraW5kIG9mIAo+IHNlcGFyYXRpb24uCj4g SW4gZmFjdCwgc3VjaCBzZXBhcmF0aW9uIG1heSBiZSBmcm93bmVkIHVwb24gdW5sZXNzIGl0J3Mg bmVjZXNzYXJ5Lgo+IAo+IEFzIEkgYWxyZWFkeSBkZXNjcmliZWQgaW4gYW5vdGhlciB0aHJlYWQs IHRoZSBzZXBhcmF0aW9uIGZvciB0aGUgUkszMzk5Cj4gaXMgdGhlcmUgb25seSBiZWNhdXNlIGEg Y291cGxlIG9mIGRpZmZlcmVudCB2YXJpYW50cyBvZiB0aGUgUkszMzk5IFNvQwo+IHJlcXVpcmUg ZGlmZmVyZW50IE9QUHMuCj4gCj4+PiA+ICAtIEluIGNvbnRleHQgb2YgZHRzL2R0c2ksIGFzIGZh ciBhcyBJIHVuZGVyc3RhbmQgdGhlIGdlbmVyYWwgbG9naWMKPj4+ID4gYmVoaW5kIHRoZSBzcGxp dCwgdGhlIFNvQyAuZHRzaSBzaG91bGQgY29udGFpbiBhbGwgdGhlIHRoaW5ncyB0aGF0IGFyZQo+ Pj4gPiBmdWxseSBjb250YWluZWQgd2l0aGluIHRoZSBTb0MgYW5kIGRvIG5vdCBkZXBlbmQgb24g dGhlIHdpcmluZyBvZiBhCj4+PiA+IHBhcnRpY3VsYXIgYm9hcmQgb3IgaXRzIHRhcmdldCB1c2Ug Y2FzZS4gQm9hcmRzIHRoZW4KPj4+ID4gYWRkL3JlbW92ZS9vdmVycmlkZSBzZXR0aW5ncyB0byBt YXRjaCB0aGVpciB3aXJpbmcgYW5kIHVzZSBjYXNlIG1vcmUKPj4+ID4gY2xvc2VseQo+Pj4gCj4+ PiBPZiBjb3Vyc2UsIGJ1dCB0aGUgdGhlcm1hbCBzaHV0ZG93biBpcyBvYnZpb3VzbHkgYSBib2Fy ZC1sZXZlbCAKPj4+IGZlYXR1cmUsCj4+PiB3aGljaCBJIGRlc2NyaWJlZCBmdXJ0aGVyIGFib3Zl Lgo+PiAKPj4gTm90IHNvIG9idmlvdXMgdG8gbWUgOi0pIEkgZG9uJ3QgbWVhbiB0byBiZSBzdHVi Ym9ybiBvciB1bmNvb3BlcmF0aXZlCj4+IGhlcmUsIGJ1dCBJIHJlYWxseSBjYW4ndCBmaW5kIGFu eSB0ZWNobmljYWwgbWVyaXQgaW4gaGF2aW5nIGl0IGVuYWJsZWQKPj4gYXQgYm9hcmQgbGV2ZWwg aW5zdGVhZCBvZiBTb0MgbGV2ZWwuCj4gCj4gV2VsbCwgcGxlYXNlIGFsc28gY29uc2lkZXIgdGhh dCB0aGUgUE1JQ3MgZnJvbSBSb2NrY2hpcCBhcmUga2luZCBvZgo+IHdlaXJkIGxpdHRsZSBjaGlw cywgc3BlY2lmaWNhbGx5IGN1c3RvbWl6ZWQgdG8gc2VydmUgcGFydGljdWxhciBTb0NzLgo+IEZv ciBleGFtcGxlLCB0aGV5IGVuc3VyZSB0aGUgcmlnaHQgc2VxdWVuY2luZyBhbmQgcmFtcGluZy11 cCBvZiAKPiBkaWZmZXJlbnQKPiBwb3dlciByYWlscywgd2hpY2ggaXMgaW4gbWFueSBjYXNlcyBl c3NlbnRpYWwuCj4gCj4gVGh1cywgd2hvIGtub3dzIHdoYXQgbWlnaHQgKG9yIG1pZ2h0IG5vdCkg Z28gd3JvbmcgaWYgd2UgZG9uJ3QgcmVzZXQgCj4gdGhlCj4gUE1JQyBhdCB0aGUgc2FtZSB0aW1l IHdoZW4gdGhlIENSVSByZXNldHMgdGhlIFNvQz8gIFVuZm9ydHVuYXRlbHksIHRoZQo+IHRoaW5n cyBhcmVuJ3QgdGhhdCBzdHJhaWdodGZvcndhcmQuCj4gCj4gT24gdG9wIG9mIHRoYXQsIHNvbWUg Ym9hcmRzLCBzdWNoIGFzIHRoZSBSb2NrIDVCLCB1c2UgYSBmZXcgYWRkaXRpb25hbAo+IGRpc2Ny ZXRlIHZvbHRhZ2UgcmVndWxhdG9ycyBpbnN0ZWFkIG9mIGEgbWFzdGVyLXNsYXZlIFBNSUMgCj4g Y29uZmlndXJhdGlvbiwKPiB3aGljaCBtYXkgYWN0dWFsbHkgaW50cm9kdWNlIHNvbWUgd2VpcmQg cG93ZXItcmVsYXRlZCBpc3N1ZXMsIHdoaWNoIAo+IGFsc28KPiBtYXkgYmUgaW50ZXJtaXR0ZW50 LiAgQWN0dWFsbHksIEkndmUgYWxyZWFkeSBvdmVyaGVhcmQgdGhhdCB0aGUgUm9jayA1Qgo+IGV4 cGVyaWVuY2VzIHNvbWUgaXNzdWVzIG9mIHRoYXQgbmF0dXJlLCBidXQgSSBkb24ndCBrbm93IHRo ZSBkZXRhaWxzLgoKQXMgYW4gZXhhbXBsZSwgZGlkIHlvdSBrbm93IHRoYXQgTFBERFI0IGNoaXBz LCBhY2NvcmRpbmcgdG8gdGhlIG9mZmljaWFsCkpFREVDIGRvY3VtZW50YXRpb24sIHJlcXVpcmUg cHJvcGVyIHNlcXVlbmNpbmcgb2YgdGhlIHJhbXBpbmctZG93biBvZiAKdGhlaXIKcG93ZXIgcmFp bHMgd2hlbiB0aGV5J3JlIHRvIGJlIHR1cm5lZCBvZmYgYXMgcGFydCBvZiBzaHV0dGluZyB0aGUg c3lzdGVtCmRvd24/ICBUaGUgZG9jdW1lbnRhdGlvbiBhbHNvIHNwZWNpZmllcyB0aGF0IHRoZSBl eHBlY3RlZCBsaWZldGltZSAKYmVjb21lcwpyZWR1Y2VkIHdoZW4gdGhlIHBvd2VyaW5nLW9mZiBp c24ndCBwcm9wZXJseSBwZXJmb3JtZWQsIGFuZCB0aGVyZSdzIGV2ZW4gCmFuCm9mZmljaWFsIG51 bWJlciBvZiBzdWNoIHVuc2FmZSBwb3dlci1vZmZzIHRoYXQgdGhlIExQRERSNCBjaGlwcyBhcmUg CmFjdHVhbGx5CmV4cGVjdGVkIHRvIHN1cnZpdmUuCgpUaHVzLCBqdXN0IHlhbmtpbmcgYSBwb3dl ciBjb3JkIGZyb20gYSBkZXZpY2UgdGhhdCB1c2VzIExQRERSNCBtYXkgCmFjdHVhbGx5Cm1ha2Ug aXQgZGllIHByZW1hdHVyZWx5LiAgU3VjaCBiZWhhdmlvciBpcyBraW5kIG9mIGV4ZWN0ZWQgd2hl biBpdCBjb21lcyAKdG8KZmxhc2gtYmFzZWQgc3RvcmFnZSwgYnV0IERSQU0/ICBUaGluZ3MgYXJl IHdlaXJkIHRoZXNlIGRheXMuIDopCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B272C5475B for ; Fri, 1 Mar 2024 09:24:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PdAjrisKvEECfcsGULsoJfRN0MhBuLKNoIas7spoM5o=; b=SPlvcEAaiKcYLgnv5n1zmiP5Ay PH97/o5sHNNInpEGyrHugRD/rzONW7ngtd7b27hcvq3Ma4FVWzxYaQt5MyWzXi2SI1k7gpZQwzUcM 1KX7KIvxu/QWNMdgEOPUDq5Jko6nYHyeoL4nWrZLosjGlmHzPSUZcF25aXOaIlzr/F+wGiCtE3mW/ PQLAw5vbBjUajAOqwV0VDliRgBrA8B8D3SvfBjhihi7YRzcoNVG8CyqpNHRfYJBgY4yQZpBj1MBnJ t+dY9RPf58Cnp2c3UPKbKAWKgo/LmJr4USkZXrB9zRvNpqbZanj92E6n685cMQ+Wcuf6d+BJVNqUM VflPabjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfz7h-0000000H8kA-0xH4; Fri, 01 Mar 2024 09:24:09 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfz7d-0000000H8iu-1Z63; Fri, 01 Mar 2024 09:24:07 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709285043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+NwpU1T7X3OYWsftSxh0KjSAxoWEc7j9i7vGX3zBZjA=; b=OyVDsnqz/Bdtug2srvCc36iTvO6BLM+N1ix3Eu+NP1SmP+bHEKWOTSqyKbR71J1DY4p1Wh AZoq7L78ngdGocntVAHkAE4Oj2oFVGNSvP6tkkgHAQ6QH2Q4MmlYvRoASEjRiIBEd7xR0c MmpVeTgdReeTXjJ4YR/nQ2Xfn4wj2CodgUBUkeCi1GZ1IJzwvQdFNqIufPYu7OzVyrZtEO L56xEPnUeVCIQYr9GxorQzC/DBllYlT4jK2fYYaFIvvucIO0aQDQS8SKkhRx6339rXc3o9 f80W3/6xUGNs6CcfHS4n7kk2V4fo3SUR/KKQ4QNySLHRf7h8zxjZlEShweLUog== Date: Fri, 01 Mar 2024 10:24:01 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: <8b48eeac7b629c39adc6024ff418724c@manjaro.org> References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> <8b48eeac7b629c39adc6024ff418724c@manjaro.org> Message-ID: <28d44f6e2fcacfb58cd1fb0f7fd9bc69@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240301_012406_089441_8F16FE5E X-CRM114-Status: GOOD ( 40.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyNC0wMy0wMSAwOTo1MiwgRHJhZ2FuIFNpbWljIHdyb3RlOgo+IE9uIDIwMjQtMDMtMDEg MDk6MjUsIEFsZXhleSBDaGFya292IHdyb3RlOgo+PiBPbiBGcmksIE1hciAxLCAyMDI0IGF0IDk6 NTHigK9BTSBEcmFnYW4gU2ltaWMgPGRzaW1pY0BtYW5qYXJvLm9yZz4gCj4+IHdyb3RlOgo+Pj4g T24gMjAyNC0wMy0wMSAwNjoxMiwgQWxleGV5IENoYXJrb3Ygd3JvdGU6Cj4+PiA+IFdpdGggYWxs IGR1ZSByZXNwZWN0LCBJIGRpc2FncmVlLCBoZXJlIGlzIHdoeToKPj4+ID4gIC0gTmVpdGhlciB0 aGUgc2NoZW1hdGljIG5vciB0aGUgaGFyZHdhcmUgZGVzaWduIGd1aWRlLCBvbiB3aGljaCB0aGUK Pj4+ID4gc2NoZW1hdGljIHNlZW1zIHRvIGJlIGJhc2VkLCBwcmVzY3JpYmVzIGEgcGFydGljdWxh ciB3YXkgdG8gaGFuZGxlCj4+PiA+IHRoZXJtYWwgcnVuYXdheXMuIFRoZXkgb25seSBwcm92aWRl IHRoZSBwb3NzaWJpbGl0eSBvZiBHUElPIGJhc2VkCj4+PiA+IHJlc2V0cywgYWxvbmcgd2l0aCB0 aGUgQ1JVIGJhc2VkIG9uZQo+Pj4gCj4+PiBQbGVhc2Ugbm90ZSB0aGF0IG90aGVyIGRvY3VtZW50 cyBmcm9tIFJvY2tjaGlwIGFsc28gZXhpc3QuICBCZWxvdyBpcwo+Pj4gYSBsaW5rIHRvIGEgc2Ny ZWVuc2hvdCBmcm9tIHRoZSBUaGVybWFsIGRldmVsb3BlciBndWlkZSwgdmVyc2lvbiAxLjAsCj4+ PiB3aGljaCBkZXNjcmliZXMgdGhlIHdob2xlIHRoaW5nIGZ1cnRoZXIuICBJIGJlbGlldmUgaXQn cyBvYnZpb3VzIHRoYXQKPj4+IHRoZSB0aGVybWFsIHJ1bmF3YXkgaXMgdG8gYmUgdHJlYXRlZCBh cyBhIGJvYXJkLWxldmVsIGZlYXR1cmUuCj4+PiAKPj4+IC0gaHR0cHM6Ly9pLmltZ3VyLmNvbS9J SjZkU0FjLnBuZwo+PiAKPj4gRnJhbmtseSwgdGhhdCBzdGlsbCBkb2Vzbid0IG1ha2UgVFNBREMg cGVyIHNlIGEgYm9hcmQtbGV2ZWwgdGhpbmcgSU1PLgo+PiBUaGUgb25seSB0aGluZyB0aGF0IGlz IGJvYXJkLWxldmVsIGlzIHRoZSB3aXJpbmcgb2YgR1BJTyBiYXNlZCByZXNldHMsCj4+IHdoaWNo IEkgZnVsbHkgYWdyZWUgc2hvdWxkIGdvIHRvIGJvYXJkIC5kdHMgZm9yIGJvYXJkcyB0aGF0IHN1 cHBvcnQKPj4gaXQsIGJ1dCB0aGF0J3Mgbm90IHBhcnQgb2YgdGhlIGN1cnJlbnQgZGVmYXVsdHMg YW5kIGNhbiBiZSBzYWZlbHkKPj4gYWRkZWQgbGF0ZXIuCj4+IAo+PiBUU0FEQyBpcyBpbnNpZGUg dGhlIFNvQy4gQ1JVIGlzIGluc2lkZSB0aGUgU29DLiBUaGV5IHdvcmsganVzdCBmaW5lCj4+IGZv ciBhIHRoZXJtYWwgcmVzZXQsIGV2ZW4gaWYgbm8gZGVkaWNhdGVkIHJlc2V0IGxvZ2ljIGlzIHdp cmVkIG9uIHRoZQo+PiBib2FyZC4gSSByZWFsbHkgZG9uJ3Qgc2VlIGFueSBkb3duc2lkZXMgaW4g aGF2aW5nIFRTQURDIGVuYWJsZWQgYnkKPj4gZGVmYXVsdCB3aXRoIENSVSBiYXNlZCByZXNldHM6 Cj4+IC0gaXQncyBhIHNhZmUgZGVmYXVsdCAoaS5lLiBJIGNhbm5vdCB0aGluayBvZiBhbnkgY29u ZmlndXJhdGlvbiBvciB1c2UKPj4gY2FzZSB3aGVyZSBlbmFibGVkLWJ5LWRlZmF1bHQgVFNBREMg ZG9lcyBhbnkgaGFybSkKPj4gLSBpdCdzIHNhZmVyIHRoYW4gYWNjaWRlbnRhbGx5IGZvcmdldHRp bmcgdG8gZW5hYmxlIFRTQURDIChhcyBpdCBhZGRzCj4+IHRoZXJtYWwgcHJvdGVjdGlvbiB3aGlj aCBpcyBvdGhlcndpc2UgbWlzc2luZykKPj4gLSBpdCB3aWxsIHdvcmsgb24gYWxsIGJvYXJkcyAo ZXZlbiBpZiBpdCBkb2Vzbid0IHV0aWxpemUgdGhlIGZ1bGwKPj4gaGFyZHdhcmUgZnVuY3Rpb25h bGl0eSBieSBpZ25vcmluZyBHUElPIHJlc2V0cyB0aGF0IHNvbWUgYm9hcmRzIGFsc28KPj4gaGF2 ZSBpbiBhZGRpdGlvbiB0byB0aGUgQ1JVKQo+PiAtIGFuZCBpdCByZXF1aXJlcyBmZXdlciBvdmVy cmlkZXMgaW4gYm9hcmQgLmR0cyBmaWxlcwo+PiAKPj4gU291bmRzIGxpa2UgYSBuby1yZWdyZXQg bW92ZSB0byBtZS4KPiAKPiBQbGVhc2Ugc2VlIG15IGNvbW1lbnRzIGJlbG93Lgo+IAo+Pj4gVG8g YmUgZmFpciwgdGhhdCB2ZXJzaW9uIG9mIHRoZSBUaGVybWFsIGRldmVsb3BlciBndWlkZSBkYXRl cyBiYWNrIHRvCj4+PiAyMDE5LCBtZWFuaW5nIHRoYXQgaXQgdGVjaG5pY2FsbHkgYXBwbGllcyB0 byB0aGUgUkszMzk5LCBmb3IgZXhhbXBsZSwKPj4+IGJ1dCB0aGUgVFNBREMgYW5kIHJlc2V0IGNp cmN1aXRyeSBkZXNpZ24gaGFzIGJhc2ljYWxseSByZW1haW5lZCB0aGUKPj4+IHNhbWUgZm9yIHRo ZSBSSzM1ODguCj4+PiAKPj4+ID4gIC0gTXkgc3Ryb25nIGJlbGllZiBpcyB0aGF0IGRlZmF1bHRz IChyZWdhcmRsZXNzIG9mIGNvbnRleHQpIHNob3VsZCBiZQo+Pj4gPiBzYWZlIGFuZCByZWFzb25h YmxlLCBhbmQgc2hvdWxkIGFsc28gbWluaW1pemUgdGhlIG5lZWQgdG8gb3ZlcnJpZGUKPj4+ID4g dGhlbQo+Pj4gCj4+PiBQbGVhc2Ugbm90ZSB0aGF0IHRoZSBUU0FEQyBpcyBkaXNhYmxlZCBpbiB0 aGUgUkszMzk5IFNvQyBkdHNpLCBzbyAKPj4+IGhhdmluZwo+Pj4gaXQgZGlzYWJsZWQgaW4gdGhl IFJLMzU4OChzKSBTb0MgZHRzaSB3b3VsZCBwcm92aWRlIHNvbWUgY29uc2lzdGVuY3kuCj4+IAo+ PiBJJ20gaGFwcHkgdG8gcHJvZHVjZSBhIHBhdGNoIHRvIHJldmVyc2UgdGhlIGxvZ2ljIGluIFJL MzM5OSAoYW5kIGFueQo+PiBvdGhlcnMgZm9yIHRoYXQgbWF0dGVyKSB0byBhbHNvIGhhdmUgVFNB REMgZW5hYmxlZCBieSBkZWZhdWx0IHRoZXJlLAo+PiB0aHVzIHNhdmluZyBzZXZlcmFsIGxpbmVz IG9mIGNvZGUsIGlmIGl0J3MganVzdCBhYm91dCBjb25zaXN0ZW5jeS4KPiAKPiBCdXQgd2h5IHNo b3VsZCB3ZSBjaGFuZ2Ugc29tZXRoaW5nIHRoYXQgaGFzIHNlcnZlZCB1cyBmb3IgeWVhcnMsIG9u Cj4gbXVsdGlwbGUgU29Dcywgd2l0aCB6ZXJvIHRyb3VibGVzIGFuZCB3aXRoIChBRkFJSykgemVy byBib2FyZHMgCj4gcHJvZHVjaW5nCj4gcHVmZnMgb2YgYmx1aXNoIHNtb2tlPwo+IAo+Pj4gVGhv dWdoLCB0aGUgUkszMzk5IHN0aWxsIGRvZXMgaXQgaW4gYSBzYWZlIHdheSwgYnkgbW92aW5nIHRo ZSBPUFBzIAo+Pj4gaW50bwo+Pj4gYSBzZXBhcmF0ZSBkdHNpIGZpbGUsIG5hbWVkIHJrMzM5OS1v cHAuZHRzaSwgd2hpY2ggdGhlIGJvYXJkIGR0cyAKPj4+IGZpbGVzCj4+PiB0aGVuIGluY2x1ZGUg dG9nZXRoZXIgd2l0aCBlbmFibGluZyB0aGUgVFNBREMuCj4+PiAKPj4+IElmIHlvdSBhZ3JlZSwg bGV0J3MgZW1wbG95IHRoZSBzYW1lIGFwcHJvYWNoIGZvciB0aGUgUkszNTg4KHMpLCBieQo+Pj4g aGF2aW5nCj4+PiB0aGUgaXRzIE9QUHMgZGVmaW5lZCBpbiBhIHNlcGFyYXRlIGZpbGUsIG5hbWVk IHJrMzU4OHMtb3BwLmR0c2ksIGV0Yy4KPj4gCj4+IFNlcGFyYXRlIGZpbGUgZm9yIE9QUHMgaXMg YSBnb29kIG5vLXJlZ3JldCBtb3ZlIHRvIGRlY2x1dHRlciB0aGUgU29DCj4+IGxldmVsIC5kdHNp IChhcyB0aGUgT1BQIHRhYmxlIGlzIGxvbmcgYW5kIGJvcmluZykgLSBoYXBweSB0byBtb3ZlIGl0 Cj4+IHJlZ2FyZGxlc3Mgb2YgdGhlIG91dGNvbWUgb2YgdGhlIGFib3ZlIFRTQURDIGRpc2N1c3Np b24uIFRoYW5rcyBmb3IKPj4gdGhlIHBvaW50ZXIhCj4gCj4gWWVhaCwgYnV0IEknbSBub3Qgc3Vy ZSB0aGF0IGV2ZXJ5b25lIHdvdWxkIGxpa2UgdGhhdCBraW5kIG9mIAo+IHNlcGFyYXRpb24uCj4g SW4gZmFjdCwgc3VjaCBzZXBhcmF0aW9uIG1heSBiZSBmcm93bmVkIHVwb24gdW5sZXNzIGl0J3Mg bmVjZXNzYXJ5Lgo+IAo+IEFzIEkgYWxyZWFkeSBkZXNjcmliZWQgaW4gYW5vdGhlciB0aHJlYWQs IHRoZSBzZXBhcmF0aW9uIGZvciB0aGUgUkszMzk5Cj4gaXMgdGhlcmUgb25seSBiZWNhdXNlIGEg Y291cGxlIG9mIGRpZmZlcmVudCB2YXJpYW50cyBvZiB0aGUgUkszMzk5IFNvQwo+IHJlcXVpcmUg ZGlmZmVyZW50IE9QUHMuCj4gCj4+PiA+ICAtIEluIGNvbnRleHQgb2YgZHRzL2R0c2ksIGFzIGZh ciBhcyBJIHVuZGVyc3RhbmQgdGhlIGdlbmVyYWwgbG9naWMKPj4+ID4gYmVoaW5kIHRoZSBzcGxp dCwgdGhlIFNvQyAuZHRzaSBzaG91bGQgY29udGFpbiBhbGwgdGhlIHRoaW5ncyB0aGF0IGFyZQo+ Pj4gPiBmdWxseSBjb250YWluZWQgd2l0aGluIHRoZSBTb0MgYW5kIGRvIG5vdCBkZXBlbmQgb24g dGhlIHdpcmluZyBvZiBhCj4+PiA+IHBhcnRpY3VsYXIgYm9hcmQgb3IgaXRzIHRhcmdldCB1c2Ug Y2FzZS4gQm9hcmRzIHRoZW4KPj4+ID4gYWRkL3JlbW92ZS9vdmVycmlkZSBzZXR0aW5ncyB0byBt YXRjaCB0aGVpciB3aXJpbmcgYW5kIHVzZSBjYXNlIG1vcmUKPj4+ID4gY2xvc2VseQo+Pj4gCj4+ PiBPZiBjb3Vyc2UsIGJ1dCB0aGUgdGhlcm1hbCBzaHV0ZG93biBpcyBvYnZpb3VzbHkgYSBib2Fy ZC1sZXZlbCAKPj4+IGZlYXR1cmUsCj4+PiB3aGljaCBJIGRlc2NyaWJlZCBmdXJ0aGVyIGFib3Zl Lgo+PiAKPj4gTm90IHNvIG9idmlvdXMgdG8gbWUgOi0pIEkgZG9uJ3QgbWVhbiB0byBiZSBzdHVi Ym9ybiBvciB1bmNvb3BlcmF0aXZlCj4+IGhlcmUsIGJ1dCBJIHJlYWxseSBjYW4ndCBmaW5kIGFu eSB0ZWNobmljYWwgbWVyaXQgaW4gaGF2aW5nIGl0IGVuYWJsZWQKPj4gYXQgYm9hcmQgbGV2ZWwg aW5zdGVhZCBvZiBTb0MgbGV2ZWwuCj4gCj4gV2VsbCwgcGxlYXNlIGFsc28gY29uc2lkZXIgdGhh dCB0aGUgUE1JQ3MgZnJvbSBSb2NrY2hpcCBhcmUga2luZCBvZgo+IHdlaXJkIGxpdHRsZSBjaGlw cywgc3BlY2lmaWNhbGx5IGN1c3RvbWl6ZWQgdG8gc2VydmUgcGFydGljdWxhciBTb0NzLgo+IEZv ciBleGFtcGxlLCB0aGV5IGVuc3VyZSB0aGUgcmlnaHQgc2VxdWVuY2luZyBhbmQgcmFtcGluZy11 cCBvZiAKPiBkaWZmZXJlbnQKPiBwb3dlciByYWlscywgd2hpY2ggaXMgaW4gbWFueSBjYXNlcyBl c3NlbnRpYWwuCj4gCj4gVGh1cywgd2hvIGtub3dzIHdoYXQgbWlnaHQgKG9yIG1pZ2h0IG5vdCkg Z28gd3JvbmcgaWYgd2UgZG9uJ3QgcmVzZXQgCj4gdGhlCj4gUE1JQyBhdCB0aGUgc2FtZSB0aW1l IHdoZW4gdGhlIENSVSByZXNldHMgdGhlIFNvQz8gIFVuZm9ydHVuYXRlbHksIHRoZQo+IHRoaW5n cyBhcmVuJ3QgdGhhdCBzdHJhaWdodGZvcndhcmQuCj4gCj4gT24gdG9wIG9mIHRoYXQsIHNvbWUg Ym9hcmRzLCBzdWNoIGFzIHRoZSBSb2NrIDVCLCB1c2UgYSBmZXcgYWRkaXRpb25hbAo+IGRpc2Ny ZXRlIHZvbHRhZ2UgcmVndWxhdG9ycyBpbnN0ZWFkIG9mIGEgbWFzdGVyLXNsYXZlIFBNSUMgCj4g Y29uZmlndXJhdGlvbiwKPiB3aGljaCBtYXkgYWN0dWFsbHkgaW50cm9kdWNlIHNvbWUgd2VpcmQg cG93ZXItcmVsYXRlZCBpc3N1ZXMsIHdoaWNoIAo+IGFsc28KPiBtYXkgYmUgaW50ZXJtaXR0ZW50 LiAgQWN0dWFsbHksIEkndmUgYWxyZWFkeSBvdmVyaGVhcmQgdGhhdCB0aGUgUm9jayA1Qgo+IGV4 cGVyaWVuY2VzIHNvbWUgaXNzdWVzIG9mIHRoYXQgbmF0dXJlLCBidXQgSSBkb24ndCBrbm93IHRo ZSBkZXRhaWxzLgoKQXMgYW4gZXhhbXBsZSwgZGlkIHlvdSBrbm93IHRoYXQgTFBERFI0IGNoaXBz LCBhY2NvcmRpbmcgdG8gdGhlIG9mZmljaWFsCkpFREVDIGRvY3VtZW50YXRpb24sIHJlcXVpcmUg cHJvcGVyIHNlcXVlbmNpbmcgb2YgdGhlIHJhbXBpbmctZG93biBvZiAKdGhlaXIKcG93ZXIgcmFp bHMgd2hlbiB0aGV5J3JlIHRvIGJlIHR1cm5lZCBvZmYgYXMgcGFydCBvZiBzaHV0dGluZyB0aGUg c3lzdGVtCmRvd24/ICBUaGUgZG9jdW1lbnRhdGlvbiBhbHNvIHNwZWNpZmllcyB0aGF0IHRoZSBl eHBlY3RlZCBsaWZldGltZSAKYmVjb21lcwpyZWR1Y2VkIHdoZW4gdGhlIHBvd2VyaW5nLW9mZiBp c24ndCBwcm9wZXJseSBwZXJmb3JtZWQsIGFuZCB0aGVyZSdzIGV2ZW4gCmFuCm9mZmljaWFsIG51 bWJlciBvZiBzdWNoIHVuc2FmZSBwb3dlci1vZmZzIHRoYXQgdGhlIExQRERSNCBjaGlwcyBhcmUg CmFjdHVhbGx5CmV4cGVjdGVkIHRvIHN1cnZpdmUuCgpUaHVzLCBqdXN0IHlhbmtpbmcgYSBwb3dl ciBjb3JkIGZyb20gYSBkZXZpY2UgdGhhdCB1c2VzIExQRERSNCBtYXkgCmFjdHVhbGx5Cm1ha2Ug aXQgZGllIHByZW1hdHVyZWx5LiAgU3VjaCBiZWhhdmlvciBpcyBraW5kIG9mIGV4ZWN0ZWQgd2hl biBpdCBjb21lcyAKdG8KZmxhc2gtYmFzZWQgc3RvcmFnZSwgYnV0IERSQU0/ICBUaGluZ3MgYXJl IHdlaXJkIHRoZXNlIGRheXMuIDopCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 426E96A337; Fri, 1 Mar 2024 09:24:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709285048; cv=none; b=GA/vl+4uGdZqurq2VASxKtDpbcfK/+QoJ+OeJsbbuI7/uFoGclphWANLkeebjwloMKaGCqkwX6jigXs662srg2V6V5U0RRdiIttK02tqvunG5ZkVFFikTDy40Bl5SbN8GIEu3M6Jb8B9WqkWblDUqGeL1TufdI5oAs6O2z2FJuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709285048; c=relaxed/simple; bh=vit5J2cqgO6Q702EJY+gZN+tuz/WYcCgtku2XTm6Kl0=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=euDT84P2kmXXme2wtjv+bJbn1ra6ogN054gjwFAEwqXzjipCBnArWqYq6kb9Xd8int6RnEzKyvWjIoRuDxH9Sq3SXrugZ6Hgw4PYsmuE0ZvA7RKr5J0ZplZsKhuxT75J9B7urULci/tbrHLO9qVaEsto0F5rPZ6tOSj21zcAu58= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=OyVDsnqz; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="OyVDsnqz" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1709285043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+NwpU1T7X3OYWsftSxh0KjSAxoWEc7j9i7vGX3zBZjA=; b=OyVDsnqz/Bdtug2srvCc36iTvO6BLM+N1ix3Eu+NP1SmP+bHEKWOTSqyKbR71J1DY4p1Wh AZoq7L78ngdGocntVAHkAE4Oj2oFVGNSvP6tkkgHAQ6QH2Q4MmlYvRoASEjRiIBEd7xR0c MmpVeTgdReeTXjJ4YR/nQ2Xfn4wj2CodgUBUkeCi1GZ1IJzwvQdFNqIufPYu7OzVyrZtEO L56xEPnUeVCIQYr9GxorQzC/DBllYlT4jK2fYYaFIvvucIO0aQDQS8SKkhRx6339rXc3o9 f80W3/6xUGNs6CcfHS4n7kk2V4fo3SUR/KKQ4QNySLHRf7h8zxjZlEShweLUog== Date: Fri, 01 Mar 2024 10:24:01 +0100 From: Dragan Simic To: Alexey Charkov Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Daniel Lezcano , Viresh Kumar , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: enable built-in thermal monitoring on RK3588 In-Reply-To: <8b48eeac7b629c39adc6024ff418724c@manjaro.org> References: <20240229-rk-dts-additions-v3-0-6afe8473a631@gmail.com> <20240229-rk-dts-additions-v3-1-6afe8473a631@gmail.com> <8b48eeac7b629c39adc6024ff418724c@manjaro.org> Message-ID: <28d44f6e2fcacfb58cd1fb0f7fd9bc69@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org On 2024-03-01 09:52, Dragan Simic wrote: > On 2024-03-01 09:25, Alexey Charkov wrote: >> On Fri, Mar 1, 2024 at 9:51 AM Dragan Simic >> wrote: >>> On 2024-03-01 06:12, Alexey Charkov wrote: >>> > With all due respect, I disagree, here is why: >>> > - Neither the schematic nor the hardware design guide, on which the >>> > schematic seems to be based, prescribes a particular way to handle >>> > thermal runaways. They only provide the possibility of GPIO based >>> > resets, along with the CRU based one >>> >>> Please note that other documents from Rockchip also exist. Below is >>> a link to a screenshot from the Thermal developer guide, version 1.0, >>> which describes the whole thing further. I believe it's obvious that >>> the thermal runaway is to be treated as a board-level feature. >>> >>> - https://i.imgur.com/IJ6dSAc.png >> >> Frankly, that still doesn't make TSADC per se a board-level thing IMO. >> The only thing that is board-level is the wiring of GPIO based resets, >> which I fully agree should go to board .dts for boards that support >> it, but that's not part of the current defaults and can be safely >> added later. >> >> TSADC is inside the SoC. CRU is inside the SoC. They work just fine >> for a thermal reset, even if no dedicated reset logic is wired on the >> board. I really don't see any downsides in having TSADC enabled by >> default with CRU based resets: >> - it's a safe default (i.e. I cannot think of any configuration or use >> case where enabled-by-default TSADC does any harm) >> - it's safer than accidentally forgetting to enable TSADC (as it adds >> thermal protection which is otherwise missing) >> - it will work on all boards (even if it doesn't utilize the full >> hardware functionality by ignoring GPIO resets that some boards also >> have in addition to the CRU) >> - and it requires fewer overrides in board .dts files >> >> Sounds like a no-regret move to me. > > Please see my comments below. > >>> To be fair, that version of the Thermal developer guide dates back to >>> 2019, meaning that it technically applies to the RK3399, for example, >>> but the TSADC and reset circuitry design has basically remained the >>> same for the RK3588. >>> >>> > - My strong belief is that defaults (regardless of context) should be >>> > safe and reasonable, and should also minimize the need to override >>> > them >>> >>> Please note that the TSADC is disabled in the RK3399 SoC dtsi, so >>> having >>> it disabled in the RK3588(s) SoC dtsi would provide some consistency. >> >> I'm happy to produce a patch to reverse the logic in RK3399 (and any >> others for that matter) to also have TSADC enabled by default there, >> thus saving several lines of code, if it's just about consistency. > > But why should we change something that has served us for years, on > multiple SoCs, with zero troubles and with (AFAIK) zero boards > producing > puffs of bluish smoke? > >>> Though, the RK3399 still does it in a safe way, by moving the OPPs >>> into >>> a separate dtsi file, named rk3399-opp.dtsi, which the board dts >>> files >>> then include together with enabling the TSADC. >>> >>> If you agree, let's employ the same approach for the RK3588(s), by >>> having >>> the its OPPs defined in a separate file, named rk3588s-opp.dtsi, etc. >> >> Separate file for OPPs is a good no-regret move to declutter the SoC >> level .dtsi (as the OPP table is long and boring) - happy to move it >> regardless of the outcome of the above TSADC discussion. Thanks for >> the pointer! > > Yeah, but I'm not sure that everyone would like that kind of > separation. > In fact, such separation may be frowned upon unless it's necessary. > > As I already described in another thread, the separation for the RK3399 > is there only because a couple of different variants of the RK3399 SoC > require different OPPs. > >>> > - In context of dts/dtsi, as far as I understand the general logic >>> > behind the split, the SoC .dtsi should contain all the things that are >>> > fully contained within the SoC and do not depend on the wiring of a >>> > particular board or its target use case. Boards then >>> > add/remove/override settings to match their wiring and use case more >>> > closely >>> >>> Of course, but the thermal shutdown is obviously a board-level >>> feature, >>> which I described further above. >> >> Not so obvious to me :-) I don't mean to be stubborn or uncooperative >> here, but I really can't find any technical merit in having it enabled >> at board level instead of SoC level. > > Well, please also consider that the PMICs from Rockchip are kind of > weird little chips, specifically customized to serve particular SoCs. > For example, they ensure the right sequencing and ramping-up of > different > power rails, which is in many cases essential. > > Thus, who knows what might (or might not) go wrong if we don't reset > the > PMIC at the same time when the CRU resets the SoC? Unfortunately, the > things aren't that straightforward. > > On top of that, some boards, such as the Rock 5B, use a few additional > discrete voltage regulators instead of a master-slave PMIC > configuration, > which may actually introduce some weird power-related issues, which > also > may be intermittent. Actually, I've already overheard that the Rock 5B > experiences some issues of that nature, but I don't know the details. As an example, did you know that LPDDR4 chips, according to the official JEDEC documentation, require proper sequencing of the ramping-down of their power rails when they're to be turned off as part of shutting the system down? The documentation also specifies that the expected lifetime becomes reduced when the powering-off isn't properly performed, and there's even an official number of such unsafe power-offs that the LPDDR4 chips are actually expected to survive. Thus, just yanking a power cord from a device that uses LPDDR4 may actually make it die prematurely. Such behavior is kind of exected when it comes to flash-based storage, but DRAM? Things are weird these days. :)