All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Raphaël Gallais-Pou" <rgallaispou@gmail.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Marleen Vos <marleen.vos@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] configs/stm32mp157c_dk2: bump Linux to 6.9
Date: Fri, 12 Jul 2024 21:23:39 +0200	[thread overview]
Message-ID: <28de63ff-7351-45d5-a0d0-4bb696b5728e@gmail.com> (raw)
In-Reply-To: <20240712211157.13910779@windsurf>

Le 12/07/2024 à 21:11, Thomas Petazzoni a écrit :
> Hello Raphael,
> 
> Thanks for your patch. See below a review.
> 
> On Fri, 12 Jul 2024 20:27:12 +0200
> Raphael Gallais-Pou <rgallaispou@gmail.com> wrote:
> 
>> Base config on latest kernel version available.
>>
>> Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com>
>> ---
>>   configs/stm32mp157c_dk2_defconfig | 20 ++------------------
>>   1 file changed, 2 insertions(+), 18 deletions(-)
>>
>> diff --git a/configs/stm32mp157c_dk2_defconfig b/configs/stm32mp157c_dk2_defconfig
>> index c48705b2fb..0e26042b90 100644
>> --- a/configs/stm32mp157c_dk2_defconfig
>> +++ b/configs/stm32mp157c_dk2_defconfig
>> @@ -1,31 +1,17 @@
>> -# Architecture
>>   BR2_arm=y
>>   BR2_cortex_a7=y
>> -
>> -# Linux headers same as kernel, a 5.13 series
>> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_13=y
> 
> Please keep the comments and this option (but updated). It seems like
> you did a "make savedefconfig", without really worrying about what
> changed.
> 
Hi Thomas,

Thanks for the quick review.

Indeed, this is exactly what I did. I (wrongly) did not compared with 
similar changes even though this was my first contribution to Buildroot.

My bad.

>> -
>> -# System configuration
>>   BR2_ROOTFS_OVERLAY="board/stmicroelectronics/stm32mp157c-dk2/overlay/"
>>   BR2_ROOTFS_POST_IMAGE_SCRIPT="board/stmicroelectronics/common/stm32mp157/post-image.sh"
>> -
>> -# Kernel
>>   BR2_LINUX_KERNEL=y
>> -BR2_LINUX_KERNEL_CUSTOM_VERSION=y
>> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.13"
> 
> We need to keep an explicit kernel version, so that it doesn't
> automatically uses the "latest".

Makes sense in order not to introduce systematic uncontrolled breaks in 
the swarm of boards.

> 
> I believe it would also make sense to update TF-A and U-Boot at the
> same time.
> 
> Could you fix up those details, and submit an updated version?

Yes, I'll do some testing before and then send a v2.

Thanks,
Raphaël
> 
> Thanks a lot!
> 
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-07-12 19:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 18:27 [Buildroot] [PATCH 1/1] configs/stm32mp157c_dk2: bump Linux to 6.9 Raphael Gallais-Pou
2024-07-12 19:11 ` Thomas Petazzoni via buildroot
2024-07-12 19:23   ` Raphaël Gallais-Pou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28de63ff-7351-45d5-a0d0-4bb696b5728e@gmail.com \
    --to=rgallaispou@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=marleen.vos@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.