Re: [riscv:for-next 2/7] arch/riscv/kernel/setup.c:74:2: error: implicit declaration of function 'early_ioremap_setup'

[Rong Chen <rong.a.chen@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3674 bytes --]

Hi Atish,

We can reproduce this error if using the reproduce steps:

reproduce (this is a W=1 build):
         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
         chmod +x ~/bin/make.cross
         git checkout 3d109b0e0949bfd68cc00ffa9d78186fab037bc1
         # save the attached .config to linux build tree
         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv

Best Regards,
Rong Chen


On 8/27/20 6:20 AM, Atish Patra wrote:
> I can't seem to reproduce this issue. I have an older version gcc
> though (8.2). I am surprised by the error as well we are already
> including the early_ioremap.h.
>
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -1,4 +1,5 @@
>   # SPDX-License-Identifier: GPL-2.0
> +generic-y += early_ioremap.h
>   generic-y += extable.h
>   generic-y += flat.h
>   generic-y += kvm_para.h
>
> On Wed, 2020-08-26 at 09:54 +0800, kernel test robot wrote:
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git for-
>> next
>> head:   f75fa0a51b8b544ebd0d03a74c6b04d9f6b95781
>> commit: 3d109b0e0949bfd68cc00ffa9d78186fab037bc1 [2/7] RISC-V: Add
>> early ioremap support
>> config: riscv-allyesconfig (attached as .config)
>> compiler: riscv64-linux-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>>          wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> -O ~/bin/make.cross
>>          chmod +x ~/bin/make.cross
>>          git checkout 3d109b0e0949bfd68cc00ffa9d78186fab037bc1
>>          # save the attached .config to linux build tree
>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0
>> make.cross ARCH=riscv
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>     arch/riscv/kernel/setup.c: In function 'setup_arch':
>>>> arch/riscv/kernel/setup.c:74:2: error: implicit declaration of
>>>> function 'early_ioremap_setup' [-Werror=implicit-function-
>>>> declaration]
>>        74 |  early_ioremap_setup();
>>           |  ^~~~~~~~~~~~~~~~~~~
>>     cc1: some warnings being treated as errors
>>
>> #
>> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git/commit/?id=3d109b0e0949bfd68cc00ffa9d78186fab037bc1
>> git remote add riscv
>> https://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git
>> git fetch --no-tags riscv for-next
>> git checkout 3d109b0e0949bfd68cc00ffa9d78186fab037bc1
>> vim +/early_ioremap_setup +74 arch/riscv/kernel/setup.c
>>
>>      63	
>>      64	void __init setup_arch(char **cmdline_p)
>>      65	{
>>      66		parse_dtb();
>>      67		init_mm.start_code = (unsigned long) _stext;
>>      68		init_mm.end_code   = (unsigned long) _etext;
>>      69		init_mm.end_data   = (unsigned long) _edata;
>>      70		init_mm.brk        = (unsigned long) _end;
>>      71	
>>      72		*cmdline_p = boot_command_line;
>>      73	
>>    > 74		early_ioremap_setup();
>>      75		parse_early_param();
>>      76	
>>      77		setup_bootmem();
>>      78		paging_init();
>>      79	#if IS_ENABLED(CONFIG_BUILTIN_DTB)
>>      80		unflatten_and_copy_device_tree();
>>      81	#else
>>      82		if (early_init_dt_verify(__va(dtb_early_pa)))
>>      83			unflatten_device_tree();
>>      84		else
>>      85			pr_err("No DTB found in kernel
>> mappings\n");
>>      86	#endif
>>      87	
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org