From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262231AbUKKMta (ORCPT ); Thu, 11 Nov 2004 07:49:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262232AbUKKMta (ORCPT ); Thu, 11 Nov 2004 07:49:30 -0500 Received: from mx1.redhat.com ([66.187.233.31]:54681 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262231AbUKKMt1 (ORCPT ); Thu, 11 Nov 2004 07:49:27 -0500 From: David Howells In-Reply-To: <200411081432.iA8EWfnc023411@warthog.cambridge.redhat.com> References: <200411081432.iA8EWfnc023411@warthog.cambridge.redhat.com> Cc: torvalds@osdl.org, akpm@osdl.org, davidm@snapgear.com, linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org Subject: Re: [PATCH] Bit operations User-Agent: EMH/1.14.1 SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386-redhat-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Date: Thu, 11 Nov 2004 12:49:09 +0000 Message-ID: <29033.1100177349@redhat.com> To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, > The attached patch provides an out-of-line implementation of find_next_bit() > and rearranges linux/bitops.h to avoid a dependency loop between inline > functions in there and in asm/bitops.h trying to include one another. Is there any reason you dropped the part of this patch that rearranged linux/bitops.h? asm/bitops.h may need generic_ffs() for implementing sched_find_first_bit(), and obviously asm/bitops.h can't include linux/bitops.h. David