From: Bingbu Cao <bingbu.cao@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>
Cc: linux-media@vger.kernel.org, senozhatsky@chromium.org,
tfiga@chromium.org
Subject: Re: [PATCH] media: ov2740: change the minimal exposure value to 4
Date: Wed, 21 Oct 2020 18:12:16 +0800 [thread overview]
Message-ID: <2907f55b-2854-7f4d-e9e6-6b4d386f6773@linux.intel.com> (raw)
In-Reply-To: <20201021092043.GD2703@paasikivi.fi.intel.com>
Sakari, thanks.
I did not find that on patchwork, so resend it again. :)
On 10/21/20 5:20 PM, Sakari Ailus wrote:
> Hi Bingbu,
>
> On Wed, Oct 21, 2020 at 10:44:10AM +0800, Bingbu Cao wrote:
>> The minimal valid exposure value should be 4 lines instead of 8 for
>> ov2740 mannual exposure control.
>>
>> Signed-off-by: Bingbu Cao <bingbu.cao@intel.com>
>> ---
>> drivers/media/i2c/ov2740.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c
>> index bd0d45b0d43f..0dbae4949cb3 100644
>> --- a/drivers/media/i2c/ov2740.c
>> +++ b/drivers/media/i2c/ov2740.c
>> @@ -37,7 +37,7 @@
>>
>> /* Exposure controls from sensor */
>> #define OV2740_REG_EXPOSURE 0x3500
>> -#define OV2740_EXPOSURE_MIN 8
>> +#define OV2740_EXPOSURE_MIN 4
>> #define OV2740_EXPOSURE_MAX_MARGIN 8
>> #define OV2740_EXPOSURE_STEP 1
>
> This is already in my tree --- I may forgotten to push master after
> applying many patches, it is up-to-date now.
>
--
Best regards,
Bingbu Cao
next prev parent reply other threads:[~2020-10-21 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 2:44 [PATCH] media: ov2740: change the minimal exposure value to 4 Bingbu Cao
2020-10-21 9:20 ` Sakari Ailus
2020-10-21 10:12 ` Bingbu Cao [this message]
2020-10-21 10:33 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2907f55b-2854-7f4d-e9e6-6b4d386f6773@linux.intel.com \
--to=bingbu.cao@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=senozhatsky@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.