From: Michael Neuling <mikey@neuling.org>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org, RAISCH@de.ibm.com,
Paul Mackerras <paulus@samba.org>,
THEMANN@de.ibm.com
Subject: Re: [PATCH 1/2] Make setjmp/longjmp code generic
Date: Thu, 13 Dec 2007 10:40:44 +1100 [thread overview]
Message-ID: <29085.1197502844@neuling.org> (raw)
In-Reply-To: <1197500215.7695.11.camel@concordia>
> > arch/powerpc/xmon/setjmp.S | 135 ------------------------------------------
<snip>
> > +#ifdef CONFIG_XMON
> > +/*
> > + * Grab the register values as they are now.
> > + * This won't do a particularily good job because we really
> > + * want our caller's caller's registers, and our caller has
> > + * already executed its prologue.
> > + * ToDo: We could reach back into the caller's save area to do
> > + * a better job of representing the caller's state (note that
> > + * that will be different for 32-bit and 64-bit, because of the
> > + * different ABIs, though).
> > + */
> > +_GLOBAL(xmon_save_regs)
> > + PPC_STL r0,0*SZL(r3)
> > + PPC_STL r2,2*SZL(r3)
> > + PPC_STL r3,3*SZL(r3)
> > + PPC_STL r4,4*SZL(r3)
>
> Does xmon_save_regs belong here?
This was the only function left in xmon/setjmp.S. So rather than rename
the whole file to reflect it no longer has anything to do with setjmp, I
moved it out to misc.S
I'm not fussed what we end up doing.
Mikey
next prev parent reply other threads:[~2007-12-12 23:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-12 5:45 [PATCH 1/2] Make setjmp/longjmp code generic Michael Neuling
2007-12-12 7:59 ` Kumar Gala
2007-12-12 8:06 ` Benjamin Herrenschmidt
2007-12-12 9:37 ` Stephen Rothwell
2007-12-12 9:44 ` Benjamin Herrenschmidt
2007-12-12 11:09 ` Michael Neuling
2007-12-12 22:56 ` Michael Ellerman
2007-12-12 23:40 ` Michael Neuling [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-13 3:16 [PATCH 0/2] Add crashdump shutdown hooks Michael Neuling
2007-12-13 3:16 ` [PATCH 1/2] Make setjmp/longjmp code generic Michael Neuling
2007-12-13 9:59 [PATCH 0/2] Add crashdump shutdown hooks Michael Neuling
2007-12-13 9:59 ` [PATCH 1/2] Make setjmp/longjmp code generic Michael Neuling
2008-01-17 4:45 [PATCH 0/2] Add crashdump shutdown hooks Michael Neuling
2008-01-17 4:45 ` [PATCH 1/2] Make setjmp/longjmp code generic Michael Neuling
2008-01-17 5:38 ` Olof Johansson
2008-01-17 5:36 ` Michael Neuling
2008-01-17 6:36 ` Stephen Rothwell
2008-01-17 12:45 ` Josh Boyer
2008-01-17 21:49 ` Michael Ellerman
2008-01-17 6:39 ` Stephen Rothwell
2008-01-18 4:50 [PATCH 0/2] Add crashdump shutdown hooks Michael Neuling
2008-01-18 4:50 ` [PATCH 1/2] Make setjmp/longjmp code generic Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29085.1197502844@neuling.org \
--to=mikey@neuling.org \
--cc=RAISCH@de.ibm.com \
--cc=THEMANN@de.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.