From: Ping-Ke Shih <pkshih@realtek.com>
To: Sascha Hauer <s.hauer@pengutronix.de>,
linux-wireless <linux-wireless@vger.kernel.org>
Cc: Hans Ulli Kroll <linux@ulli-kroll.de>,
Larry Finger <Larry.Finger@lwfinger.net>,
Tim K <tpkuester@gmail.com>, "Alex G ." <mr.nuke.me@gmail.com>,
Nick Morrow <morrownr@gmail.com>,
Viktor Petrenko <g0000ga@gmail.com>,
Andreas Henriksson <andreas@fatal.se>,
ValdikSS <iam@valdikss.org.ru>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"petter@technux.se" <petter@technux.se>
Subject: RE: [PATCH] wifi: rtw88: usb: silence log flooding error message
Date: Thu, 25 May 2023 00:45:23 +0000 [thread overview]
Message-ID: <290b05447cc542a9b35c25ff89ba8ff3@realtek.com> (raw)
In-Reply-To: <20230524103934.1019096-1-s.hauer@pengutronix.de>
> -----Original Message-----
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Wednesday, May 24, 2023 6:40 PM
> To: linux-wireless <linux-wireless@vger.kernel.org>
> Cc: Hans Ulli Kroll <linux@ulli-kroll.de>; Larry Finger <Larry.Finger@lwfinger.net>; Ping-Ke Shih
> <pkshih@realtek.com>; Tim K <tpkuester@gmail.com>; Alex G . <mr.nuke.me@gmail.com>; Nick Morrow
> <morrownr@gmail.com>; Viktor Petrenko <g0000ga@gmail.com>; Andreas Henriksson <andreas@fatal.se>;
> ValdikSS <iam@valdikss.org.ru>; kernel@pengutronix.de; petter@technux.se; Sascha Hauer
> <s.hauer@pengutronix.de>
> Subject: [PATCH] wifi: rtw88: usb: silence log flooding error message
>
> When receiving more rx packets than the kernel can handle the driver
> drops the packets and issues an error message.
The workqueue rtw88_usb is using is:
rtwusb->rxwq = create_singlethread_workqueue("rtw88_usb: rx wq");
Have you tried workqueue with flags WQ_UNBOUND and WQ_HIGHPRI? Like,
rtwusb->rxwq = alloc_workqueue("rtw88_usb: rx wq", WQ_UNBOUND | WQ_HIGHPRI, 0);
or
rtwusb->rxwq = alloc_ordered_workqueue("rtw88_usb: rx wq", WQ_HIGHPRI);
Then, driver get more time to process RX, so it could ease flooding messages.
Ping-Ke
next prev parent reply other threads:[~2023-05-25 0:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 10:39 [PATCH] wifi: rtw88: usb: silence log flooding error message Sascha Hauer
2023-05-24 11:34 ` Simon Horman
2023-05-26 10:17 ` Sascha Hauer
2023-05-30 19:59 ` Simon Horman
2023-05-25 0:45 ` Ping-Ke Shih [this message]
2023-05-26 9:33 ` Sascha Hauer
2023-05-26 11:34 ` Ping-Ke Shih
2023-05-27 8:31 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=290b05447cc542a9b35c25ff89ba8ff3@realtek.com \
--to=pkshih@realtek.com \
--cc=Larry.Finger@lwfinger.net \
--cc=andreas@fatal.se \
--cc=g0000ga@gmail.com \
--cc=iam@valdikss.org.ru \
--cc=kernel@pengutronix.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@ulli-kroll.de \
--cc=morrownr@gmail.com \
--cc=mr.nuke.me@gmail.com \
--cc=petter@technux.se \
--cc=s.hauer@pengutronix.de \
--cc=tpkuester@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.