From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFF8DC433EF for ; Thu, 21 Oct 2021 19:10:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93FCF610EA for ; Thu, 21 Oct 2021 19:10:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 93FCF610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0D8191669; Thu, 21 Oct 2021 21:09:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0D8191669 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1634843408; bh=aKIkAz7YYmQd0zSX4RtSdC1q/EAeo1LBEGlCEzAYdoc=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nTvyT2/uhjQgrpK5xZ/+d/haEE5xkMJ7GD7YBolv6YhwAmP3vfPy2WpQwGMCacBlc 3i4QYModepPBeUe2OCiTJ24QpLoUrA1+k+2gABjZW0XzUdjFSSWxMHe7w1ECZydhGY dmj9QL+391iUMzJs1uzo+41qbIqc15R2nQHO0Y1g= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 75F98F801DB; Thu, 21 Oct 2021 21:09:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 52E7CF80240; Thu, 21 Oct 2021 21:09:16 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9BDF8F8011C for ; Thu, 21 Oct 2021 21:09:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9BDF8F8011C X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="315322547" X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; d="scan'208";a="315322547" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2021 12:08:59 -0700 X-IronPort-AV: E=Sophos;i="5.87,170,1631602800"; d="scan'208";a="463746455" Received: from dtjenkin-mobl1.amr.corp.intel.com (HELO [10.213.185.117]) ([10.213.185.117]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2021 12:08:58 -0700 Subject: Re: [PATCH] ASoC: Intel: Unify HDAudio-ext bus initialization To: Cezary Rojewski , Kai Vehmanen References: <20211018192134.353931-1-cezary.rojewski@intel.com> <4bf04607-0779-fe47-61b1-1780ab1a3d20@intel.com> <25811f8f-c7bc-89c2-f616-4102293a2deb@linux.intel.com> <569f6bf6-c346-3059-fc7e-e8c46c7dc4b6@linux.intel.com> <994c6339-6f67-58e9-77a1-a2faa20ade72@intel.com> <857438fc-1d63-84a8-f42a-79b082297035@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <290ccb39-94ee-3b13-f18b-4a7f145942e2@linux.intel.com> Date: Thu, 21 Oct 2021 14:08:55 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: hdegoede@redhat.com, alsa-devel@alsa-project.org, broonie@kernel.org, tiwai@suse.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >>> Well, please see the updated declaration of snd_hda_ext_bus_init() in >>> this very patch and then the existing code of >>> sound/soc/intel/skylake/skl.c - skl_create(). >>> Last argument in updated declaration reads 'modelname'. Skylake-driver >>> has its own, SOF initializes it differently. >> >> Not sure why you have your own? >> > > Not sure I understand the question. If you are talking about changing > string 'sklbus' to something else, then I don't believe mixing changes: > update to actual values assigned and assignment relocation in one patch > is good. I used 'sklbus' as that's what is being currently assigned to > ->modelname within skl_create(). Such approach makes the change more > transparent. What I meant is that this 'modelname' is a module parameter for legacy and SOF driver, it's attached to the bus, but eventually used by the codec hda_codec.c: if (codec->bus->modelname) { hda_codec.c: codec->modelname = kstrdup(codec->bus->modelname, GFP_KERNEL); and even further down used to apply board-specific fixups. "sklbus" doesn't seem to be related to codecs, boards or fixups, so not sure what this parameter does in the end?