Re: [PATCH] soc: samsung: asv: don't defer early on not-supported SoCs

[Marek Szyprowski <m.szyprowski@samsung.com>]

Hi Krzysztof,

On 07.12.2020 09:25, Krzysztof Kozlowski wrote:
> On Mon, Dec 07, 2020 at 09:10:05AM +0100, Krzysztof Kozlowski wrote:
>> On Mon, Dec 07, 2020 at 08:29:28AM +0100, Marek Szyprowski wrote:
>>> Check if the SoC is really supported before gathering the needed
>>> resources. This fixes endless deffered probe on some SoCs other than
>>> Exynos5422 (like Exynos5410).
>>>
>>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> If it really causes endless deffer, then also Cc stable.
>> Fixes: 5ea428595cc5 ("soc: samsung: Add Exynos Adaptive Supply Voltage driver")
>>
>> There is one more problem here - on Exynos5410 or anything else with
>> such chipid node, this will cause -ENODEV probe failures. It should not.
>> Simply, it should not match for them.
>>
>> This could be achieved with another compatible, but it won't really
>> describe the real case here, because it is not Chip ID which is
>> different. The CPU and bus voltages are different, the SoC is different.
>> Maybe this should not match to chip ID at all?
> There is another solution which I was checking few days ago (for
> different reason) - merge Chip ID driver with ASV. We get rid of the
> arch_initcall() and always bind to Chip ID node. If SoC revision
> matches, we run the ASV-specific code.

Okay for me. Feel free to post it if have it already done.

Best regards

-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland