From: Martin Steigerwald <ms@teamix.de>
To: Mark Nelson <mark.a.nelson@gmail.com>
Cc: Ben England <bengland@redhat.com>, Jens Axboe <axboe@kernel.dk>,
fio@vger.kernel.org, Mark Nelson <mnelson@redhat.com>
Subject: Re: fiologparser.py
Date: Wed, 25 May 2016 10:58:59 +0200 [thread overview]
Message-ID: <2911112.R94pZHdCuf@merkaba> (raw)
In-Reply-To: <c54ab91f-ccc9-59a1-bf17-9b72b0525d78@gmail.com>
On Dienstag, 24. Mai 2016 21:04:13 CEST Mark Nelson wrote:
> On 05/24/2016 03:47 PM, Ben England wrote:
> > Mark, I didn't notice the sample weighting code before. Weighting of
> > samples might work for averaging, but it doesn't work for percentiles,
> > min or max provided by -A option. I guess for min this won't be an issue
> > generally, since min-latency samples will probably fall entirely within a
> > time interval. But for max or higher percentiles it will *definitely* be
> > an issue. For example, a really high latency sample could be the max
> > for a whole range of time intervals.
> I went back and reworked the print and per-interval functions so that
> they are part of a Printer class and Interval class respectively. It
> cleaned the code up pretty nicely. I was also able to integrate the
> "-A" code to use a lot of the existing statistics and formatting code.
> It now supports the "-d" flag for example.
While at it, Mark, could you also do the renaming to fiologparser?
Otherwise I´d prepare a patch, but then we risk a trivial merge conflict :)
Thanks,
Martin
next prev parent reply other threads:[~2016-05-25 8:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 10:35 fiologparser.py Martin Steigerwald
2016-05-24 11:12 ` fiologparser.py Ben England
2016-05-24 14:04 ` fiologparser.py Mark Nelson
2016-05-24 14:11 ` fiologparser.py Jens Axboe
2016-05-24 14:17 ` fiologparser.py Mark Nelson
2016-05-24 15:22 ` fiologparser.py Ben England
2016-05-24 15:28 ` fiologparser.py Jens Axboe
2016-05-24 15:35 ` fiologparser.py Ben England
2016-05-24 16:20 ` fiologparser.py Mark Nelson
2016-05-24 18:38 ` fiologparser.py Jeff Furlong
2016-05-24 20:47 ` fiologparser.py Ben England
2016-05-25 2:04 ` fiologparser.py Mark Nelson
2016-05-25 8:58 ` Martin Steigerwald [this message]
2016-05-25 7:20 ` fiologparser.py Martin Steigerwald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2911112.R94pZHdCuf@merkaba \
--to=ms@teamix.de \
--cc=axboe@kernel.dk \
--cc=bengland@redhat.com \
--cc=fio@vger.kernel.org \
--cc=mark.a.nelson@gmail.com \
--cc=mnelson@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.