From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 5/9] drm/rcar-du: Use drm_fbdev_generic_setup() Date: Wed, 28 Nov 2018 20:56:55 +0200 Message-ID: <29123019.QYAEDBMEp0@avalon> References: <20181025201340.34227-1-noralf@tronnes.org> <20181025201340.34227-6-noralf@tronnes.org> <4ff6704b-d8f2-a8d1-496c-603193a09ea0@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97ED06E363 for ; Wed, 28 Nov 2018 18:56:32 +0000 (UTC) In-Reply-To: <4ff6704b-d8f2-a8d1-496c-603193a09ea0@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?ISO-8859-1?Q?Tr=F8nnes?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTm9yYWxmLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBXZWRuZXNkYXksIDI4IE5v dmVtYmVyIDIwMTggMTk6MDM6MzkgRUVUIE5vcmFsZiBUcsO4bm5lcyB3cm90ZToKPiBEZW4gMjUu MTAuMjAxOCAyMi4xMywgc2tyZXYgTm9yYWxmIFRyw7hubmVzOgo+ID4gVGhlIENNQSBoZWxwZXIg aXMgYWxyZWFkeSB1c2luZyB0aGUgZHJtX2ZiX2hlbHBlcl9nZW5lcmljX3Byb2JlIHBhcnQgb2YK PiA+IHRoZSBnZW5lcmljIGZiZGV2IGVtdWxhdGlvbi4gVGhpcyBwYXRjaCBtYWtlcyBmdWxsIHVz ZSBvZiB0aGUgZ2VuZXJpYwo+ID4gZmJkZXYgZW11bGF0aW9uIGJ5IHVzaW5nIGl0cyBkcm1fY2xp ZW50IGNhbGxiYWNrcy4gVGhpcyBtZWFucyB0aGF0Cj4gPiBkcm1fbW9kZV9jb25maWdfZnVuY3Mt Pm91dHB1dF9wb2xsX2NoYW5nZWQgYW5kIGRybV9kcml2ZXItPmxhc3RjbG9zZSBhcmUKPiA+IG5v dyBoYW5kbGVkIGJ5IHRoZSBlbXVsYXRpb24gY29kZS4gQWRkaXRpb25hbGx5IGZiZGV2IHVucmVn aXN0ZXIgaGFwcGVucwo+ID4gYXV0b21hdGljYWxseSBvbiBkcm1fZGV2X3VucmVnaXN0ZXIoKS4K PiA+IAo+ID4gVGhlIGRybV9mYmRldl9nZW5lcmljX3NldHVwKCkgY2FsbCBpcyBwdXQgYWZ0ZXIg ZHJtX2Rldl9yZWdpc3RlcigpIGluIHRoZQo+ID4gZHJpdmVyLiBUaGlzIGlzIGRvbmUgdG8gaGln aGxpZ2h0IHRoZSBmYWN0IHRoYXQgZmJkZXYgZW11bGF0aW9uIGlzIGFuCj4gPiBpbnRlcm5hbCBj bGllbnQgdGhhdCBtYWtlcyB1c2Ugb2YgdGhlIGRyaXZlciwgaXQgaXMgbm90IHBhcnQgb2YgdGhl Cj4gPiBkcml2ZXIgYXMgc3VjaC4gSWYgZmJkZXYgc2V0dXAgZmFpbHMsIGFuIGVycm9yIGlzIHBy aW50ZWQsIGJ1dCB0aGUgZHJpdmVyCj4gPiBzdWNjZWVkcyBwcm9iaW5nLgo+ID4gCj4gPiBkcm1f ZmJkZXZfZ2VuZXJpY19zZXR1cCgpIGhhbmRsZXMgbW9kZV9jb25maWcubnVtX2Nvbm5lY3RvciBi ZWluZyB6ZXJvLgo+ID4gSW4gdGhhdCBjYXNlIGl0IHJldHJpZXMgZmJkZXYgc2V0dXAgb24gdGhl IG5leHQgLm91dHB1dF9wb2xsX2NoYW5nZWQuCj4gPiAKPiA+IENjOiBMYXVyZW50IFBpbmNoYXJ0 IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBO b3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPiA+IEFja2VkLWJ5OiBTYW0gUmF2 bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+Cj4gPiBSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFy dCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+ID4gLS0tCj4gPiAKPiA+IENo YW5nZXMgc2luY2UgdmVyc2lvbiAxOgo+ID4gLSBSZWJhc2VkIG9uOiBkcm0vcmNhci1kdTogQ29u dmVydCBkcm1fYXRvbWljX2hlbHBlcl9zdXNwZW5kL3Jlc3VtZSgpCj4gPiAKPiA+IExhdXJlbnQs IGRvIHlvdSB3YW50IHRvIHRha2UgdGhpcyB0aHJvdWdoIHlvdXIgdHJlZSwgb3IgZG8geW91IHdh bnQgbWUgdG8KPiA+IGFwcGx5IGl0IHRvIGRybS1taXNjLW5leHQ/Cj4gPiAKPiA+ICAgZHJpdmVy cy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYyB8IDE1ICsrKystLS0tLS0tLS0tLQo+ID4g ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5oIHwgIDIgLS0KPiA+ICAgZHJp dmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9rbXMuYyB8IDIxIC0tLS0tLS0tLS0tLS0tLS0t LS0tLQo+ID4gICAzIGZpbGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMzQgZGVsZXRpb25z KC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X2Rydi5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMgaW5kZXgg NzAxNTk3NGMyNDdhLi4yN2JmY2NkNWIxMzYKPiA+IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3Jj YXItZHUvcmNhcl9kdV9kcnYuYwo+ID4gQEAgLTIxLDcgKzIxLDkgQEAKPiA+ICAjaW5jbHVkZSA8 ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fY3J0Y19oZWxw ZXIuaD4KPiA+ICAjaW5jbHVkZSA8ZHJtL2RybV9mYl9jbWFfaGVscGVyLmg+Cj4gPiArI2luY2x1 ZGUgPGRybS9kcm1fZmJfaGVscGVyLmg+Cj4gPiAgI2luY2x1ZGUgPGRybS9kcm1fZ2VtX2NtYV9o ZWxwZXIuaD4KPiA+ICsjaW5jbHVkZSA8ZHJtL2RybV9tb2Rlc2V0X2hlbHBlci5oPgo+IAo+IEkg c2VlIHRoYXQgSSBmb3Jnb3QgdG8gcmVtb3ZlIHRoaXMgaW5jbHVkZSB3aGVuIHJlYmFzaW5nLgo+ IAo+IFdpbGwgc2VuZCBhIG5ldyB2ZXJzaW9uIHRvZ2V0aGVyIHdpdGggdGhlIG90aGVyIHJlbWFp bmluZyBwYXRjaGVzLgoKTG9va3MgZ29vZCB0byBtZSwgeW91IGNhbiBrZWVwIG15IFJldmlld2Vk LWJ5IGxpbmUuIEknbSBmaW5lIHdpdGggdGhlIHBhdGNoIApiZWluZyBtZXJnZWQgdGhyb3VnaCB0 aGUgZHJtLW1pc2MgdHJlZS4KCj4gPiAgICNpbmNsdWRlICJyY2FyX2R1X2Rydi5oIgo+ID4gICAj aW5jbHVkZSAicmNhcl9kdV9rbXMuaCIKPiA+IAo+ID4gQEAgLTM2MywxOSArMzY1LDExIEBAIE1P RFVMRV9ERVZJQ0VfVEFCTEUob2YsIHJjYXJfZHVfb2ZfdGFibGUpOwo+ID4gICAgKiBEUk0gb3Bl cmF0aW9ucwo+ID4gICAgKi8KPiA+IAo+ID4gLXN0YXRpYyB2b2lkIHJjYXJfZHVfbGFzdGNsb3Nl KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiAtewo+ID4gLQlzdHJ1Y3QgcmNhcl9kdV9kZXZp Y2UgKnJjZHUgPSBkZXYtPmRldl9wcml2YXRlOwo+ID4gLQo+ID4gLQlkcm1fZmJkZXZfY21hX3Jl c3RvcmVfbW9kZShyY2R1LT5mYmRldik7Cj4gPiAtfQo+ID4gLQo+ID4gICBERUZJTkVfRFJNX0dF TV9DTUFfRk9QUyhyY2FyX2R1X2ZvcHMpOwo+ID4gICAKPiA+ICAgc3RhdGljIHN0cnVjdCBkcm1f ZHJpdmVyIHJjYXJfZHVfZHJpdmVyID0gewo+ID4gICAJLmRyaXZlcl9mZWF0dXJlcwk9IERSSVZF Ul9HRU0gfCBEUklWRVJfTU9ERVNFVCB8IERSSVZFUl9QUklNRQo+ID4gICAJCQkJfCBEUklWRVJf QVRPTUlDLAo+ID4gLQkubGFzdGNsb3NlCQk9IHJjYXJfZHVfbGFzdGNsb3NlLAo+ID4gICAJLmdl bV9mcmVlX29iamVjdF91bmxvY2tlZCA9IGRybV9nZW1fY21hX2ZyZWVfb2JqZWN0LAo+ID4gICAJ LmdlbV92bV9vcHMJCT0gJmRybV9nZW1fY21hX3ZtX29wcywKPiA+ICAgCS5wcmltZV9oYW5kbGVf dG9fZmQJPSBkcm1fZ2VtX3ByaW1lX2hhbmRsZV90b19mZCwKPiA+IEBAIC00MzEsOSArNDI1LDYg QEAgc3RhdGljIGludCByY2FyX2R1X3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlCj4gPiAq cGRldikKPiA+IAo+ID4gICAJZHJtX2Rldl91bnJlZ2lzdGVyKGRkZXYpOwo+ID4gCj4gPiAtCWlm IChyY2R1LT5mYmRldikKPiA+IC0JCWRybV9mYmRldl9jbWFfZmluaShyY2R1LT5mYmRldik7Cj4g PiAtCj4gPiAgIAlkcm1fa21zX2hlbHBlcl9wb2xsX2ZpbmkoZGRldik7Cj4gPiAgIAlkcm1fbW9k ZV9jb25maWdfY2xlYW51cChkZGV2KTsKPiA+IAo+ID4gQEAgLTQ5Myw2ICs0ODQsOCBAQCBzdGF0 aWMgaW50IHJjYXJfZHVfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiA+IAo+ ID4gICAJRFJNX0lORk8oIkRldmljZSAlcyBwcm9iZWRcbiIsIGRldl9uYW1lKCZwZGV2LT5kZXYp KTsKPiA+IAo+ID4gKwlkcm1fZmJkZXZfZ2VuZXJpY19zZXR1cChkZGV2LCAzMik7Cj4gPiArCj4g PiAgIAlyZXR1cm4gMDsKPiA+ICAgCj4gPiAgIGVycm9yOgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmgKPiA+IGIvZHJpdmVycy9ncHUvZHJtL3Jj YXItZHUvcmNhcl9kdV9kcnYuaCBpbmRleCA5ZjU1NjMyOTZjNWEuLmE2OGRhNzliNDI0ZQo+ID4g MTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5oCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5oCj4gPiBAQCAtMjAs NyArMjAsNiBAQAo+ID4gICBzdHJ1Y3QgY2xrOwo+ID4gICBzdHJ1Y3QgZGV2aWNlOwo+ID4gICBz dHJ1Y3QgZHJtX2RldmljZTsKPiA+IC1zdHJ1Y3QgZHJtX2ZiZGV2X2NtYTsKPiA+ICAgc3RydWN0 IHJjYXJfZHVfZGV2aWNlOwo+ID4gICAKPiA+ICAgI2RlZmluZSBSQ0FSX0RVX0ZFQVRVUkVfQ1JU Q19JUlFfQ0xPQ0sJQklUKDApCS8qIFBlci1DUlRDIElSUSBhbmQgY2xvY2sKPiA+ICAgKi8KPiA+ IEBAIC03OCw3ICs3Nyw2IEBAIHN0cnVjdCByY2FyX2R1X2RldmljZSB7Cj4gPiAgIAl2b2lkIF9f aW9tZW0gKm1taW87Cj4gPiAgIAkKPiA+ICAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZGV2Owo+ID4g LQlzdHJ1Y3QgZHJtX2ZiZGV2X2NtYSAqZmJkZXY7Cj4gPiAgIAlzdHJ1Y3QgcmNhcl9kdV9jcnRj IGNydGNzW1JDQVJfRFVfTUFYX0NSVENTXTsKPiA+ICAgCXVuc2lnbmVkIGludCBudW1fY3J0Y3M7 Cj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2tt cy5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfa21zLmMgaW5kZXggNGVi ZDYxZWNiZWUxLi42NTYyODcxYWE3MDYKPiA+IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL3JjYXItZHUvcmNhcl9kdV9rbXMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JjYXIt ZHUvcmNhcl9kdV9rbXMuYwo+ID4gQEAgLTI1NSwxMyArMjU1LDYgQEAgcmNhcl9kdV9mYl9jcmVh dGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0Cj4gPiBkcm1fZmlsZSAqZmlsZV9wcml2 LAo+ID4gICAJcmV0dXJuIGRybV9nZW1fZmJfY3JlYXRlKGRldiwgZmlsZV9wcml2LCBtb2RlX2Nt ZCk7Cj4gPiAgIH0KPiA+IAo+ID4gLXN0YXRpYyB2b2lkIHJjYXJfZHVfb3V0cHV0X3BvbGxfY2hh bmdlZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4gLXsKPiA+IC0Jc3RydWN0IHJjYXJfZHVf ZGV2aWNlICpyY2R1ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+IC0KPiA+IC0JZHJtX2ZiZGV2X2Nt YV9ob3RwbHVnX2V2ZW50KHJjZHUtPmZiZGV2KTsKPiA+IC19Cj4gPiAtCj4gPiAgIC8qIC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQo+ID4gICAgKiBBdG9taWMgQ2hlY2sgYW5kIFVwZGF0ZQo+ID4gICAgKi8KPiA+IEBA IC0zMDgsNyArMzAxLDYgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9jb25maWdfaGVs cGVyX2Z1bmNzCj4gPiByY2FyX2R1X21vZGVfY29uZmlnX2hlbHBlciA9IHsKPiA+ICAgc3RhdGlj IGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9jb25maWdfZnVuY3MgcmNhcl9kdV9tb2RlX2NvbmZpZ19m dW5jcyA9IHsKPiA+ICAgCS5mYl9jcmVhdGUgPSByY2FyX2R1X2ZiX2NyZWF0ZSwKPiA+IC0JLm91 dHB1dF9wb2xsX2NoYW5nZWQgPSByY2FyX2R1X291dHB1dF9wb2xsX2NoYW5nZWQsCj4gPiAgIAku YXRvbWljX2NoZWNrID0gcmNhcl9kdV9hdG9taWNfY2hlY2ssCj4gPiAgIAkuYXRvbWljX2NvbW1p dCA9IGRybV9hdG9taWNfaGVscGVyX2NvbW1pdCwKPiA+ICAgfTsKPiA+IEBAIC01NDMsNyArNTM1 LDYgQEAgaW50IHJjYXJfZHVfbW9kZXNldF9pbml0KHN0cnVjdCByY2FyX2R1X2RldmljZSAqcmNk dSkKPiA+IAo+ID4gICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IHJjZHUtPmRkZXY7Cj4gPiAg IAlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXI7Cj4gPiAtCXN0cnVjdCBkcm1fZmJkZXZfY21h ICpmYmRldjsKPiA+ICAgCXVuc2lnbmVkIGludCBkcGFkMF9zb3VyY2VzOwo+ID4gICAJdW5zaWdu ZWQgaW50IG51bV9lbmNvZGVyczsKPiA+ICAgCXVuc2lnbmVkIGludCBudW1fZ3JvdXBzOwo+ID4g QEAgLTY4MiwxNyArNjczLDUgQEAgaW50IHJjYXJfZHVfbW9kZXNldF9pbml0KHN0cnVjdCByY2Fy X2R1X2RldmljZSAqcmNkdSkKPiA+IAo+ID4gICAJZHJtX2ttc19oZWxwZXJfcG9sbF9pbml0KGRl dik7Cj4gPiAKPiA+IC0JaWYgKGRldi0+bW9kZV9jb25maWcubnVtX2Nvbm5lY3Rvcikgewo+ID4g LQkJZmJkZXYgPSBkcm1fZmJkZXZfY21hX2luaXQoZGV2LCAzMiwKPiA+IC0JCQkJCSAgIGRldi0+ bW9kZV9jb25maWcubnVtX2Nvbm5lY3Rvcik7Cj4gPiAtCQlpZiAoSVNfRVJSKGZiZGV2KSkKPiA+ IC0JCQlyZXR1cm4gUFRSX0VSUihmYmRldik7Cj4gPiAtCj4gPiAtCQlyY2R1LT5mYmRldiA9IGZi ZGV2Owo+ID4gLQl9IGVsc2Ugewo+ID4gLQkJZGV2X2luZm8ocmNkdS0+ZGV2LAo+ID4gLQkJCSAi bm8gY29ubmVjdG9yIGZvdW5kLCBkaXNhYmxpbmcgZmJkZXYgZW11bGF0aW9uXG4iKTsKPiA+IC0J fQo+ID4gLQo+ID4gICAJcmV0dXJuIDA7Cj4gPiAgIH0KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQ aW5jaGFydAoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK