From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:34534 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754821AbcE0VdJ (ORCPT ); Fri, 27 May 2016 17:33:09 -0400 From: Laurent Pinchart To: Sergei Shtylyov Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 4/4] rcar-du: add R8A7794 TCON support Date: Sat, 28 May 2016 00:33:10 +0300 Message-ID: <2917760.oKZGhZUS1H@avalon> In-Reply-To: <3056907.Acy0t71QPW@wasted.cogentembedded.com> References: <1787748.qAADjKK4gv@wasted.cogentembedded.com> <3056907.Acy0t71QPW@wasted.cogentembedded.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Sergei, Thank you for the patch. On Friday 29 Apr 2016 00:05:33 Sergei Shtylyov wrote: > Now that we have the TCON encoder driver, we can start enabling TCON support > for the R-Car SoCs. We have only tested the code on R8A7794 so far, so > let it be the first supported SoC... Please also update the DT bindings. > Based on a large patch by Andrey Gusakov. > > Signed-off-by: Andrey Gusakov > Signed-off-by: Sergei Shtylyov > > --- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > Index: renesas/drivers/gpu/drm/rcar-du/rcar_du_drv.c > =================================================================== > --- renesas.orig/drivers/gpu/drm/rcar-du/rcar_du_drv.c > +++ renesas/drivers/gpu/drm/rcar-du/rcar_du_drv.c > @@ -116,9 +116,7 @@ static const struct rcar_du_device_info > > | RCAR_DU_FEATURE_EXT_CTRL_REGS, > > .num_crtcs = 2, > .routes = { > - /* R8A7794 has two RGB outputs and one (currently unsupported) > - * TCON output. > - */ > + /* R8A7794 has two RGB outputs and one TCON output. */ > [RCAR_DU_OUTPUT_DPAD0] = { > .possible_crtcs = BIT(0), > .encoder_type = DRM_MODE_ENCODER_NONE, > @@ -129,8 +127,14 @@ static const struct rcar_du_device_info > .encoder_type = DRM_MODE_ENCODER_NONE, > .port = 1, > }, > + [RCAR_DU_OUTPUT_TCON] = { > + .possible_crtcs = BIT(0), According to the datasheet TCON can be connected to both DU0 and DU1. > + .encoder_type = DRM_MODE_ENCODER_TCON, > + .port = 2, > + }, > }, > .num_lvds = 0, > + .num_tcon = 1, > }; > > static const struct rcar_du_device_info rcar_du_r8a7795_info = { -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/4] rcar-du: add R8A7794 TCON support Date: Sat, 28 May 2016 00:33:10 +0300 Message-ID: <2917760.oKZGhZUS1H@avalon> References: <1787748.qAADjKK4gv@wasted.cogentembedded.com> <3056907.Acy0t71QPW@wasted.cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ECB76E294 for ; Fri, 27 May 2016 21:33:09 +0000 (UTC) In-Reply-To: <3056907.Acy0t71QPW@wasted.cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sergei Shtylyov Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgU2VyZ2VpLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXkgMjkgQXByIDIw MTYgMDA6MDU6MzMgU2VyZ2VpIFNodHlseW92IHdyb3RlOgo+IE5vdyB0aGF0IHdlIGhhdmUgdGhl IFRDT04gZW5jb2RlciBkcml2ZXIsIHdlIGNhbiBzdGFydCBlbmFibGluZyBUQ09OIHN1cHBvcnQK PiBmb3IgdGhlICBSLUNhciBTb0NzLiBXZSBoYXZlIG9ubHkgdGVzdGVkIHRoZSBjb2RlIG9uIFI4 QTc3OTQgc28gZmFyLCBzbyAKPiBsZXQgaXQgIGJlIHRoZSBmaXJzdCBzdXBwb3J0ZWQgU29DLi4u CgpQbGVhc2UgYWxzbyB1cGRhdGUgdGhlIERUIGJpbmRpbmdzLgoKPiBCYXNlZCBvbiBhIGxhcmdl IHBhdGNoIGJ5IEFuZHJleSBHdXNha292Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJleSBHdXNh a292IDxhbmRyZXkuZ3VzYWtvdkBjb2dlbnRlbWJlZGRlZC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog U2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0eWx5b3ZAY29nZW50ZW1iZWRkZWQuY29tPgo+IAo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2Rydi5jIHwgICAxMCArKysr KysrLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0p Cj4gCj4gSW5kZXg6IHJlbmVzYXMvZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9kcnYu Ywo+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KPiAtLS0gcmVuZXNhcy5vcmlnL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1 L3JjYXJfZHVfZHJ2LmMKPiArKysgcmVuZXNhcy9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2Fy X2R1X2Rydi5jCj4gQEAgLTExNiw5ICsxMTYsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHJjYXJf ZHVfZGV2aWNlX2luZm8KPiAKPiAgCQkgIHwgUkNBUl9EVV9GRUFUVVJFX0VYVF9DVFJMX1JFR1Ms Cj4gCj4gIAkubnVtX2NydGNzID0gMiwKPiAgCS5yb3V0ZXMgPSB7Cj4gLQkJLyogUjhBNzc5NCBo YXMgdHdvIFJHQiBvdXRwdXRzIGFuZCBvbmUgKGN1cnJlbnRseSB1bnN1cHBvcnRlZCkKPiAtCQkg KiBUQ09OIG91dHB1dC4KPiAtCQkgKi8KPiArCQkvKiBSOEE3Nzk0IGhhcyB0d28gUkdCIG91dHB1 dHMgYW5kIG9uZSBUQ09OIG91dHB1dC4gKi8KPiAgCQlbUkNBUl9EVV9PVVRQVVRfRFBBRDBdID0g ewo+ICAJCQkucG9zc2libGVfY3J0Y3MgPSBCSVQoMCksCj4gIAkJCS5lbmNvZGVyX3R5cGUgPSBE Uk1fTU9ERV9FTkNPREVSX05PTkUsCj4gQEAgLTEyOSw4ICsxMjcsMTQgQEAgc3RhdGljIGNvbnN0 IHN0cnVjdCByY2FyX2R1X2RldmljZV9pbmZvCj4gIAkJCS5lbmNvZGVyX3R5cGUgPSBEUk1fTU9E RV9FTkNPREVSX05PTkUsCj4gIAkJCS5wb3J0ID0gMSwKPiAgCQl9LAo+ICsJCVtSQ0FSX0RVX09V VFBVVF9UQ09OXSA9IHsKPiArCQkJLnBvc3NpYmxlX2NydGNzID0gQklUKDApLAoKQWNjb3JkaW5n IHRvIHRoZSBkYXRhc2hlZXQgVENPTiBjYW4gYmUgY29ubmVjdGVkIHRvIGJvdGggRFUwIGFuZCBE VTEuCgo+ICsJCQkuZW5jb2Rlcl90eXBlID0gRFJNX01PREVfRU5DT0RFUl9UQ09OLAo+ICsJCQku cG9ydCA9IDIsCj4gKwkJfSwKPiAgCX0sCj4gIAkubnVtX2x2ZHMgPSAwLAo+ICsJLm51bV90Y29u ID0gMSwKPiAgfTsKPiAKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCByY2FyX2R1X2RldmljZV9pbmZv IHJjYXJfZHVfcjhhNzc5NV9pbmZvID0gewoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK