All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Dominique Martinet <asmadeus@codewreck.org>
Cc: dhowells@redhat.com, linux-api@vger.kernel.org,
	libc-alpha@sourceware.org, Quentin Bouget <quentin.bouget@cea.fr>,
	Jeff Layton <jlayton@kernel.org>,
	Florian Weimer <fweimer@redhat.com>
Subject: Re: statx struct's stx_size pointer compatibility with uint64_t/size_t
Date: Tue, 17 Dec 2019 18:17:59 +0000	[thread overview]
Message-ID: <2919.1576606679@warthog.procyon.org.uk> (raw)
In-Reply-To: <20191217165350.GA10729@nautica>

Dominique Martinet <asmadeus@codewreck.org> wrote:

> Looking at this from a kernel's point of view, it looks like there
> really was a will to simplify 64-bit ints handling over all arches and
> have them all define 64-bit ints as long long a few years back.

Think printk() too.  Do you use "%lu", "%Lu" or "%llu"?  It's a lot easier if
__u64 is consistently unsigned long long - then it's always "%llu".

The problem with defining it as "unsigned long" on some platforms and
"unsigned long long" on others is that you're guaranteed warnings on one arch
or another.

David

  reply	other threads:[~2019-12-17 18:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87r213aykv.fsf@oldenburg2.str.redhat.com>
2019-12-17 15:21 ` statx struct's stx_size pointer compatibility with uint64_t/size_t Dominique Martinet
2019-12-17 16:53   ` Dominique Martinet
2019-12-17 18:17     ` David Howells [this message]
2019-12-18 11:51     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2919.1576606679@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=asmadeus@codewreck.org \
    --cc=fweimer@redhat.com \
    --cc=jlayton@kernel.org \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-api@vger.kernel.org \
    --cc=quentin.bouget@cea.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.