All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@intel.com>
To: Pranay Mankad <Pranay.Mankad@synopsys.com>
Cc: "yocto@yoctoproject.org" <yocto@yoctoproject.org>
Subject: Re: [layerindex-web] PR / PE in layer index
Date: Tue, 24 Sep 2019 11:06:08 +1200	[thread overview]
Message-ID: <2920538.de2hu5c8aW@linux.fritz.box> (raw)
In-Reply-To: <2643E093-5797-443F-BC92-04355516688A@synopsys.com>

Hi Pranay

On Tuesday, 24 September 2019 10:00:46 AM NZST Pranay Mankad wrote:
> Thank you for supporting the recipesExtended view over the last couple of
> days. Here’s a small patch that includes values from two more variables from
> the Bitbake cooker – PR and PE.
> 
> I read through Paul’s explanation of why PE made sense but not PR, and
> thinking about it, the PR in layerindexs’ case shows if the untouched recipe
> had a revision associated with or not. Source metadata is important for
> information, and hence I’m submitting a change with the same.

I suppose so yes. Out of interest I did a search of OE-Core and there were 
more recipes than I would have guessed that set PR, so it could perhaps be 
useful. I'm not sure I'd bother adding it to the UI yet though (and you 
haven't, that's fine.)
 
> Here’s the patch (this is my first time submitting one, hopefully it’s the
> right way to do it):

So unfortunately no, you need to send it as an actual patch and not just 
pasted into an email - git-format-patch / git-send-email are the most 
effective ways to do that (though it assumes you are able to send email 
directly from your linux system). Here's some info:

http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded

(Of course you'd need to change mailing lists / prefixes in the examples, and 
some of the metadata requirements don't apply, but the basics are the same.)

One other thing - you're editing the initial migration (layerindex/migrations/
0001_initial.py) - that's not right. You need to undo the change to 
0001_initial.py and then generate a new migration using the following command:

./manage.py createmigrations layerindex

That will give you a new migration in layerindex/migrations/. You can then 
apply that migration to the database in the normal way:

./manage.py migrate layerindex

Of course if your database already has those new fields the latter will fail, 
in this instance you could simply add --fake since the result would have been 
the same.

Cheers,
Paul

-- 
Paul Eggleton
Intel Open Source Technology Centre




      reply	other threads:[~2019-09-23 23:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-23 22:00 [layerindex-web] Pranay Mankad
2019-09-23 23:06 ` Paul Eggleton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2920538.de2hu5c8aW@linux.fritz.box \
    --to=paul.eggleton@intel.com \
    --cc=Pranay.Mankad@synopsys.com \
    --cc=yocto@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.