From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v10 0/7] Expanded statistics reporting
Date: Thu, 16 Feb 2017 11:53:14 +0100
Message-ID: <2924793.QDCoddA1K3@xps13>
References: <1486118019-2280-1-git-send-email-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com
 [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 721815583
 for <dev@dpdk.org>; Thu, 16 Feb 2017 11:53:16 +0100 (CET)
Received: by mail-wr0-f174.google.com with SMTP id i10so8901298wrb.0
 for <dev@dpdk.org>; Thu, 16 Feb 2017 02:53:16 -0800 (PST)
In-Reply-To: <1486118019-2280-1-git-send-email-remy.horton@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-02-03 10:33, Remy Horton:
> This patchset extends statistics reporting to include peak and
> average data-rate metrics. It comes in two parts: a statistics
> reporting library, and a bitrate calculation library that uses
> it. This structure is intended to seperate statistic reporting
> from ethdev and allow more flexible metric registration.

Note that this series integrates a third part for latency metric.

> v10 changes:
> * Rebased
> * Relocated some config-related directives.
> * Removed incorrect capitalisations in API docs.
> * Formatting & detail corrections in release notes.
> * Moved around struct member descriptions.
> * Rewritten rte_metrics.h file description.
> * Rewritten description of RTE_METRICS_GLOBAL.
> * Used 'producers' and 'consumers' as terms.
> * Removed markup (bold text) in Doxygen tags.
> * Added programming guide section.

Thanks for adding the prog guide section. It helps.

I think there are three remaining questions:
- When the metrics computation are done? (in which thread?)
- May the few lines of computation code be done differently when tightly
integrated in an application logic?
- Could it be hosted in a separate repository on dpdk.org?