From: luoj@codeaurora.org
To: Andrew Lunn <andrew@lunn.ch>
Cc: hkallweit1@gmail.com, davem@davemloft.net, kuba@kernel.org,
p.zabel@pengutronix.de, agross@kernel.org,
bjorn.andersson@linaro.org, robh+dt@kernel.org,
robert.marko@sartura.hr, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, sricharan@codeaurora.org
Subject: Re: [PATCH 3/3] dt-bindings: net: rename Qualcomm IPQ MDIO bindings
Date: Mon, 02 Aug 2021 14:02:10 +0800 [thread overview]
Message-ID: <29253aa91875a05ab086c229da50dfb6@codeaurora.org> (raw)
In-Reply-To: <YQKqhoJ4iPOTiGHZ@lunn.ch>
On 2021-07-29 21:17, Andrew Lunn wrote:
>> @@ -23,7 +25,29 @@ properties:
>> const: 0
>>
>> reg:
>> - maxItems: 1
>> + maxItems: 2
>> +
>> + clocks:
>> + items:
>> + - description: MDIO clock
>> +
>> + clock-names:
>> + items:
>> + - const: gcc_mdio_ahb_clk
>> +
>> + resets:
>> + items:
>> + - description: MDIO reset & GEPHY hardware reset
>> +
>> + reset-names:
>> + items:
>> + - const: gephy_mdc_rst
>> +
>> + phy-reset-gpios:
>> + maxItems: 3
>> + description:
>> + The phandle and specifier for the GPIO that controls the RESET
>> + lines of PHY devices on that MDIO bus.
>
> This is clearly not a rename. It is great you are adding missing
> properties, but please do it as a separate patch.
>
> Andrew
> Hi Andrew, thanks for the comments, will separate it out in the next
> patch set.
next prev parent reply other threads:[~2021-08-02 6:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 12:53 [PATCH 1/3] net: mdio-ipq4019: Add mdio reset function Luo Jie
2021-07-29 12:53 ` [PATCH 2/3] net: mdio-ipq4019: rename mdio_ipq4019 to mdio_ipq Luo Jie
2021-07-29 13:15 ` Andrew Lunn
2021-08-02 5:56 ` luoj
2021-07-29 12:53 ` [PATCH 3/3] dt-bindings: net: rename Qualcomm IPQ MDIO bindings Luo Jie
2021-07-29 13:17 ` Andrew Lunn
2021-08-02 6:02 ` luoj [this message]
2021-07-29 13:57 ` Rob Herring
2021-07-29 17:29 ` Rob Herring
2021-08-02 7:19 ` luoj
2021-08-02 13:39 ` Andrew Lunn
2021-08-04 2:37 ` Jie Luo
2021-07-29 13:26 ` [PATCH 1/3] net: mdio-ipq4019: Add mdio reset function Andrew Lunn
2021-08-02 6:46 ` luoj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29253aa91875a05ab086c229da50dfb6@codeaurora.org \
--to=luoj@codeaurora.org \
--cc=agross@kernel.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.