From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 36/36] doc: update release notes for e1000
	base code update
Date: Tue, 27 Oct 2015 16:32:06 +0100
Message-ID: <2926566.0QgzZF02lo@xps13>
References: <1444804479-14840-1-git-send-email-wenzhuo.lu@intel.com>
 <1444963882-30931-1-git-send-email-wenzhuo.lu@intel.com>
 <1444963882-30931-37-git-send-email-wenzhuo.lu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id F2E8C8D9A
 for <dev@dpdk.org>; Tue, 27 Oct 2015 16:33:15 +0100 (CET)
Received: by wikq8 with SMTP id q8so217237706wik.1
 for <dev@dpdk.org>; Tue, 27 Oct 2015 08:33:15 -0700 (PDT)
In-Reply-To: <1444963882-30931-37-git-send-email-wenzhuo.lu@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-10-16 10:51, Wenzhuo Lu:
>  New Features
>  ------------
>  
> +* **Updated the e1000 base driver.**
> +  The e1000 base driver was updated with several changes including the
> +  following:
> +
> +  * Add some new i218 devices
> +  * Fix issue with link flap on 82579
> +  * Fix issue with jumbo frame CRC failures in client
> +  * Add support for inverted format ETrackId
> +  * Add flags to set eee advertisement modes
> +  * Prevent ulp flow if cable connected
> +  * Cleanup NAHUM6LP_HW tags

Is it really a feature?

> +  * Use the correct i210 register for EEMNGCTL
> +  * Fix to enable both ulp and EEE in Sx state
> +  * Fix link detect flow
> +  * Set correct value of beacon duration
> +  * Disable extension header parsing for IPv6
> +  * Fix for i354 88E1112 PHY using AutoMedia Detect
> +  * Implement 88E1543 PHY initialization
> +  * Increase timeout of polling bit RSPCIPHY in check_reset_block
> +  * Synchronization of MAC-PHY interface only on non- ME systems

Some of theses features are not easy to understand.
Please avoid to speak of the registers in the release notes.
Something more high level is expected.

> +  See the git log for full details of the e1000/base changes.

This last sentence is valuable for any entry in the release notes.
Let's say it is implicit.

>  Resolved Issues
>  ---------------

Some of the fixes above should be in this section.

John, please could you check?

Thanks