From: Quentin Monnet <qmo@kernel.org>
To: Leon Hwang <leon.hwang@linux.dev>, bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
yonghong.song@linux.dev, gray.liang@isovalent.com,
stfomichev@gmail.com, kernel-patches-bot@fb.com
Subject: Re: [PATCH bpf v3] bpf, bpftool: Fix incorrect disasm pc
Date: Thu, 31 Oct 2024 16:15:14 +0000 [thread overview]
Message-ID: <292fa9b1-3302-4cb7-b7dc-903a3f1b70c7@kernel.org> (raw)
In-Reply-To: <20241031152844.68817-1-leon.hwang@linux.dev>
2024-10-31 23:28 UTC+0800 ~ Leon Hwang <leon.hwang@linux.dev>
> This patch addresses the bpftool issue "Wrong callq address displayed"[0].
>
> The issue stemmed from an incorrect program counter (PC) value used during
> disassembly with LLVM or libbfd.
>
> For LLVM: The PC argument must represent the actual address in the kernel
> to compute the correct relative address.
>
> For libbfd: The relative address can be adjusted by adding func_ksym within
> the custom info->print_address_func to yield the correct address.
>
> Links:
> [0] https://github.com/libbpf/bpftool/issues/109
>
> Changes:
> v2 -> v3:
> * Address comment from Quentin:
> * Remove the typedef.
>
> v1 -> v2:
> * Fix the broken libbfd disassembler.
>
> Fixes: e1947c750ffe ("bpftool: Refactor disassembler for JIT-ed programs")
> Acked-by: Yonghong Song <yonghong.song@linux.dev>
> Signed-off-by: Leon Hwang <leon.hwang@linux.dev>
Thanks a lot!
Tested-by: Quentin Monnet <qmo@kernel.org>
Reviewed-by: Quentin Monnet <qmo@kernel.org>
next prev parent reply other threads:[~2024-10-31 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 15:28 [PATCH bpf v3] bpf, bpftool: Fix incorrect disasm pc Leon Hwang
2024-10-31 16:15 ` Quentin Monnet [this message]
2024-11-01 19:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=292fa9b1-3302-4cb7-b7dc-903a3f1b70c7@kernel.org \
--to=qmo@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gray.liang@isovalent.com \
--cc=kernel-patches-bot@fb.com \
--cc=leon.hwang@linux.dev \
--cc=stfomichev@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.