From: Dave Hansen <dave.hansen@intel.com>
To: Adrian Hunter <adrian.hunter@intel.com>, Jiri Olsa <olsajiri@gmail.com>
Cc: lirongqing <lirongqing@baidu.com>,
peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
namhyung@kernel.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, irogers@google.com,
kan.liang@linux.intel.com, tglx@linutronix.de, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/x86/intel/bts: allocate bts_ctx only if necessary
Date: Wed, 5 Mar 2025 08:11:40 -0800 [thread overview]
Message-ID: <293158f0-d36f-4569-bad3-6be1db938457@intel.com> (raw)
In-Reply-To: <d70b6f8d-0e86-4814-bf05-4c3d9acd313d@intel.com>
Jiri, thanks for the report!
On 3/5/25 06:58, Adrian Hunter wrote:
> It looks like there are 3 functions affected:
>
> intel_bts_enable_local()
> intel_bts_disable_local()
> intel_bts_interrupt()
>
> Perhaps make them static calls?
That, or a few:
if (!bts_ctx)
return;
if you're not feeling as fancy would do.
Would someone be interested in sending an actual tested patch, ideally
the patch author of the regression? <hint, hint>
next prev parent reply other threads:[~2025-03-05 16:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 7:41 [PATCH] perf/x86/intel/bts: allocate bts_ctx only if necessary lirongqing
2025-01-23 18:36 ` Adrian Hunter
2025-01-23 18:54 ` Liang, Kan
2025-02-22 12:53 ` [tip: perf/core] perf/x86/intel/bts: Allocate " tip-bot2 for Li RongQing
2025-03-05 13:47 ` [PATCH] perf/x86/intel/bts: allocate " Jiri Olsa
2025-03-05 13:54 ` Jiri Olsa
2025-03-05 14:58 ` Adrian Hunter
2025-03-05 16:11 ` Dave Hansen [this message]
2025-03-06 2:28 ` 答复: [外部邮件] " Li,Rongqing
[not found] <20241030063521.4025-1-lirongqing@baidu.com>
2024-10-30 7:26 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=293158f0-d36f-4569-bad3-6be1db938457@intel.com \
--to=dave.hansen@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=irogers@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=olsajiri@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.