From: Thomas Monjalon <thomas@monjalon.net>
To: Ivan Malov <ivan.malov@oktetlabs.ru>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>
Subject: Re: [dpdk-dev] [PATCH v3] mbuf: outer offsets are undefined for non-tunnel packets
Date: Mon, 01 Jul 2019 16:37:38 +0200 [thread overview]
Message-ID: <2937548.CbNlbEgAvt@xps> (raw)
In-Reply-To: <20190701131044.ifakclavrrs6an3s@platinum>
01/07/2019 15:10, Olivier Matz:
> On Fri, Jun 28, 2019 at 12:06:18AM +0300, Ivan Malov wrote:
> > The default policy for offload-specific fields is that
> > they are undefined unless the corresponding offloads are
> > requested in mbuf ol_flags. This is also the case for outer
> > L2 and L3 length fields which must not be assumed to contain
> > zeros for non-tunnel packets. The patch clarifies this behaviour
> > in the comments and also adds appropriate checks to the PMDs which
> > do not check any tunnel-related offloads before using the said fields.
> >
> > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> > Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
prev parent reply other threads:[~2019-07-01 14:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 15:05 [dpdk-dev] [RFC PATCH] mbuf: outer offsets must be zero for non-tunnel packets Ivan Malov
2019-06-21 10:34 ` [dpdk-dev] [PATCH] " Ivan Malov
2019-06-21 11:10 ` Ananyev, Konstantin
2019-06-21 12:35 ` Andrew Rybchenko
2019-06-24 12:59 ` Ananyev, Konstantin
2019-06-24 13:33 ` Andrew Rybchenko
2019-06-24 16:02 ` [dpdk-dev] [PATCH v2] mbuf: outer offsets are undefined " Ivan Malov
2019-06-27 13:09 ` Ananyev, Konstantin
2019-06-27 21:06 ` [dpdk-dev] [PATCH v3] " Ivan Malov
2019-07-01 13:10 ` Olivier Matz
2019-07-01 14:37 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2937548.CbNlbEgAvt@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ivan.malov@oktetlabs.ru \
--cc=konstantin.ananyev@intel.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.