From: Thomas Monjalon <thomas@monjalon.net>
To: ferruh.yigit@intel.com, arybchenko@solarflare.com
Cc: dev@dpdk.org
Subject: [dpdk-dev] discussion about VLAN API
Date: Tue, 04 Aug 2020 12:02:03 +0200 [thread overview]
Message-ID: <2943505.b7sj8NLL2l@thomas> (raw)
Hi,
We have a quite complex API for VLAN filter/push/pop,
per port, per queue or per flow.
These are the old per-port functions:
rte_eth_dev_vlan_filter
rte_eth_dev_set_vlan_strip_on_queue
rte_eth_dev_set_vlan_ether_type
rte_eth_dev_set_vlan_offload
rte_eth_dev_get_vlan_offload
rte_eth_dev_set_vlan_pvid
In rte_eth_dev_data:
struct rte_vlan_filter_conf vlan_filter_conf
In rte_eth_txmode struct:
uint16_t pvid;
hw_vlan_reject_tagged : 1,
hw_vlan_reject_untagged : 1,
hw_vlan_insert_pvid : 1;
Configurartion flags:
ETH_VLAN_STRIP_OFFLOAD
ETH_VLAN_FILTER_OFFLOAD
ETH_VLAN_EXTEND_OFFLOAD
ETH_QINQ_STRIP_OFFLOAD
RX offload capabilities:
DEV_RX_OFFLOAD_VLAN_STRIP
DEV_RX_OFFLOAD_VLAN_FILTER
DEV_RX_OFFLOAD_VLAN_EXTEND
DEV_RX_OFFLOAD_QINQ_STRIP
TX offload capabilities:
DEV_TX_OFFLOAD_VLAN_INSERT
Types:
ETH_VLAN_TYPE_UNKNOWN
ETH_VLAN_TYPE_INNER
ETH_VLAN_TYPE_OUTER
rte_flow configuration:
RTE_FLOW_ITEM_TYPE_VLAN
RTE_FLOW_ACTION_TYPE_OF_POP_VLAN
RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN
RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID
RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP
What can be done to simplify this mess?
Wouldn't it be simpler to keep only rte_flow?
reply other threads:[~2020-08-04 10:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2943505.b7sj8NLL2l@thomas \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.