From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: wanting clarification on overrides, _append, += and combinations of those
Date: Mon, 26 Nov 2012 11:19:47 +0000 [thread overview]
Message-ID: <29436129.kTOWlB2TST@helios> (raw)
In-Reply-To: <alpine.DEB.2.02.1211240910580.934@oneiric>
On Saturday 24 November 2012 09:23:20 Robert P. J. Day wrote:
> preparing my own write-up on how bitbake processes combinations of
> overrides, _append and += and ran across an example in oe-core that is
> unnecessarily whitespacey, just wanted to make sure i was
> understanding this properly.
>
> in the current bitbake user manual, there's this example of mixing
> overrides, _append and +=:
>
> OVERRIDES = "foo"
> A_foo_append = "X"
> A_foo_append += "Y"
>
> This behaves as per the first case above, but the value of A would
> be "X Y" instead of just "X".
>
> that, of course, makes sense as the "+=" operator automatically adds
> a leading space to what is being appended. so for fun, i scanned all
> of oe-core looking for examples of "_append.*+=" for classroom demo
> purposes, and the *only* examples i found were in
> meta/recipes-devtools/python/python-smartpm_1.4.1.bb:
>
> RDEPENDS_python-smartpm_append = " python-smartpm-backend-rpm python-codecs
> python-textutils python-xml" RDEPENDS_python-smartpm_append += "
> python-fcntl python-pickle python-crypt python-compression python-shell"
> RDEPENDS_python-smartpm_append += " python-resource python-netclient
> python-threading python-unixadmin"
>
> i can see that that first line *does* need an explicit leading space
> in the value being assigned, but the next two "+=" lines don't, do
> they? it won't hurt, of course, you'll just *two* spaces inserted
> instead of one. but i just want to make sure i understand what's
> happening there since it has the potential to be confusing for someone
> trying to follow along.
I would strongly discourage the use of += in conjunction with _append because
the intent is unclear - I think we've discussed this before; this is just a
case where it slipped through. Ideally this would just be done as a += split
onto multiple lines and I will make sure it gets changed to that if someone
else doesn't get to it first.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-11-26 11:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-24 14:23 wanting clarification on overrides, _append, += and combinations of those Robert P. J. Day
2012-11-24 14:42 ` Robert P. J. Day
2012-11-25 21:39 ` Richard Purdie
2012-11-25 21:38 ` Richard Purdie
2012-11-26 11:19 ` Paul Eggleton [this message]
2012-11-26 11:53 ` Robert P. J. Day
2012-11-26 12:35 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29436129.kTOWlB2TST@helios \
--to=paul.eggleton@linux.intel.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.