All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nish Aravamudan <nish.aravamudan@gmail.com>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: greg@kroah.com, linux-usb-devel@lists.sourceforge.net,
	rwhite@casabyte.com, linux-kernel@vger.kernel.org,
	kingst@eecs.umich.edu, paulkf@microgate.com,
	oleksiy@kharkiv.com.ua, reg@dwf.com, clemens@dwf.com
Subject: Re: Little rework of usbserial in 2.4
Date: Sun, 12 Dec 2004 15:47:44 -0800	[thread overview]
Message-ID: <29495f1d0412121547c0c644d@mail.gmail.com> (raw)
In-Reply-To: <20041127173558.4011b177@lembas.zaitcev.lan>

On Sat, 27 Nov 2004 17:35:58 -0800, Pete Zaitcev <zaitcev@redhat.com> wrote:
> Hi, Greg, hi, guys:

<snip>

> diff -urpN -X dontdiff linux-2.4.28-bk3/drivers/usb/serial/usbserial.c linux-2.4.28-bk3-sx4/drivers/usb/serial/usbserial.c
> --- linux-2.4.28-bk3/drivers/usb/serial/usbserial.c     2004-11-22 23:04:19.000000000 -0800
> +++ linux-2.4.28-bk3-sx4/drivers/usb/serial/usbserial.c 2004-11-27 10:36:49.000000000 -0800

<snip>

> @@ -1803,6 +1820,12 @@ static void __exit usb_serial_exit(void)
> 
>         usb_deregister(&usb_serial_driver);
>         tty_unregister_driver(&serial_tty_driver);
> +
> +       while (!list_empty(&usb_serial_driver_list)) {
> +               err("%s - module is in use, hanging...\n", __FUNCTION__);
> +               set_current_state(TASK_UNINTERRUPTIBLE);
> +               schedule_timeout(5*HZ);
> +       }

Please consider using msleep() here instead of schedule_timeout().

Thanks,
Nish

  parent reply	other threads:[~2004-12-12 23:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-28  1:35 Little rework of usbserial in 2.4 Pete Zaitcev
2004-11-28 14:20 ` Paul Fulghum
2004-11-28 18:14   ` Paul Fulghum
2004-12-12 23:47 ` Nish Aravamudan [this message]
2004-12-21 20:52   ` Pete Zaitcev
2004-12-22 16:07     ` Nish Aravamudan
2004-12-22 17:24       ` Little rework of usbserial in 2.4\ Marcelo Tosatti
2004-12-18  0:57 ` Little rework of usbserial in 2.4 Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29495f1d0412121547c0c644d@mail.gmail.com \
    --to=nish.aravamudan@gmail.com \
    --cc=clemens@dwf.com \
    --cc=greg@kroah.com \
    --cc=kingst@eecs.umich.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=oleksiy@kharkiv.com.ua \
    --cc=paulkf@microgate.com \
    --cc=reg@dwf.com \
    --cc=rwhite@casabyte.com \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.