All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nish Aravamudan <nish.aravamudan@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 19/34]: include/jiffies: add usecs_to_jiffies()
Date: Wed, 26 Jan 2005 18:04:12 +0000	[thread overview]
Message-ID: <29495f1d0501261004376c457e@mail.gmail.com> (raw)
In-Reply-To: <20050126173632.GA2758@us.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

On Wed, 26 Jan 2005 18:55:51 +0100, walter harms <wharms@bfs.de> wrote:
> 
> hi Nish,
> do we need jiffies_to_msecs() at all ?
> 
> milli is 10E-3   micro is 10E-6
> i would say:
> #define jiffies_to_msecs(VAL) jiffies_to_usecs(1000*VAL)

I am not sure that would work as expected. It would be better to:

#define jiffies_to_msecs(VAL) (jiffies_to_usecs(VAL) / 1000)
#define msecs_to_jiffies(VAL) (usecs_to_jiffies(VAL * 1000))
 
> I have no idea about the range of VAL but uint is ~ 1E9.
> is anyone using something like 1E6 ms = 1E3s to wait ?
> if not we kan simply drop jiffies_to_msecs() (and back).

I would rather see the macro get pushed in and then deal with
optimizing code :) One little tiny itty-bit step at a time, Walter ;)

-Nish

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2005-01-26 18:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-25 23:37 [KJ] [PATCH] 19/34: include/jiffies: add usecs_to_jiffies() function Nishanth Aravamudan
2005-01-26  2:51 ` [KJ] Re: [PATCH] 19/34: include/jiffies: add usecs_to_jiffies() Andrew Morton
2005-01-26 17:36   ` [KJ] [PATCH 19/34]: include/jiffies: add usecs_to_jiffies() function Nishanth Aravamudan
2005-01-26 17:36     ` Nishanth Aravamudan
2005-01-26 17:55     ` [KJ] [PATCH 19/34]: include/jiffies: add usecs_to_jiffies() walter harms
2005-01-26 18:04     ` Nish Aravamudan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29495f1d0501261004376c457e@mail.gmail.com \
    --to=nish.aravamudan@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.