From: Nish Aravamudan <nish.aravamudan@gmail.com>
To: Martin Hicks <mort@wildopensource.com>
Cc: Paul Jackson <pj@sgi.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org, raybry@sgi.com
Subject: Re: [PATCH/RFC] A method for clearing out page cache
Date: Mon, 21 Feb 2005 13:52:56 -0800 [thread overview]
Message-ID: <29495f1d0502211352776cfb36@mail.gmail.com> (raw)
In-Reply-To: <20050221192721.GB26705@localhost>
On Mon, 21 Feb 2005 14:27:21 -0500, Martin Hicks
<mort@wildopensource.com> wrote:
>
> Hi,
>
> I've made a bunch of changes that Paul suggested. I've also responded
> to his concerns further down. Paul correctly pointed out that this
> patch uses some helper functions that are part of the cpusets patch. I
> should have mentioned this before.
<snip>
> This patch introduces a new sysctl for NUMA systems that tries to drop
> as much of the page cache as possible from a set of nodes. The
> motivation for this patch is for setting up High Performance Computing
> jobs, where initial memory placement is very important to overall
> performance.
<snip>
> + /* wait for the kernel threads to complete */
> + while (atomic_read(&num_toss_threads_active) > 0) {
> + __set_current_state(TASK_INTERRUPTIBLE);
> + schedule_timeout(10);
> + }
<snip>
Would it be possible to use msleep_interruptible() here? Or is it a
strict check every 10 ticks, regardless of HZ? Could a comment be
inserted indicating
which is the case?
Thanks,
Nish
prev parent reply other threads:[~2005-02-21 21:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 15:44 [PATCH/RFC] A method for clearing out page cache Martin Hicks
2005-02-15 3:37 ` Paul Jackson
2005-02-16 19:56 ` Martin Hicks
2005-02-21 19:27 ` Martin Hicks
2005-02-21 21:42 ` Andrew Morton
2005-02-21 22:12 ` Paul Jackson
2005-02-21 22:28 ` Andrew Morton
2005-02-21 23:52 ` Paul Jackson
2005-02-21 22:28 ` Ray Bryant
2005-02-21 22:41 ` Andrew Morton
2005-02-21 23:01 ` Ray Bryant
2005-02-22 7:53 ` Ingo Molnar
2005-02-22 8:07 ` Andrew Morton
2005-02-22 8:24 ` Ingo Molnar
2005-02-22 17:29 ` Ray Bryant
2005-02-22 11:26 ` Paul Jackson
2005-02-22 18:45 ` Andrew Morton
2005-02-22 18:59 ` Martin Hicks
2005-02-22 19:03 ` Ray Bryant
2005-02-23 0:14 ` Paul Jackson
2005-03-01 21:54 ` Pavel Machek
2005-02-21 21:52 ` Nish Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29495f1d0502211352776cfb36@mail.gmail.com \
--to=nish.aravamudan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mort@wildopensource.com \
--cc=pj@sgi.com \
--cc=raybry@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.