From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nish Aravamudan <nish.aravamudan@gmail.com>
Date: Wed, 13 Apr 2005 16:09:53 +0000
Subject: Re: [KJ] [PATCH] drivers/net/hp100.c : Use of time_after() macro
Message-Id: <29495f1d05041309094c078945@mail.gmail.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <425A922C.6080100@feitoza.com.br>
In-Reply-To: <425A922C.6080100@feitoza.com.br>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

On 4/11/05, Marcelo Feitoza Parisi <marcelo@feitoza.com.br> wrote:
> Use of time_after() macro, defined at linux/jiffies.h, which deal with
> wrapping correctly and are nicer to read.
> 
> --
> Marcelo Feitoza Parisi
> marcelo at feitoza.com.br
> http://marcelo.feitoza.com.br/
> 
> Marcelo Feitoza Parisi <marcelo@feitoza.com.br>
> 
> --- linux/drivers/net/hp100.c   2005-03-02 04:38:04.000000000 -0300
> +++ development/drivers/net/hp100.c     2005-04-09 18:42:14.000000000 -0300
> @@ -115,6 +115,7 @@
>  #include <linux/delay.h>
>  #include <linux/init.h>
>  #include <linux/bitops.h>
> +#include <linux/jiffies.h>
> 
>  #include <asm/io.h>
> 
> @@ -1493,7 +1494,7 @@ static int hp100_start_xmit_bm(struct sk
>                 printk("hp100: %s: start_xmit_bm: No TX PDL available.\n", dev->name);
>  #endif
>                 /* not waited long enough since last tx? */
> -               if (jiffies - dev->trans_start < HZ)
> +               if (time_after(jiffies, dev->trans_start - HZ))

<snip>

> -               if (jiffies - dev->trans_start < HZ) {
> +               if (time_after(jiffies, dev->trans_start - HZ)) {

I think these both should be

if (time_before(jiffies, dev->trans_start + HZ))

Thanks,
Nish

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors