From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine Date: Tue, 22 Jul 2014 15:16:53 +0200 Message-ID: <2950078.WJQuDn5Q4k@avalon> References: <87sim0ece5.wl%kuninori.morimoto.gx@gmail.com> <3713363.Y2xICgEKrb@avalon> <87lhrmi0jp.wl%kuninori.morimoto.gx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by alsa0.perex.cz (Postfix) with ESMTP id E18042654E9 for ; Tue, 22 Jul 2014 15:16:44 +0200 (CEST) In-Reply-To: <87lhrmi0jp.wl%kuninori.morimoto.gx@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Kuninori Morimoto Cc: Linux-ALSA , Mark Brown , Liam Girdwood , Simon List-Id: alsa-devel@alsa-project.org Hi Morimoto-san, On Monday 21 July 2014 19:34:36 Kuninori Morimoto wrote: > Hi Laurent > > > > > What tree is the patch based on ? It doesn't apply on Takashi's latest > > > > master branch. I need a bit of context to review it. > > (snip) > > > I've tried to understand the driver and couldn't even find out which DMA > > controller was used :-/ I suspect it's the audio peri-peri DMAC, but I > > haven't been able to confirm that from the source code. If the assumption > > is true the patch looks OK to me, but if you need a formal Acked-by then > > I'll need you to guide me through the driver I'm afraid. > > Ahh I'm sorry about this confusion. > It uses audio peri-peri DMAC, and, your rcar-dmac (as audio DMAC) > The platform side is not upstreamed yet. > (Because it depends on rcar-dmac) > > But, I posted RFC audio DMAC support patches which > was based on Ben's DMAC before. > > http://www.spinics.net/lists/linux-sh/msg32949.html > > I can re-post this patch if all DMAC was ready No need to, that was enough. Thank you. I've acked the patch. By the way, I'd like to test cyclic transfers with the rcar-dmac driver. Is there an easy (or at least not too difficult) way to do so with your audio driver ? -- Regards, Laurent Pinchart