From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saurabh Singh Subject: Re: [PATCH] Parse missing regulator constraints from device tree blob Date: Fri, 17 Jan 2014 15:04:08 +0000 (GMT) Message-ID: <29524060.615241389971045531.JavaMail.weblogic@epml20> Reply-To: saurabh1.s@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: base64 Return-path: MIME-version: 1.0 Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown , rob.herring@kernel.org Cc: Mark Rutland , "lgirdwood@gmail.com" , "grant.likely@linaro.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "celinux-dev@tree.celinuxforum.org" , SREEVATSA D B , Praveen BP List-Id: devicetree@vger.kernel.org SGkgTWFyaywNCg0KPiBObywgcGxlYXNlIGRvIGFzIEkgYXNrZWQgYW5kIGZvbGxvdyB0aGUgcHJv Y2VzcyBpbiBTdWJtaXR0aW5nUGF0Y2hlcyAtIGFzIEkNCj4gc2FpZCB0aGUgZm9ybWF0IHRoaW5n cyBhcmUgc2VudCBpbiBpcyB2ZXJ5IGltcG9ydGFudCBmb3IgdGhlIHRvb2xpbmcuICBQYXN0aW5n DQo+IHRoZSBwYXRjaCBpbnRvIGEgbWFpbCBhZnRlciBzb21lIG90aGVyIHRleHQgZGVmaW5pdGVs eSBkb2Vzbid0IGdpdmUgYSBtYWlsIGluDQo+IHRoZSBmb3JtYXQgY292ZXJlZCBpbiBTdWJtaXR0 aW5nUGF0Y2hlcy4gIElmIGluIGRvdWJ0IHNlbmQgdGhlIG1haWwgdG8NCj4geW91cnNlbGYgYW5k IHRoZW4gY29tcGFyZSBpdCB3aXRoIG90aGVyIHBhdGNoZXMgc2VudCB0byB0aGUgbGlzdCBhbmQg dGVzdCBieQ0KPiBhcHBseWluZyB3aXRoIGdpdCBhbSBhbmQgbWFrZSBzdXJlIHRoZSBwYXRjaCBh bmQgY2hhbmdlbG9nIGNvbWUgb3V0IE9LLg0KDQpPaywgSSBoYXZlIGNyZWF0ZWQgdGhlIHBhdGNo IHdpdGggZ3VpZGVsaW5lcywgd2hpY2ggSSB3aWxsIGJlIHNlbmRpbmcgaW4gYSBzZXBhcmF0ZSBt YWlsIA0KQWxzbywgdGhpcyB0aW1lIEkgaGF2ZSB0ZXN0ZWQgbXkgcGF0Y2ggaXQgYnkgImdpdCBh bSIuDQoNCj4gPiArLSByZWd1bGF0b3ItdmFsaWQtbW9kZXMtbWFzazogdmFsaWQgb3BlcmF0aW9u cyBmb3IgcmVndWxhdG9yIG9uDQo+ID4gK3BhcnRpY3VsYXIgbWFjaGluZQ0KPiANCj4gVGhpcyBp cyBub3QgYWRlcXVhdGVseSBkb2N1bWVudGVkLCB3aGF0IGFyZSAidmFsaWQgb3BlcmF0aW9ucyIg YW5kIGhvdw0KPiB3b3VsZCB0aGV5IGJlIGVuY29kZWQ/DQoNClByb3ZpZGUgdGhlIGluZm9ybWF0 aW9uIGluIGRvY3VtZW50YXRpb24sIGFuZCBwcm92aWRlIGJldHRlciBhYnN0cmFjdGlvbiBzbyBh cyB0byBoaWRlDQpsaW51eCBpbnRlcm5hbHMgaW4gZGV2aWNlIHRyZWUuDQoNCj4gPiArLSByZWd1 bGF0b3ItaW5wdXQtdXY6IHJlZ3VsYXRvciBpbnB1dCB2b2x0YWdlLCBvbmx5IGlmIHN1cHBseSBp cw0KPiA+ICthbm90aGVyIHJlZ3VsYXRvcg0KPiANCj4gV2h5IHByb3ZpZGUgYSBwcm9wZXJ0eSBm b3IgdGhpcywgc3VyZWx5IGlmIHRoZXJlIGlzIGFub3RoZXIgcmVndWxhdG9yIHdlIGNhbg0KPiBq dXN0IGZpbmQgb3V0IGZyb20gdGhhdCByZWd1bGF0b3Igd2hhdCB2b2x0YWdlIGl0IGlzIG91dHB1 dHRpbmc/DQoNClZhbGlkIHBvaW50ISAsIHJlbW92ZWQgZnJvbSB0aGUgY29kZS4NCg0KPiA+ICst IHJlZ3VsYXRvci1pbml0aWFsLW1vZGU6IGRlZmF1bHQgbW9kZSB0byBzZXQgb24gc3RhcnR1cA0K PiANCj4gSXQgaXMgbm90IGRvY3VtZW50ZWQgd2hhdCBhIG1vZGUgaXMgaGVyZSBvciBob3cgb25l IHdvdWxkIHNwZWNpZnkgaXQgaW4gdGhlDQo+IHByb3BlcnR5Lg0KPiANCj4gPiArLSByZWd1bGF0 b3ItaW5pdGlhbC1zdGF0ZTogc3VzcGVuZCBzdGF0ZSB0byBzZXQgYXQgaW5pdA0KPiANCj4gQWdh aW4sIG5vIHNlbWFudGljcyBhcmUgcHJvdmlkZWQgZm9yIHRoaXMuDQoNCkFkZGVkIGRvY3VtZW50 YXRpb24gd2l0aCBleGFtcGxlDQoNCj4gSSBhbSB2ZXJ5IG5lcnZvdXMgYWJvdXQgdGhlIGlkZWEg b2YgcHV0dGluZyB0aGlzIHN0dWZmIGludG8gRFQuICBUaGlzIG1hdGNoZXMNCj4gbGVzcyBhbmQg bGVzcyB3ZWxsIHdpdGggbW9kZXJuIHN5c3RlbSBkZXNpZ25zIHdoaWNoIGFyZSBiZWNvbWluZyBt b3JlIGFuZA0KPiBtb3JlIGR5bmFtaWMsIGFuZCBvZiBjb3Vyc2UgdGhlIGNvbmNlcHRzIG9mIHN1 c3BlbmRpbmcgdG8gbWVtb3J5LCBkaXNrDQo+IGFuZCBzdGFuZGJ5IGFyZSB1bmNsZWFyIGFuZCBm bHVpZCAtIHdoYXQgaXMgdGhlIGRpZmZlcmVuY2UgYmV0d2VlbiBtZW1vcnkNCj4gYW5kIHN0YW5k YnkgZm9yIGV4YW1wbGU/DQo+IA0KPiBJJ2QgYmUgaW50ZXJlc3RlZCB0byBrbm93IGlmIHRoZXJl IGFyZSByZWFsIHN5c3RlbXMgdGhhdCBuZWVkIHRoaXMgYW5kIGNhbid0DQo+IGZpZ3VyZSBvdXQg d2hhdCB0byBkbyBkeW5hbWljYWxseS4NCg0KV2Ugb2Z0ZW4gdXNlIHN1c3BlbmQgdG8gbWVtb3J5 ICBpbiBvdXIgbW9iaWxlIGRvbWFpbiBhbmQgaXMgbXVjaCB1c2VmdWwuDQpTdXNwZW5kIHRvIGRp c2sgY291bGQgYmUgdXNlZnVsIGZvciBzcGVjaWFsIGNhc2VzIG9mIGhpYmVybmF0ZSBsaWtlIGRl YnVnZ2luZy4NCkNvdWxkbid0IGZpbmQgdGhlIHVzZSBvZiBzdGFuZGJ5IGNvbnN0cmFpbnQsIGJ1 dCBJIGFkZGVkIGluIGNvZGUgc28gYXMgdG8gcHJvdmlkZSBjb21wbGV0ZW5lc3MgdG8gdGhlIGZy YW1ld29yay4gDQoNClBsZWFzZSBsZXQgbWUga25vdyB5b3VyIGZlZWRiYWNrLg0KDQpSZWdhcmRz LA0KU2F1cmFiaCBTaW5naCBTZW5nYXINCkxlYWQgRW5naW5lZXINClNhbXN1bmcgUiZEIEluc3Rp dHV0ZQ0KSW5kaWENCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753020AbaAQPEQ (ORCPT ); Fri, 17 Jan 2014 10:04:16 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:54538 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752995AbaAQPEK (ORCPT ); Fri, 17 Jan 2014 10:04:10 -0500 X-AuditID: cbfee68f-b7f156d00000276c-45-52d94668bdd4 Date: Fri, 17 Jan 2014 15:04:08 +0000 (GMT) From: Saurabh Singh Subject: Re: [PATCH] Parse missing regulator constraints from device tree blob To: Mark Brown , rob.herring@kernel.org Cc: Mark Rutland , "lgirdwood@gmail.com" , "grant.likely@linaro.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "celinux-dev@tree.celinuxforum.org" , SREEVATSA D B , Praveen BP Reply-to: saurabh1.s@samsung.com MIME-version: 1.0 X-MTR: 20140117150211389@saurabh1.s Msgkey: 20140117150211389@saurabh1.s X-EPLocale: en_US.windows-1252 X-Priority: 3 X-EPWebmail-Msg-Type: personal X-EPWebmail-Reply-Demand: 0 X-EPApproval-Locale: X-EPHeader: ML X-EPTrCode: X-EPTrName: X-MLAttribute: X-RootMTR: 20140117150211389@saurabh1.s X-ParentMTR: X-ArchiveUser: X-CPGSPASS: N Content-type: text/plain; charset=windows-1252 MIME-version: 1.0 Message-id: <29524060.615241389971045531.JavaMail.weblogic@epml20> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupileLIzCtJLcpLzFFi42JZI2JSpZvhdjPIoK1HyOLyrjlsDowenzfJ BTBGcdmkpOZklqUW6dslcGXMuelf8EyyYs6ErAbGHskuRk4OIQFVidl7tjB2MXJwSAiYSLxe VwgSlhAQk7hwbz1bFyMXUMlSRok1PQ9YIBImEh/6DzJC9M5nlLhzPhyklwVozvItNSBhNgFd iYfr77KD2MICfhJ7Wj4ygdgiAi4S00+cZQKZySywmlmiYe4SNog5ChLnnneCFfEKCEqcnPkE apeyxOOGacwQcRWJ2+8WsULE5SSWTL3MBGHzSsxof8oCE5/2dQ0zhC0tcX7WBkaYZxZ/fwwV 55c4dnsHE8S/vBJP7gfDjNm9+QsbhC0gMfXMQahWDYm2NUugWvkk1ix8ywIzZtep5cwwvfe3 zAU7h1lAUWJK90N2CNtA4siiOayo3uIAsp0kFq/wnsCoPAtJZhaS7llIupHVLGBkWcUomlqQ XFCclF5krFecmFtcmpeul5yfu4kRmA5O/3vWv4Px7gHrQ4zJwBiZyCwlmpwPTCd5JfGGxmZG FqYmpsZG5pZmpAkrifPef5gUJCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoFRLcXw6f9qxm2+ 9jriHuenfcpReWJiuTNcYa3uXJlHCX81Prbd/5aqI+D0N9f0Wqa+w0H3g7x3/Nbe3vnuodJt hiKV3xpXlqUu2tZcJDHRvbJpiq7y553h1bN5lq3YvsnEZmbfXUPvF9VnuXetZbr6g01RUcHg Qt61ld0vlP5qW35ec27KbfdpSizFGYmGWsxFxYkAu7VdSx0DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDKsWRmVeSWpSXmKPExsVy+t/tGboZbjeDDDbO5rK4vGsOmwOjx+dN cgGMUWk2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUBD lRTKEnNKgUIBicXFSvp2NkX5pSWpChn5xSW2StGG5kZ6RgZ6pkZ6hqaxVoYGBkamQDUJaRlz bvoXPJOsmDMhq4GxR7KLkZNDSEBVYvaeLYwgtoSAicSH/oNQtpjEhXvr2SBq5jNK3Dkf3sXI wcECVL98Sw1ImE1AV+Lh+rvsILawgJ/EnpaPTCC2iICLxPQTZ4FsLg5mgdXMEg1zl0DNUZA4 97wTrIhXQFDi5MwnLBC7lCUeN0xjhoirSNx+t4gVIi4nsWTqZSYIm1diRvtTFpj4tK9rmCFs aYnzszbA3bz4+2OoOL/Esds7mEBuBul9cj8YZszuzV/YIGwBialnYN7VkGhbswSqlU9izcK3 LDBjdp1azgzTe3/LXLBzmAUUJaZ0P2SHsA0kjiyaw4rqLQ4g20li8QrvCYxys5BkZiHpnoWk G1nNAkaWVYyiqQXJBcVJ6RXGesWJucWleel6yfm5mxjBaenZ4h2M/89bH2IU4GBU4uGVEL8R JMSaWFZcmXuIUYKDWUmEd47BzSAh3pTEyqrUovz4otKc1OJDjMnA+JvILCWanA9MmXkl8YbG JuamxqYWBobm5makCSuJ88bfSgoSEkhPLEnNTk0tSC2C2cLEwSnVwBjwgzdw9cKC+lX2Xc8N 70VGiLtqGdZW677Qux6f5b1VKzAulOW57Xe+D4FbmsxjzB4fzb9w/PqkQ4cfL/jH68El3XDr tfC1z8qxdTmmD7M2G135U33R6LzTUd4PZlP8A4zcYne8ma7Lkm9rmdjtvriAT+98cnN6S5pw yo/suLjZrc7ei3RWKLEUZyQaajEXFScCADZj3TWPAwAA DLP-Filter: Pass X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s0HF5E1N025385 Hi Mark, > No, please do as I asked and follow the process in SubmittingPatches - as I > said the format things are sent in is very important for the tooling. Pasting > the patch into a mail after some other text definitely doesn't give a mail in > the format covered in SubmittingPatches. If in doubt send the mail to > yourself and then compare it with other patches sent to the list and test by > applying with git am and make sure the patch and changelog come out OK. Ok, I have created the patch with guidelines, which I will be sending in a separate mail Also, this time I have tested my patch it by "git am". > > +- regulator-valid-modes-mask: valid operations for regulator on > > +particular machine > > This is not adequately documented, what are "valid operations" and how > would they be encoded? Provide the information in documentation, and provide better abstraction so as to hide linux internals in device tree. > > +- regulator-input-uv: regulator input voltage, only if supply is > > +another regulator > > Why provide a property for this, surely if there is another regulator we can > just find out from that regulator what voltage it is outputting? Valid point! , removed from the code. > > +- regulator-initial-mode: default mode to set on startup > > It is not documented what a mode is here or how one would specify it in the > property. > > > +- regulator-initial-state: suspend state to set at init > > Again, no semantics are provided for this. Added documentation with example > I am very nervous about the idea of putting this stuff into DT. This matches > less and less well with modern system designs which are becoming more and > more dynamic, and of course the concepts of suspending to memory, disk > and standby are unclear and fluid - what is the difference between memory > and standby for example? > > I'd be interested to know if there are real systems that need this and can't > figure out what to do dynamically. We often use suspend to memory in our mobile domain and is much useful. Suspend to disk could be useful for special cases of hibernate like debugging. Couldn't find the use of standby constraint, but I added in code so as to provide completeness to the framework. Please let me know your feedback. Regards, Saurabh Singh Sengar Lead Engineer Samsung R&D Institute India {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I