Re: [PATCH] batctl: neighbor: Fix print neighbors table header

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]

On Sunday, 8 September 2024 21:47:27 CEST noahbpeterson1997@gmail.com wrote:
> > This is wrong, this is not what it outputs for the default B.A.T.M.A.N. IV:
> 
> Oops. I believe I now have this issue corrected. I copied the routing algorithm checking code from the netlink_print_gateways() function in gateways.c and change the header accordingly. Let me know if I should revert the change in README.rst.

Doesn't apply:

    patching file README.rst
    patching file neighbors.c
    Hunk #2 FAILED at 120.
    1 out of 2 hunks FAILED -- saving rejects to file neighbors.c.rej

And you need to resubmit it as proper patch in a separate thread with
"[PATCH v2]" (instead of "[PATCH]") at the start of the Subject.

> Let me know if I should revert the change in README.rst.

Yes, please revert it. And I don't want to read stuff like "The examples in 
the README.rst are updated too." - which is a rather obvious information.

And regarding "netlink_print_neighbors() now prints the correct header to 
match what batman-advanced currently outputs." The first part is trivial (but 
incorrect) and the last part doesn't make any sense. Please describe instead 
what the problem was and what the idea behind the fix is. And potential other 
information which might be helpful to understand the context for future 
persons stumbling over your change.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]