All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH 3/3] ethdev: improvements for some macro definition in head file
Date: Wed, 27 Aug 2014 17:42:02 +0200	[thread overview]
Message-ID: <2954869.Rz44bk6IQk@xps13> (raw)
In-Reply-To: <1405651521-14545-4-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

2014-07-18 10:45, Helin Zhang:
> improvements for some macro definition about RSS packet
> classification types in rte_ethdev.h.
[...]
> -#define ETH_RSS_IPV4                    ((uint16_t)1 << ETH_RSS_IPV4_SHIFT)
[...]
> +#define ETH_RSS_IPV4                    (1 << ETH_RSS_IPV4_SHIFT)

Please explain your change in the commit log.
In general, the log should answer to these questions:
	what was the problem?
	when the problem was introduced?
	why it's better now?

Thanks
-- 
Thomas

  parent reply	other threads:[~2014-08-27 15:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-18  2:45 [PATCH 0/3] add i40e RSS support in VF Helin Zhang
     [not found] ` <1405651521-14545-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-07-18  2:45   ` [PATCH 1/3] i40evf: add " Helin Zhang
2014-07-18  2:45   ` [PATCH 2/3] app/testpmd: enable RSS support for i40e Helin Zhang
     [not found]     ` <1405651521-14545-3-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-08-27 15:36       ` Thomas Monjalon
2014-07-18  2:45   ` [PATCH 3/3] ethdev: improvements for some macro definition in head file Helin Zhang
     [not found]     ` <1405651521-14545-4-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-08-27 15:42       ` Thomas Monjalon [this message]
2014-07-31  1:55   ` [PATCH 0/3] add i40e RSS support in VF Zhan, Zhaochen
2014-08-20  7:07   ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2954869.Rz44bk6IQk@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.