From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sun, 11 Jan 2015 02:37:30 +0100 (CET) Received: from relay5-d.mail.gandi.net ([217.70.183.197]:38603 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010460AbbAKBh2aFXeb (ORCPT ); Sun, 11 Jan 2015 02:37:28 +0100 Received: from mfilter26-d.gandi.net (mfilter26-d.gandi.net [217.70.178.154]) by relay5-d.mail.gandi.net (Postfix) with ESMTP id 2A47141C064; Sun, 11 Jan 2015 02:37:28 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter26-d.gandi.net Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by mfilter26-d.gandi.net (mfilter26-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id fxxlwCmrUkXg; Sun, 11 Jan 2015 02:37:26 +0100 (CET) X-Originating-IP: 88.159.34.112 Received: from starbug-2.treewalker.org (unknown [88.159.34.112]) (Authenticated sender: relay@treewalker.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id D261B41C05D; Sun, 11 Jan 2015 02:37:24 +0100 (CET) Received: from hyperion.localnet (hyperion.trinair2002 [192.168.0.43]) by starbug-2.treewalker.org (Postfix) with ESMTP id 5ED3850B98; Sun, 11 Jan 2015 02:37:24 +0100 (CET) From: Maarten ter Huurne To: Guenter Roeck Cc: Lars-Peter Clausen , Ralf Baechle , Wim Van Sebroeck , Paul Burton , Paul Cercueil , linux-mips@linux-mips.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 2/3] MIPS: qi_lb60: Register watchdog device Date: Sun, 11 Jan 2015 02:37:24 +0100 Message-ID: <2955853.HTsalEGzQa@hyperion> User-Agent: KMail/4.14.3 (Linux/3.11.10-25-desktop; KDE/4.14.3; x86_64; ; ) In-Reply-To: <54B1D0E5.3010904@roeck-us.net> References: <1420914550-18335-1-git-send-email-lars@metafoo.de> <1420914550-18335-2-git-send-email-lars@metafoo.de> <54B1D0E5.3010904@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 45059 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: maarten@treewalker.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Saturday 10 January 2015 17:24:53 Guenter Roeck wrote: > On 01/10/2015 10:29 AM, Lars-Peter Clausen wrote: > > The next commit will move the restart code to the watchdog driver. So > > for > > restart to continue to work we need to register the watchdog device. > > > > Also enable the watchdog driver in the default config. > > > > Signed-off-by: Lars-Peter Clausen > > --- > > > > arch/mips/configs/qi_lb60_defconfig | 2 ++ > > arch/mips/jz4740/board-qi_lb60.c | 1 + > > 2 files changed, 3 insertions(+) > > > > diff --git a/arch/mips/configs/qi_lb60_defconfig > > b/arch/mips/configs/qi_lb60_defconfig index 2b96547..ce06a92 100644 > > --- a/arch/mips/configs/qi_lb60_defconfig > > +++ b/arch/mips/configs/qi_lb60_defconfig > > @@ -73,6 +73,8 @@ CONFIG_POWER_SUPPLY=y > > > > CONFIG_BATTERY_JZ4740=y > > CONFIG_CHARGER_GPIO=y > > # CONFIG_HWMON is not set > > > > +CONFIG_WATCHDOG=y > > +CONFIG_JZ4740_WDT=y > > Shouldn't JZ4740_WDT be selected from MACH_JZ4740 ? > > Guess it doesn't really matter if there is just one board, but if there > is ever another board the reset handler would not automatically be > enabled. There is only one board in the mainline kernel, but Paul Cercueil and me did maintain a kernel for the Dingoo A320 for a while which is also JZ4740- based. Also, a lot of the JZ4740 drivers can be used as-is or with small adaptations on later SoC generations. For example, we're using a slightly modified version of this watchdog driver on the JZ4770-based GCW Zero. Bye, Maarten