Re: [PATCH v2 1/2] common/mlx5: fix build disabling

[Thomas Monjalon <thomas@monjalon.net>]

02/11/2022 14:14, Bruce Richardson:
> On Wed, Nov 02, 2022 at 01:29:49PM +0100, Thomas Monjalon wrote:
> > 02/11/2022 13:10, Bruce Richardson:
> > > On Sun, Oct 30, 2022 at 09:27:21AM +0100, Thomas Monjalon wrote:
> > > > +if not ('mlx5' in common_drivers)
> > > 
> > > While this is fine as-is, I think the more usual way for checking the
> > > presence of a component in DPDK is to check dpdk_conf. In this case the
> > > check would be "if not dpdk_conf.has('RTE_COMMON_MLX5')". You may want to
> > > consider using that for consistency.
> > 
> > Yes, I've forgotten this:
> > 
> > 	lib_name = '_'.join(['rte', class, name])
> > 	dpdk_conf.set(lib_name.to_upper(), 1)
> > 
> > Then what is the usage of this?
> > 
> > 	set_variable(class + '_drivers', enabled_drivers)
> > 
> That is used for the summary printout at the end, so we can list the
> drivers enabled.
> 
> The approach using the common_drivers works fine for this patch, so let's
> keep it, since it's merged. I was just pointing out the other approach for
> consistency sake.

I can send a patch for consistency.