From: Thomas Monjalon <thomas@monjalon.net>
To: Diogo Behrens <diogo.behrens@huawei.com>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>,
dev@dpdk.org, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH] librte_eal: fix mcslock hang on weak memory
Date: Wed, 25 Nov 2020 15:16:59 +0100 [thread overview]
Message-ID: <2959194.bmkqA6hyfk@thomas> (raw)
In-Reply-To: <DBAPR08MB581416E1D0835A1BBCAB042998FC0@DBAPR08MB5814.eurprd08.prod.outlook.com>
> > The initialization me->locked=1 in lock() must happen before
> > next->locked=0 in unlock(), otherwise a thread may hang forever,
> > waiting me->locked become 0. On weak memory systems (such as ARMv8),
> > the current implementation allows me->locked=1 to be reordered with
> > announcing the node (pred->next=me) and, consequently, to be
> > reordered with next->locked=0 in unlock().
> >
> > This fix adds a release barrier to pred->next=me, forcing
> > me->locked=1 to happen before this operation.
> >
> > Signed-off-by: Diogo Behrens <diogo.behrens@huawei.com>
> The change looks fine to me. I have tested this on few x86 and Arm machines.
> Acked-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Applied, thanks
prev parent reply other threads:[~2020-11-25 14:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 9:20 [dpdk-dev] [PATCH] librte_eal: fix mcslock hang on weak memory Diogo Behrens
2020-08-26 10:17 ` Phil Yang
2020-08-27 8:56 ` Diogo Behrens
2020-08-28 9:19 ` Phil Yang
2020-08-31 18:45 ` Honnappa Nagarahalli
2020-10-06 21:49 ` Thomas Monjalon
2020-10-07 9:55 ` Diogo Behrens
2020-10-20 11:56 ` Thomas Monjalon
2020-10-20 21:49 ` Honnappa Nagarahalli
2020-11-22 18:07 ` Thomas Monjalon
2020-11-23 15:06 ` Honnappa Nagarahalli
2020-11-23 15:44 ` Stephen Hemminger
2020-11-23 18:16 ` Honnappa Nagarahalli
2020-11-23 18:29 ` Honnappa Nagarahalli
2020-11-23 19:36 ` Stephen Hemminger
2020-11-25 4:50 ` Honnappa Nagarahalli
2020-11-25 8:41 ` Diogo Behrens
2020-11-25 14:16 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2959194.bmkqA6hyfk@thomas \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=diogo.behrens@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.