From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 05/12] drm: shmob_drm: Convert to clk_prepare/unprepare
Date: Sat, 09 Nov 2013 13:51:04 +0100
Message-ID: <2959885.VdyEnllx0c@avalon>
References: <1383000569-8916-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
	<1383000569-8916-6-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
	[95.142.166.194])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5B11310D626
	for <dri-devel@lists.freedesktop.org>;
	Sat,  9 Nov 2013 04:50:33 -0800 (PST)
In-Reply-To: <1383000569-8916-6-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi Dave,

Could you please pick this patch up ?

On Monday 28 October 2013 23:49:22 Laurent Pinchart wrote:
> Turn clk_enable() and clk_disable() calls into clk_prepare_enable() and
> clk_disable_unprepare() to get ready for the migration to the common
> clock framework.
> 
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c index 54bad98..562f9a4 100644
> --- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> +++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> @@ -40,7 +40,7 @@
>  static void shmob_drm_clk_on(struct shmob_drm_device *sdev)
>  {
>  	if (sdev->clock)
> -		clk_enable(sdev->clock);
> +		clk_prepare_enable(sdev->clock);
>  #if 0
>  	if (sdev->meram_dev && sdev->meram_dev->pdev)
>  		pm_runtime_get_sync(&sdev->meram_dev->pdev->dev);
> @@ -54,7 +54,7 @@ static void shmob_drm_clk_off(struct shmob_drm_device
> *sdev) pm_runtime_put_sync(&sdev->meram_dev->pdev->dev);
>  #endif
>  	if (sdev->clock)
> -		clk_disable(sdev->clock);
> +		clk_disable_unprepare(sdev->clock);
>  }
> 
>  /*
> ---------------------------------------------------------------------------
-- 
Regards,

Laurent Pinchart