From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28FE21BF58 for ; Mon, 6 Jan 2025 08:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736153705; cv=none; b=rFQZcxemB6+nvcPU8Jvcutwb3fUJ61XO1lTQi8P4E51/FJfzsN7/9/RzRoXqcXRPQMCHxZrCB0xdzqlnV1AIRo6JzV7VQy+uDP16d9n8O2nN0eSOZZd2nJvJ03Vsiown4QauZWMiTMDqLQB9W64+rwNc3xnbPx1Rd7Vh/n+NIDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736153705; c=relaxed/simple; bh=+FmKRr6rArUyvZW6PWGEhxChseGXU7XHHU0ZCn1L3ZA=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=uxAzQvwX1JDKac0qtrlAuYt1Bp9NFRn68ux1v2lyBnOIJlZJNkPmKeJGwopf7Ef6BZr4Uc/bKAg/FLH18BDDFn37Mn5YqzYon54XRBgRmBzKPGfLrbN0IMr+Oe3fAhpDzofWi28l0rykRSklwC8ytjAt1fQH1Nm+H3ETsngwb2o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sF3TRdcu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sF3TRdcu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7790C4CED2; Mon, 6 Jan 2025 08:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736153704; bh=+FmKRr6rArUyvZW6PWGEhxChseGXU7XHHU0ZCn1L3ZA=; h=Subject:From:To:Date:In-Reply-To:References:From; b=sF3TRdcut4BtEh+Y1k6itvFOWUIAwCObSoyM/Qjgqhedegp/VY4aQc14lhnuJxJH3 8Tf8Cj+49qbPSHJRNBlZnKK/my+wMHKcCc7ElPbK5jPy9ct90ZSjSYnfyhYZtpe/ki x2/N5y/5amtQmUKzsYjehWHJE+nw+sIrwbBaYrrUvaAdBYmpksoirzvbi4h9gA/hKb UPcjSypry4g/GW44S4U6032Bh+fS6s5OQ2KAkQcKdchdo4fO8mGczSPtmo3CGu6FP6 uSIUQqUSWigeqH2KsDuE2KYm2NGVN3czM2VAp8seI465XnIBHiyS+Ecwht2dJCOoMz 2Y+2Sw2GiMbVg== Message-ID: <296441f6258e6f112dfca28e6f21a815d9cab598.camel@kernel.org> Subject: Re: [PATCH mptcp-next v6 3/7] mptcp: pm: improve error messages From: Geliang Tang To: Matthieu Baerts , mptcp@lists.linux.dev Date: Mon, 06 Jan 2025 16:55:01 +0800 In-Reply-To: <239060ce-34fe-435a-88f4-9e171d7ee0ad@kernel.org> References: <20241230-genl_req_attr_check-v6-0-3ec9103559e7@kernel.org> <20241230-genl_req_attr_check-v6-3-3ec9103559e7@kernel.org> <239060ce-34fe-435a-88f4-9e171d7ee0ad@kernel.org> Autocrypt: addr=geliang@kernel.org; prefer-encrypt=mutual; keydata=mQINBGWKTg4BEAC/Subk93zbjSYPahLCGMgjylhY/s/R2ebALGJFp13MPZ9qWlbVC8O+X lU/4reZtYKQ715MWe5CwJGPyTACILENuXY0FyVyjp/jl2u6XYnpuhw1ugHMLNJ5vbuwkc1I29nNe8 wwjyafN5RQV0AXhKdvofSIryqm0GIHIH/+4bTSh5aB6mvsrjUusB5MnNYU4oDv2L8MBJStqPAQRLl P9BWcKKA7T9SrlgAr0VsFLIOkKOQPVTCnYxn7gfKogH52nkPAFqNofVB6AVWBpr0RTY7OnXRBMInM HcjVG4I/NFn8Cc7oaGaWHqX/yHAufJKUsldieQVFd7C/SI8jCUXdkZxR0Tkp0EUzkRc/TS1VwWHav 0x3oLSy/LGHfRaIC/MqdGVqgCnm6wapUt7f/JHloyIyKJBGBuHCLMpN6n/kNkSCzyZKV7h6Vw1OL5 18p0U3Optyakoh95KiJsKzcd3At/eftQGlNn5WDflHV1+oMdW2sRgfVDPrYeEcYI5IkTc3LRO6ucp VCm9/+poZSHSXMI/oJ6iXMJE8k3/aQz+EEjvc2z0p9aASJPzx0XTTC4lciTvGj62z62rGUlmEIvU2 3wWH37K2EBNoq+4Y0AZsSvMzM+CcTo25hgPaju1/A8ErZsLhP7IyFT17ARj/Et0G46JRsbdlVJ/Pv X+XIOc2mpqx/QARAQABtCVHZWxpYW5nIFRhbmcgPGdlbGlhbmcudGFuZ0BsaW51eC5kZXY+iQJUBB MBCgA+FiEEZiKd+VhdGdcosBcafnvtNTGKqCkFAmWKTg4CGwMFCRLMAwAFCwkIBwIGFQoJCAsCBBY CAwECHgECF4AACgkQfnvtNTGKqCmS+A/9Fec0xGLcrHlpCooiCnNH0RsXOVPsXRp2xQiaOV4vMsvh G5AHaQLb3v0cUr5JpfzMzNpEkaBQ/Y8Oj5hFOORhTyCZD8tY1aROs8WvbxqvbGXHnyVwqy7AdWelP +0lC0DZW0kPQLeel8XvLnm9Wm3syZgRGxiM/J7PqVcjujUb6SlwfcE3b2opvsHW9AkBNK7v8wGIcm BA3pS1O0/anP/xD5s5L7LIMADVB9MqQdeLdFU+FFdafmKSmcP9A2qKHAvPBUuQo3xoBOZR3DMqXIP kNCBfQGkAx5tm1XYli1u3r5tp5QCRbY5LSkntMNJJh0eWLU8I+zF6NWhqNhHYRD3zc1tiXlG5E0ob pX02Dy25SE2zB3abCRdAK30nCI4lMyMCcyaeFqvf6uhiugLiuEPRRRdJDWICOLw6KOFmxWmue1F71 k08nj5PQMWQUX3X2K6jiOuoodYwnie/9NsH3DBHIVzVPWASFd6JkZ21i9Ng4ie+iQAveRTCeCCF6V RORJR0R8d7mI9+1eqhNeKzs21gQPVf/KBEIpwPFDjOdTwS/AEQQyhB+5ALeYpNgfKl2p30C20VRfJ GBaTc4ReUXh9xbUx5OliV69iq9nIVIyculTUsbrZX81Gz6UlbuSzWc4JclWtXf8/QcOK31wputde7 Fl1BTSR4eWJcbE5Iz2yzgQu0IUdlbGlhbmcgVGFuZyA8Z2VsaWFuZ0BrZXJuZWwub3JnPokCVAQTA QoAPhYhBGYinflYXRnXKLAXGn577TUxiqgpBQJlqclXAhsDBQkSzAMABQsJCAcCBhUKCQgLAgQWAg MBAh4BAheAAAoJEH577TUxiqgpaGkP/3+VDnbu3HhZvQJYw9a5Ob/+z7WfX4lCMjUvVz6AAiM2atD yyUoDIv0fkDDUKvqoU9BLU93oiPjVzaR48a1/LZ+RBE2mzPhZF201267XLMFBylb4dyQZxqbAsEhV c9VdjXd4pHYiRTSAUqKqyamh/geIIpJz/cCcDLvX4sM/Zjwt/iQdvCJ2eBzunMfouzryFwLGcOXzx OwZRMOBgVuXrjGVB52kYu1+K90DtclewEgvzWmS9d057CJztJZMXzvHfFAQMgJC7DX4paYt49pNvh cqLKMGNLPsX06OR4G+4ai0JTTzIlwVJXuo+uZRFQyuOaSmlSjEsiQ/WsGdhILldV35RiFKe/ojQNd 4B4zREBe3xT+Sf5keyAmO/TG14tIOCoGJarkGImGgYltTTTM6rIk/wwo9FWshgKAmQyEEiSzHTSnX cGbalD3Do89YRmdG+5eP7HQfsG+VWdn8IH6qgIvSt8GOw6RfSP7omMXvXji1VrbWG4LOFYcsKTN+d GDhl8LmU0y44HejkCzYj/b28MvNTiRVfucrmZMGgI8L5A4ZwQ3Inv7jY13GZSvTb7PQIbqMcb1P3S qWJFodSwBg9oSw21b+T3aYG3z3MRCDXDlZAJONELx32rPMdBva8k+8L+K8gc7uNVH4jkMPkP9jPnV Px+2P2cKc7LXXedb/qQ3M Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.54.0-1 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Happy New Year Matt! On Mon, 2025-01-06 at 09:45 +0100, Matthieu Baerts wrote: > Hi Geliang, > > On 06/01/2025 09:41, Geliang Tang wrote: > > On Mon, 2024-12-30 at 14:24 +0100, Matthieu Baerts (NGI0) wrote: > > > Some error messages were: > > > > > >  - too generic: "missing input", "invalid request" > > > > > >  - not precise enough: "limit greater than maximum" but what's > > > the > > > max? > > > > > >  - missing: subflow not found, or connect error. > > > > > > This can be easily improved by being more precise, or adding new > > > error > > > messages. > > (...) > > > > diff --git a/net/mptcp/pm_userspace.c b/net/mptcp/pm_userspace.c > > > index > > > 9c0bec588c498e0aa78acf4018db509abe90cad2..a8f73b082460ba00f7fa998 > > > cf76 > > > 46368f8201e2e 100644 > > > --- a/net/mptcp/pm_userspace.c > > > +++ b/net/mptcp/pm_userspace.c > > (...) > > > > @@ -634,6 +638,9 @@ int mptcp_userspace_pm_set_flags(struct > > > sk_buff > > > *skb, struct genl_info *info) > > >   ret = mptcp_pm_nl_mp_prio_send_ack(msk, &loc.addr, > > > &rem.addr, bkup); > > >   release_sock(sk); > > >   > > > + if (ret) > > > + GENL_SET_ERR_MSG(info, "subflow not found"); > > > > I guess you don't want to use "subflow not found" here. I changed > > it as > > "mp_prio send ack failed" in v7. > > No, I wanted to use "subflow not found": > mptcp_pm_nl_mp_prio_send_ack() > will fail only if it cannot find the subflow matching the local and > remote attributes. My bad, how about using "subflow not found in set_flags" here, and use "subflow not found in subflow_destroy" for mptcp_pm_nl_subflow_destroy_doit? > > Cheers, > Matt