From: David Howells <dhowells@redhat.com>
To: "Andrew G. Morgan" <morgan@kernel.org>
Cc: dhowells@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
"Serge E. Hallyn" <serue@us.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
Linux Security Modules List
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH 1/4] security: filesystem capabilities bugfix1
Date: Mon, 30 Jun 2008 14:15:11 +0100 [thread overview]
Message-ID: <29651.1214831711@redhat.com> (raw)
In-Reply-To: <48635799.3010500@kernel.org>
Andrew G. Morgan <morgan@kernel.org> wrote:
> +kernel_cap_t cap_set_effective(const kernel_cap_t pE_new)
Hmmm... kernel_cap_t is a structure that might not fit into a single register.
It occurs to me that you might be better off returing the old caps through a
pointer argument. It should still work, though.
The SElinux and syscalls LTP testscripts work okay for these patches when
ported to linux-next. The filecaps LTP testscript can't be used on Fedora 9
as the setcap command is used incorrectly.
Acked-by: David Howells <dhowells@redhat.com>
David
next prev parent reply other threads:[~2008-06-30 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 8:47 [PATCH 1/4] security: filesystem capabilities bugfix1 Andrew G. Morgan
2008-06-27 20:52 ` Serge E. Hallyn
2008-06-30 13:15 ` David Howells [this message]
2008-06-30 13:30 ` David Howells
2008-07-01 21:49 ` Andrew Morton
2008-07-01 22:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29651.1214831711@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=morgan@kernel.org \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.