From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-media@vger.kernel.org, hans.verkuil@cisco.com,
m.chehab@samsung.com
Subject: Re: [PATCH 2/6] [media] mt9p031: Include linux/of.h header
Date: Wed, 06 Nov 2013 02:28:50 +0100 [thread overview]
Message-ID: <2965670.TUVZegLOBr@avalon> (raw)
In-Reply-To: <1382065635-27855-2-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
Thank you for the patch, and sorry for the late reply.
On Friday 18 October 2013 08:37:11 Sachin Kamat wrote:
> 'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid
> build breakage in the future.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I've taken the patch in my tree and will push it upstream.
> ---
> drivers/media/i2c/mt9p031.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
> index 4734836..1c2303d 100644
> --- a/drivers/media/i2c/mt9p031.c
> +++ b/drivers/media/i2c/mt9p031.c
> @@ -19,6 +19,7 @@
> #include <linux/i2c.h>
> #include <linux/log2.h>
> #include <linux/module.h>
> +#include <linux/of.h>
> #include <linux/of_gpio.h>
> #include <linux/pm.h>
> #include <linux/regulator/consumer.h>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-11-06 1:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-18 3:07 [PATCH 1/6] [media] adv7343: Include linux/of.h header Sachin Kamat
2013-10-18 3:07 ` [PATCH 2/6] [media] mt9p031: " Sachin Kamat
2013-11-06 1:28 ` Laurent Pinchart [this message]
2013-11-06 10:10 ` Sachin Kamat
2013-10-18 3:07 ` [PATCH 3/6] [media] ths8200: " Sachin Kamat
2013-10-18 3:58 ` Prabhakar Lad
2013-10-18 3:07 ` [PATCH 4/6] [media] tvp514x: " Sachin Kamat
2013-10-18 3:57 ` Prabhakar Lad
2013-10-18 3:07 ` [PATCH 5/6] [media] tvp7002: " Sachin Kamat
2013-10-18 3:56 ` Prabhakar Lad
2013-10-18 3:07 ` [PATCH 6/6] [media] gpio-ir-recv: " Sachin Kamat
2013-10-18 3:55 ` [PATCH 1/6] [media] adv7343: " Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2965670.TUVZegLOBr@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.