From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Thu, 14 Dec 2017 21:05:27 +0200 Subject: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier In-Reply-To: <1513277679.27409.83.camel@perches.com> References: <20171208123537.18718-1-dhaval23031987@gmail.com> <16301043.Lbu0ahMgBI@avalon> <1513277679.27409.83.camel@perches.com> Message-ID: <2967655.MWOA0IsQOS@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Joe, (CC'ing Greg and adding context for easier understanding) On Thursday, 14 December 2017 20:54:39 EET Joe Perches wrote: > On Thu, 2017-12-14 at 20:37 +0200, Laurent Pinchart wrote: > > On Thursday, 14 December 2017 20:32:20 EET Joe Perches wrote: > >> On Thu, 2017-12-14 at 20:28 +0200, Laurent Pinchart wrote: > >>> On Thursday, 14 December 2017 19:05:27 EET Mauro Carvalho Chehab wrote: > >>>> Em Fri, 8 Dec 2017 18:05:37 +0530 Dhaval Shah escreveu: > >>>>> SPDX-License-Identifier is used for the Xilinx Video IP and > >>>>> related drivers. > >>>>> > >>>>> Signed-off-by: Dhaval Shah > >>>> > >>>> Hi Dhaval, > >>>> > >>>> You're not listed as one of the Xilinx driver maintainers. I'm afraid > >>>> that, without their explicit acks, sent to the ML, I can't accept a > >>>> patch touching at the driver's license tags. > >>> > >>> The patch doesn't change the license, I don't see why it would cause > >>> any issue. Greg isn't listed as the maintainer or copyright holder of > >>> any of the 10k+ files to which he added an SPDX license header in the > >>> last kernel release. > >> > >> Adding a comment line that describes an implicit or > >> explicit license is different than removing the license > >> text itself. > > > > The SPDX license header is meant to be equivalent to the license text. > > I understand that. > At a minimum, removing BSD license text is undesirable > as that license states: > > * * Redistributions of source code must retain the above copyright > * notice, this list of conditions and the following disclaimer. > etc... But this patch only removes the following text: - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License version 2 as - * published by the Free Software Foundation. and replaces it by the corresponding SPDX header. > > The only reason why the large SPDX patch didn't touch the whole kernel in > > one go was that it was easier to split in in multiple chunks. > > Not really, it was scripted. But still manually reviewed as far as I know. > > This is no different than not including the full GPL license in every > > header file but only pointing to it through its name and reference, as > > every kernel source file does. > > Not every kernel source file had a license text > or a reference to another license file. Correct, but the files touched by this patch do. This issue is in no way specific to linux-media and should be decided upon at the top level, not on a per-subsystem basis. Greg, could you comment on this ? -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:50517 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753703AbdLNTFW (ORCPT ); Thu, 14 Dec 2017 14:05:22 -0500 From: Laurent Pinchart To: Joe Perches Cc: Mauro Carvalho Chehab , Dhaval Shah , hyun.kwon@xilinx.com, michal.simek@xilinx.com, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH] media: v4l: xilinx: Use SPDX-License-Identifier Date: Thu, 14 Dec 2017 21:05:27 +0200 Message-ID: <2967655.MWOA0IsQOS@avalon> In-Reply-To: <1513277679.27409.83.camel@perches.com> References: <20171208123537.18718-1-dhaval23031987@gmail.com> <16301043.Lbu0ahMgBI@avalon> <1513277679.27409.83.camel@perches.com> MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="iso-8859-1" Sender: linux-media-owner@vger.kernel.org List-ID: SGkgSm9lLAoKKENDJ2luZyBHcmVnIGFuZCBhZGRpbmcgY29udGV4dCBmb3IgZWFzaWVyIHVuZGVy c3RhbmRpbmcpCgpPbiBUaHVyc2RheSwgMTQgRGVjZW1iZXIgMjAxNyAyMDo1NDozOSBFRVQgSm9l IFBlcmNoZXMgd3JvdGU6Cj4gT24gVGh1LCAyMDE3LTEyLTE0IGF0IDIwOjM3ICswMjAwLCBMYXVy ZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4gT24gVGh1cnNkYXksIDE0IERlY2VtYmVyIDIwMTcgMjA6 MzI6MjAgRUVUIEpvZSBQZXJjaGVzIHdyb3RlOgo+ID4+IE9uIFRodSwgMjAxNy0xMi0xNCBhdCAy MDoyOCArMDIwMCwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+Pj4gT24gVGh1cnNkYXksIDE0 IERlY2VtYmVyIDIwMTcgMTk6MDU6MjcgRUVUIE1hdXJvIENhcnZhbGhvIENoZWhhYiB3cm90ZToK PiA+Pj4+IEVtIEZyaSwgIDggRGVjIDIwMTcgMTg6MDU6MzcgKzA1MzAgRGhhdmFsIFNoYWggZXNj cmV2ZXU6Cj4gPj4+Pj4gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXIgaXMgdXNlZCBmb3IgdGhlIFhp bGlueCBWaWRlbyBJUCBhbmQKPiA+Pj4+PiByZWxhdGVkIGRyaXZlcnMuCj4gPj4+Pj4gCj4gPj4+ Pj4gU2lnbmVkLW9mZi1ieTogRGhhdmFsIFNoYWggPGRoYXZhbDIzMDMxOTg3QGdtYWlsLmNvbT4K PiA+Pj4+IAo+ID4+Pj4gSGkgRGhhdmFsLAo+ID4+Pj4gCj4gPj4+PiBZb3UncmUgbm90IGxpc3Rl ZCBhcyBvbmUgb2YgdGhlIFhpbGlueCBkcml2ZXIgbWFpbnRhaW5lcnMuIEknbSBhZnJhaWQKPiA+ Pj4+IHRoYXQsIHdpdGhvdXQgdGhlaXIgZXhwbGljaXQgYWNrcywgc2VudCB0byB0aGUgTUwsIEkg Y2FuJ3QgYWNjZXB0IGEKPiA+Pj4+IHBhdGNoIHRvdWNoaW5nIGF0IHRoZSBkcml2ZXIncyBsaWNl bnNlIHRhZ3MuCj4gPj4+IAo+ID4+PiBUaGUgcGF0Y2ggZG9lc24ndCBjaGFuZ2UgdGhlIGxpY2Vu c2UsIEkgZG9uJ3Qgc2VlIHdoeSBpdCB3b3VsZCBjYXVzZQo+ID4+PiBhbnkgaXNzdWUuIEdyZWcg aXNuJ3QgbGlzdGVkIGFzIHRoZSBtYWludGFpbmVyIG9yIGNvcHlyaWdodCBob2xkZXIgb2YKPiA+ Pj4gYW55IG9mIHRoZSAxMGsrIGZpbGVzIHRvIHdoaWNoIGhlIGFkZGVkIGFuIFNQRFggbGljZW5z ZSBoZWFkZXIgaW4gdGhlCj4gPj4+IGxhc3Qga2VybmVsIHJlbGVhc2UuAAAACj4gPj4gCj4gPj4g QWRkaW5nIGEgY29tbWVudCBsaW5lIHRoYXQgZGVzY3JpYmVzIGFuIGltcGxpY2l0IG9yCj4gPj4g ZXhwbGljaXQgbGljZW5zZSBpcyBkaWZmZXJlbnQgdGhhbiByZW1vdmluZyB0aGUgbGljZW5zZQo+ ID4+IHRleHQgaXRzZWxmLgo+ID4gCj4gPiBUaGUgU1BEWCBsaWNlbnNlIGhlYWRlciBpcyBtZWFu dCB0byBiZSBlcXVpdmFsZW50IHRvIHRoZSBsaWNlbnNlIHRleHQuCj4gCj4gSSB1bmRlcnN0YW5k IHRoYXQuCj4gQXQgYSBtaW5pbXVtLCByZW1vdmluZyBCU0QgbGljZW5zZSB0ZXh0IGlzIHVuZGVz aXJhYmxlCj4gYXMgdGhhdCBsaWNlbnNlIHN0YXRlczoKPiAKPiAgKiAgICAqIFJlZGlzdHJpYnV0 aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Cj4gICog ICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRp c2NsYWltZXIuCj4gZXRjLi4uCgpCdXQgdGhpcyBwYXRjaCBvbmx5IHJlbW92ZXMgdGhlIGZvbGxv d2luZyB0ZXh0OgoKLSAqIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJl ZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5Ci0gKiBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhl IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIHZlcnNpb24gMiBhcwotICogcHVibGlzaGVkIGJ5 IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24uCgphbmQgcmVwbGFjZXMgaXQgYnkgdGhlIGNv cnJlc3BvbmRpbmcgU1BEWCBoZWFkZXIuCgo+ID4gVGhlIG9ubHkgcmVhc29uIHdoeSB0aGUgbGFy Z2UgU1BEWCBwYXRjaCBkaWRuJ3QgdG91Y2ggdGhlIHdob2xlIGtlcm5lbCBpbgo+ID4gb25lIGdv IHdhcyB0aGF0IGl0IHdhcyBlYXNpZXIgdG8gc3BsaXQgaW4gaW4gbXVsdGlwbGUgY2h1bmtzLgo+ IAo+IE5vdCByZWFsbHksIGl0IHdhcyBzY3JpcHRlZC4KCkJ1dCBzdGlsbCBtYW51YWxseSByZXZp ZXdlZCBhcyBmYXIgYXMgSSBrbm93LgoKPiA+IFRoaXMgaXMgbm8gZGlmZmVyZW50IHRoYW4gbm90 IGluY2x1ZGluZyB0aGUgZnVsbCBHUEwgbGljZW5zZSBpbiBldmVyeQo+ID4gaGVhZGVyIGZpbGUg YnV0IG9ubHkgcG9pbnRpbmcgdG8gaXQgdGhyb3VnaCBpdHMgbmFtZSBhbmQgcmVmZXJlbmNlLCBh cwo+ID4gZXZlcnkga2VybmVsIHNvdXJjZSBmaWxlIGRvZXMuCj4gCj4gTm90IGV2ZXJ5IGtlcm5l bCBzb3VyY2UgZmlsZSBoYWQgYSBsaWNlbnNlIHRleHQKPiBvciBhIHJlZmVyZW5jZSB0byBhbm90 aGVyIGxpY2Vuc2UgZmlsZS4KCkNvcnJlY3QsIGJ1dCB0aGUgZmlsZXMgdG91Y2hlZCBieSB0aGlz IHBhdGNoIGRvLgoKVGhpcyBpc3N1ZSBpcyBpbiBubyB3YXkgc3BlY2lmaWMgdG8gbGludXgtbWVk aWEgYW5kIHNob3VsZCBiZSBkZWNpZGVkIHVwb24gYXQgCnRoZSB0b3AgbGV2ZWwsIG5vdCBvbiBh IHBlci1zdWJzeXN0ZW0gYmFzaXMuIEdyZWcsIGNvdWxkIHlvdSBjb21tZW50IG9uIHRoaXMgPwoK LS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0Cg==