include/linux/security.h: In function ‘security_ptrace_traceme’: error: ‘parent’ undeclared

include/linux/security.h: In function ‘security_ptrace_traceme’: error: ‘parent’ undeclared

[Vegard Nossum]

Hi,

Is this known and/or fixed?

commit b09c3e3f1710b554348c98e78fbf4a661918779a:

In file included from arch/x86/kernel/ptrace.c:19:
include/linux/security.h: In function 'security_ptrace_traceme':
include/linux/security.h:1760: error: 'parent' undeclared (first use
in this function)
include/linux/security.h:1760: error: (Each undeclared identifier is
reported only once
include/linux/security.h:1760: error: for each function it appears in.)

Was introduced by:

commit 5cd9c58fbe9ec92b45b27e131719af4f2bd9eb40
Author: David Howells <dhowells@redhat.com>
Date:   Thu Aug 14 11:37:28 2008 +0100

    security: Fix setting of PF_SUPERPRIV by __capable()

+static inline int security_ptrace_traceme(struct task_struct *child)
 {
-       return cap_ptrace(parent, child, mode);
+       return cap_ptrace_traceme(parent);
 }


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036

[PATCH] security: fix build breakage

[Vegard Nossum]

In case it wasn't fixed already, here it is.. :-)

>From 122c9e0c51d43675a1d02b8a82d7eae8e87f9042 Mon Sep 17 00:00:00 2001
From: Vegard Nossum <vegardno@ben.ifi.uio.no>
Date: Mon, 18 Aug 2008 20:47:03 +0200
Subject: [PATCH] security: fix build breakage

Introduced by:

commit 5cd9c58fbe9ec92b45b27e131719af4f2bd9eb40
Author: David Howells <dhowells@redhat.com>
Date:   Thu Aug 14 11:37:28 2008 +0100

   security: Fix setting of PF_SUPERPRIV by __capable()

Should this commit be re-tested also with LTP with CONFIG_SECURITY=n?

Cc: David Howells <dhowells@redhat.com>
Cc: James Morris <jmorris@namei.org>
Signed-off-by: Vegard Nossum <vegardno@ben.ifi.uio.no>
---
 include/linux/security.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/linux/security.h b/include/linux/security.h
index 2ee5ecf..80c4d00 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -1755,7 +1755,7 @@ static inline int security_ptrace_may_access(struct task_struct *child,
 	return cap_ptrace_may_access(child, mode);
 }
 
-static inline int security_ptrace_traceme(struct task_struct *child)
+static inline int security_ptrace_traceme(struct task_struct *parent)
 {
 	return cap_ptrace_traceme(parent);
 }
-- 
1.5.6.4

Re: include/linux/security.h: In function ‘security_ptrace_traceme’: error: ‘parent’ undeclared

[David Howells]

Vegard Nossum <vegard.nossum@gmail.com> wrote:

> Is this known and/or fixed?

The fix is upstream now.

David