All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Vivek Kumbhar" <vkumbhar@mvista.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH][kirkstone] openssl: fix crash on aarch64 if BTI is enabled but no Crypto instructions
Date: Thu, 28 Mar 2024 20:51:05 -0700	[thread overview]
Message-ID: <29693.1711684265473117694@lists.openembedded.org> (raw)
In-Reply-To: <20240327111523.855715-1-ross.burton@arm.com>


[-- Attachment #1.1: Type: text/plain, Size: 2247 bytes --]

*Kirkstone-nut openssl compile error:*

*Error Log* :

ERROR: openssl-3.0.13-r0 do_patch: Applying patch 'bti.patch' on target directory '/home/vkumbhar/kirkstone-nut/ build/tmp-glibc/work/core2-64- oe-linux/openssl/3.0.13-r0/ openssl-3.0.13'
CmdError('quilt --quiltrc /home/vkumbhar/kirkstone-nut/ build/tmp-glibc/work/core2-64- oe-linux/openssl/3.0.13-r0/ recipe-sysroot-native/etc/ quiltrc push', 0, "stdout: Applying patch bti.patch
can't find file to patch at input line 23
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|From ba8a599395f8b770c76316b5f5b0f3 838567014f Mon Sep 17 00:00:00 2001
|From: Tom Cosgrove < tom.cosgrove@arm.com >
|Date: Tue, 26 Mar 2024 13:18:00 +0000
|Subject: [PATCH] aarch64: fix BTI in bsaes assembly code
|
|In Arm systems where BTI is enabled but the Crypto extensions are not (more
|likely in FVPs than in real hardware), the bit-sliced assembler code will
|be used. However, this wasn't annotated with BTI instructions when BTI was
|enabled, so the moment libssl jumps into this code it (correctly) aborts.
|
|Solve this by adding the missing BTI landing pads.
|
|Upstream-Status: Submitted [ https://github.com/openssl/ openssl/pull/23982 ( https://github.com/openssl/openssl/pull/23982 ) ]
|Signed-off-by: Ross Burton < ross.burton@arm.com >
|---
| crypto/aes/asm/ bsaes-armv8.pl ( http://bsaes-armv8.pl/ ) | 5 ++++-
| 1 file changed, 4 insertions(+), 1 deletion(-)
|
|diff --git a/crypto/aes/asm/ bsaes-armv8. pl ( http://bsaes-armv8.pl/ ) b/crypto/aes/asm/ bsaes-armv8. pl ( http://bsaes-armv8.pl/ )
|index b3c97e439f..c3c5ff3e05 100644
|--- a/crypto/aes/asm/ bsaes-armv8. pl ( http://bsaes-armv8.pl/ )
|+++ b/crypto/aes/asm/ bsaes-armv8. pl ( http://bsaes-armv8.pl/ )
--------------------------
No file to patch.  Skipping patch.
4 out of 4 hunks ignored
Patch bti.patch does not apply (enforce with -f)

stderr: ")
ERROR: Logfile of failure stored in: /home/vkumbhar/kirkstone-nut/ build/tmp-glibc/work/core2-64- oe-linux/openssl/3.0.13-r0/ temp/log.do_patch.152571
ERROR: Task (/home/vkumbhar/kirkstone-nut/ meta/recipes-connectivity/ openssl/openssl_3.0.13.bb:do_ patch) failed with exit code '1'

[-- Attachment #1.2: Type: text/html, Size: 9610 bytes --]

[-- Attachment #2: Screenshot from 2024-03-29 09-13-48.png --]
[-- Type: image/png, Size: 111439 bytes --]

  reply	other threads:[~2024-03-29  3:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27 11:15 [PATCH][kirkstone] openssl: fix crash on aarch64 if BTI is enabled but no Crypto instructions ross.burton
2024-03-29  3:51 ` Vivek Kumbhar [this message]
2024-03-29 13:31   ` [OE-core] " Steve Sakoman
2024-04-16 12:42     ` Ross Burton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29693.1711684265473117694@lists.openembedded.org \
    --to=vkumbhar@mvista.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.