From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB05AC54E67 for ; Tue, 12 Mar 2024 18:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rFdmrv5KNkEEhzzoYvJpQDbfuL6t1yMqNUC0y2pUpQo=; b=vjGftSWvwzqTMDHmmayZCmKv55 FDIR0htOjwMU0FMv6kR0c6Is94Nmo83M8sVPLM0/zWPp6ZXQdrbBX3gOEmPaDiHq5VLNcvqKwxZI/ IIuOKd6N2JbvIXwKD89UXAfvT19hDreV/PnNNd+AJhr1XI2glek8Khoby8ER/Ru+p88KBMIin7zT/ iMR9CzzXXqOgeXZFDMRaUCSfMZZxG22za79nt8phmYxgywyLM7ZhsSkVYocXD59A7Yy0e0V0pqWpj IPgDAYwL8BfnRAQRziGmAXNxJfwtwkvuz9uW7tKQzuG+RPcvbN7FuXvV1ULL0D1dVvNw1++7wtF2p ZBIka2+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk72z-000000079z9-20Mm; Tue, 12 Mar 2024 18:40:21 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk72t-000000079pJ-3eLQ; Tue, 12 Mar 2024 18:40:18 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1710268800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eOUMJrBPVIn9TrkL5mEgCNIRV6gwF48txggiGGe2juM=; b=OvB690bkpxi/60vbeV02MhcF2IMLno9X6xCBTKd0QVdwOdmsBmiAfHneOH1k2as9FrJ64g F9QWggqs34FW6bJQCDjhWktrjDHTh2QoLh7EVcTvHvBndtUgefNze/zf6+K4gETbTyBXya ZVM8beHo7CgTKk6hXXdBO5me5DMQAXr2UfEDr9Xwx7GT2Bdx7Nxym8G58GsAmp3T7436Tn ZggbfmU4aE0vp43KkHzhVjlZTVdkYqn++1wMfgfRaAcJZEv+UrkLv6osHYW1MWPI2tNzjK 76cujQuEmyab/5q+YOWOy8q28T88PehHRek7AH81/m1JtQNGv02TgOjI1eq2rQ== Date: Tue, 12 Mar 2024 19:39:59 +0100 From: Dragan Simic To: Diederik de Haas Cc: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Andrew Lunn , Chen-Yu Tsai , linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jonas Karlman Subject: Re: [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection In-Reply-To: <3640614.1ifTrbWeP9@bagend> References: <20240304084612.711678-2-ukleinek@debian.org> <2662566.GSV3oLgti5@bagend> <3640614.1ifTrbWeP9@bagend> Message-ID: <2973a2cb1f478031ae6d478c853c33ae@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240312_114016_534049_97F6B59D X-CRM114-Status: GOOD ( 29.72 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGVsbG8gYWxsLAoKT24gMjAyNC0wMy0wNiAwMTowMywgRGllZGVyaWsgZGUgSGFhcyB3cm90ZToK PiBPbiBNb25kYXksIDQgTWFyY2ggMjAyNCAyMzo0NDo0OCBDRVQgVXdlIEtsZWluZS1Lw7ZuaWcg d3JvdGU6Cj4+ID4gVGhhdCB3YXMgYmVjYXVzZSBpdCdzIGFjdHVhbGx5IGEgYnVnIHJlcG9ydCAo d3J0IFF1YXJ0ejY0IEEgYW5kIEIpLCBidXQKPj4gPiBlc3BlY2lhbGx5IHlvdXIgcmVtYXJrIG1h ZGUgYWxsIHRoZSBwaWVjZXMgSSBmb3VuZCBlYXJsaWVyIGZhbGwgaW50bwo+PiA+IHBsYWNlLgo+ PiA+IFRoZXJlZm9yIEkgJ2FidXNlZCcgdGhpcyB0aHJlYWQvcGF0Y2ggdG8gcmVwb3J0IGl0Lgo+ PiA+Cj4+ID4gSSdtIGhhcHB5IHRvIHRlc3QgcGF0Y2hlcywgYnV0IEkgbGFjayB0aGUga25vd2xl ZGdlIHRvIGNvbWUgdXAgd2l0aCBvbmUKPj4gPiBteXNlbGYuCj4+IAo+PiBJIGd1ZXNzIHRoYXQg d291bGQgYmU6Cj4+IAo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hp cC9yazM1NjYtcXVhcnR6NjQtYS5kdHMKPj4gYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlw L3JrMzU2Ni1xdWFydHo2NC1hLmR0cyBpbmRleAo+PiA1OTg0M2E3YTE5OWMuLmY0ZDFkZWJhMzEx MCAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NjYtcXVh cnR6NjQtYS5kdHMKPj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NjYt cXVhcnR6NjQtYS5kdHMKPj4gQEAgLTI2OSw3ICsyNjksNyBAQCAmZ21hYzEgewo+PiAgICAgICAg IGFzc2lnbmVkLWNsb2NrLXBhcmVudHMgPSA8JmNydSBTQ0xLX0dNQUMxX1JHTUlJX1NQRUVEPiwg PCZjcnUKPj4gU0NMS19HTUFDMT4sIDwmZ21hYzFfY2xraW4+OyBjbG9ja19pbl9vdXQgPSAiaW5w dXQiOwo+PiAgICAgICAgIHBoeS1zdXBwbHkgPSA8JnZjY18zdjM+Owo+PiAtICAgICAgIHBoeS1t b2RlID0gInJnbWlpIjsKPj4gKyAgICAgICBwaHktbW9kZSA9ICJyZ21paS1pZCI7Cj4+ICAgICAg ICAgcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPj4gICAgICAgICBwaW5jdHJsLTAgPSA8Jmdt YWMxbTBfbWlpbQo+PiAgICAgICAgICAgICAgICAgICAgICAmZ21hYzFtMF90eF9idXMyCj4+IEBA IC0yODEsOCArMjgxLDYgQEAgJmdtYWMxbTBfY2xraW5vdXQKPj4gICAgICAgICBzbnBzLHJlc2V0 LWFjdGl2ZS1sb3c7Cj4+ICAgICAgICAgLyogUmVzZXQgdGltZSBpcyAyMG1zLCAxMDBtcyBmb3Ig cnRsODIxMWYgKi8KPj4gICAgICAgICBzbnBzLHJlc2V0LWRlbGF5cy11cyA9IDwwIDIwMDAwIDEw MDAwMD47Cj4+IC0gICAgICAgdHhfZGVsYXkgPSA8MHgzMD47Cj4+IC0gICAgICAgcnhfZGVsYXkg PSA8MHgxMD47Cj4+ICAgICAgICAgcGh5LWhhbmRsZSA9IDwmcmdtaWlfcGh5MT47Cj4+ICAgICAg ICAgc3RhdHVzID0gIm9rYXkiOwo+PiAgfTsKPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9v dC9kdHMvcm9ja2NoaXAvcmszNTY2LXF1YXJ0ejY0LWIuZHRzCj4+IGIvYXJjaC9hcm02NC9ib290 L2R0cy9yb2NrY2hpcC9yazM1NjYtcXVhcnR6NjQtYi5kdHMgaW5kZXgKPj4gMmQ5MjcxM2JlMmEw Li5lYzEzNTFhMTcxZDQgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2No aXAvcmszNTY2LXF1YXJ0ejY0LWIuZHRzCj4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9j a2NoaXAvcmszNTY2LXF1YXJ0ejY0LWIuZHRzCj4+IEBAIC0xNzYsNyArMTc2LDcgQEAgJmdtYWMx IHsKPj4gICAgICAgICBhc3NpZ25lZC1jbG9ja3MgPSA8JmNydSBTQ0xLX0dNQUMxX1JYX1RYPiwg PCZjcnUKPj4gU0NMS19HTUFDMV9SR01JSV9TUEVFRD4sIDwmY3J1IFNDTEtfR01BQzE+OyBhc3Np Z25lZC1jbG9jay1wYXJlbnRzID0gCj4+IDwmY3J1Cj4+IFNDTEtfR01BQzFfUkdNSUlfU1BFRUQ+ LCA8JmNydSBTQ0xLX0dNQUMxPiwgPCZnbWFjMV9jbGtpbj47IAo+PiBjbG9ja19pbl9vdXQgPQo+ PiAiaW5wdXQiOwo+PiAtICAgICAgIHBoeS1tb2RlID0gInJnbWlpIjsKPj4gKyAgICAgICBwaHkt bW9kZSA9ICJyZ21paS1pZCI7Cj4+ICAgICAgICAgcGh5LXN1cHBseSA9IDwmdmNjXzN2Mz47Cj4+ ICAgICAgICAgcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPj4gICAgICAgICBwaW5jdHJsLTAg PSA8JmdtYWMxbTFfbWlpbQo+PiBAQCAtMTg5LDggKzE4OSw2IEBAICZnbWFjMW0xX2Nsa2lub3V0 Cj4+ICAgICAgICAgc25wcyxyZXNldC1hY3RpdmUtbG93Owo+PiAgICAgICAgIC8qIFJlc2V0IHRp bWUgaXMgMjBtcywgMTAwbXMgZm9yIHJ0bDgyMTFmLCBhbHNvIHdvcmtzIHdlbGwgCj4+IGhlcmUg Ki8KPj4gICAgICAgICBzbnBzLHJlc2V0LWRlbGF5cy11cyA9IDwwIDIwMDAwIDEwMDAwMD47Cj4+ IC0gICAgICAgdHhfZGVsYXkgPSA8MHg0Zj47Cj4+IC0gICAgICAgcnhfZGVsYXkgPSA8MHgyND47 Cj4+ICAgICAgICAgcGh5LWhhbmRsZSA9IDwmcmdtaWlfcGh5MT47Cj4+ICAgICAgICAgc3RhdHVz ID0gIm9rYXkiOwo+PiAgfTsKPiAKPiBJdCB0dXJucyBvdXQgbXkgcmVzZWFyY2ggd2FzIGluY29t cGxldGUuIEkgYWxyZWFkeSBmZWx0IHVuZWFzeSB3aGVuIEkgCj4gcmVhbGl6ZWQKPiB0aGF0ICdw Z3dpcGVvdXQnIGhhZCBzZXQgaXQgdG8gcmdtaWkgYW5kIHdoaWxlIEkgd2Fzbid0IGFibGUgdG8g dHJhY2sgCj4gdGhlCj4gY29udmVyc2F0aW9uIGRvd24sIEkgZGlkIGhhdmUgYSB2YWd1ZSByZWNv bGxlY3Rpb24gb2YgdGhlcmUgYmVpbmcgYSAKPiBkaXNjdXNzaW9uCj4gd3J0IHJnbWlpIHZzIHJn bWlpLWlkLiBJT1c6IGhlIG11c3QgaGF2ZSBzZXQgaXQgdG8gcmdtaWkgZGVsaWJlcmF0ZWx5Lgo+ IAo+IEFuZCB0aGVuIEkgZm91bmQgdGhpczoKPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwv MjAyMjA2MDYxNjMwMjMuMzY3NzE0Ny0xLXBnd2lwZW91dEBnbWFpbC5jb20vCj4gCj4gRm9yIE1v ZGVsIEIgaXQgd2FzIGluaXRpYWxseSBzZXQgdG8gcmdtaWktaWQsIGJ1dCB3YXMgbGF0ZXIgY2hh bmdlZCB0byAKPiByZ21paQo+IGR1ZSB0byBjb21wYXRpYmlsaXR5IGlzc3VlcyBvbiB0aGUgcHJv ZHVjdGlvbiBNb2RlbCBCLgo+IEknbSBnb2luZyB0byBhc3N1bWUgdGhhdCBpdCB3YXMgKGluaXRp YWxseSkgc2V0IHRvIHJnbWlpIG9uIE1vZGVsIEEgZm9yCj4gc2ltaWxhciByZWFzb25zLgoKSSB3 ZW50IHRocm91Z2ggc29tZSBvZiBteSBvbGQtaXNoIG5vdGVzIGFuZCBmb3VuZCB0aGUgcmlnaHQg ZXhjZXJwdHMgCmZyb20KbXkgbG9ncyBvZiB0aGUgI3F1YXJ0ejY0IGNoYW5uZWwgb24gdGhlIFBp bmU2NCBJUkMgc2VydmVyLiAgSGVyZSB0aGV5IAphcmUsCmZvciBmdXR1cmUgcmVmZXJlbmNlLCBh bmQgc29ycnkgZm9yIGEgYml0IGxvbmcgbGluZXM6CgogICA8bWVnaTI+IHRoZSBldGhlcm5ldCBp c3N1ZSBpcyByZXNvbHZlZCBieSBwaHktbW9kZSA9ICJyZ21paS1pZCIgLT4gCnBoeS1tb2RlID0g InJnbWlpIj8KICAgPG1lZ2kyPiBkaXNhYmxpbmcgaW50ZXJuYWwgZGVsYXlzIGluIHRoZSBwaHku Li4KCiAgIDxwZ3dpcGVvdXQ+IEkndmUgYmVlbiBydW5uaW5nIHJnbWlpLWlkIGZvciBhIHdoaWxl IG5vdywgb24gc2V2ZXJhbCAKYm9hcmRzLgogICA8cGd3aXBlb3V0PiBUaGUgaW5uZXIgZGVsYXlz IGFyZSBwcm9ncmFtbWVkIG92ZXIgdGhlIG1paSBpbnRlcmZhY2UgaW4gCnRoZSBtYWMgaXRzZWxm LgogICA8cGd3aXBlb3V0PiBUaGUgTW90b3Jjb21tIGhhcyBpbnNhbmUgZGVmYXVsdCBzZXR0aW5n cywgcmdtaWkgbW9kZSAKemVyb3MgdGhlbSAod2VsbCBhcyBjbG9zZSB0byB6ZXJvCiAgICAgICAg ICAgICAgIGFzIHdlIGNhbiBnZXQpLCByZ21paS1pZCBzZXRzIHRoZW0gdG8gdGhlIGRlZmF1bHQg dmFsdWVzIAp0aGUgcmdtaWkgc3BlYyBjYWxscyBmb3IuCiAgIDxtZWdpPiBwZ3dpcGVvdXQ6IGRl bGF5cyBhcmUgaGFyZGNvZGVkIGluIHRoZSBkcml2ZXI/CiAgIDxwZ3dpcGVvdXQ+IFllYWgsIHRo ZXkgYXJlIGN1cnJlbnRseS4gQWRqdXN0YWJsZSBkZWxheXMgYXJlIGF2YWlsYWJsZSAKaW4gdGhl IGdtYWMgZHJpdmVyIGFuZCByZ21paSBtb2RlLgoKICAgPGRzaW1pYz4gQHBnd2lwZW91dCAocmU6 IFRYIGFuZCBSWCBkZWxheXMpIGlmIEkgZ290IGl0IHJpZ2h0LCAKInR4X2RlbGF5IiBhbmQgInJ4 X2RlbGF5IiBwYXJhbWV0ZXJzCiAgICAgICAgICAgIGluIERUIGFyZSBmb3IgdGhlIEdNQUMgaXRz ZWxmLCBhcyBkZXNjcmliZWQgZm9yIHRoZSBSSzMzOTkgb24gCnBhZ2UgNjA0IGluCiAgICAgICAg ICAgIApodHRwczovL3d3dy50LWZpcmVmbHkuY29tL2Rvd25sb2FkL0ZpcmVmbHktUkszMzk5L2Rv Y3MvVFJNL1JvY2tjaGlwJTIwUkszMzk5VFJNJTIwVjEuMyUyMFBhcnQyLnBkZgogICA8ZHNpbWlj PiB3aGlsZSB0aGUgTW90b3Jjb21tIFBIWSBoYXMgaXRzIG93biwgc2VwYXJhdGUgZGVsYXlzLCB3 aGljaCAKYXJlIGNvbmZpZ3VyZWQgaW4gdGhlIE1vdG9yY29tbSBQSFkgZHJpdmVyCiAgIDxkc2lt aWM+IGFuZCBhbGwgdGhhdCBkZXBlbmRzIG9uIHRoZSBzZWxlY3RlZCBpbnRlcmZhY2UgbW9kZSAo UkdNSUksIApSR01JSV9JRCwgZXRjLikKICAgPGRzaW1pYz4gY291bGQgeW91LCBwbGVhc2UsIHRl bGwgbWUgaWYgbXkgdW5kZXJzdGFuZGluZyBpcyByaWdodD8KCiAgIDxwZ3dpcGVvdXQ+IEBkc2lt aWMgQ29ycmVjdCwgdGhlIGdtYWMgcGFyYW1ldGVycyBjb250cm9sIHRoZSBnbWFjJ3MgCmRlbGF5 cy4gUkdNSUkgc3BlYyByZXF1aXJlcyB0aGUgY2xvY2sKICAgICAgICAgICAgICAgdG8gYmUgYWN0 aXZlIGZvciBhIHNwZWNpZmljIHBlcmlvZCBvZiB0aW1lIGJlZm9yZSB0aGUgZGF0YSAKaXMgcmVj ZWl2ZWQuIFJHTUlJIG1vZGUgaXMgc3VwcG9zZWQKICAgICAgICAgICAgICAgdG8gYmUgZm9yIHdo ZW4gdGhlIGNvcnJlY3QgZGVsYXkgaXMgYnVpbHQgaW50byB0aGUgCmhhcmR3YXJlIGJ5IG1ha2lu ZyB0aGUgZGF0YSBsaW5lcyBsb25nZXIKICAgICAgICAgICAgICAgdGhhbiB0aGUgY2xvY2sgbGlu ZXMuIFJHTUlJLUlEIGFzc3VtZXMgYWxsIG9mIHRoZSBsaW5lcyAKYXJlIGV4YWN0bHkgdGhlIHNh bWUgbGVuZ3RoIGFuZCBpbXBsZW1lbnRzCiAgICAgICAgICAgICAgIHRoZSBkZWxheSBpbiB0aGUg TUFDIGluc3RlYWQuIEFkanVzdGluZyB0aGUgZGVsYXlzIGZyb20gCnRoZSBkZWZhdWx0IG1lYW5z IG5laXRoZXIgb2YgdGhlc2UgYXJlIHRydWUuCiAgIDxwZ3dpcGVvdXQ+IFdoZW4gUkdNSUktSUQg bW9kZSBpcyBhY3RpdmUsIHRoZSBHTUFDIGRyaXZlciB6ZXJvcyBvdXQgCml0cyBpbnRlcm5hbCBk ZWxheXMsIGJ1dCBpdCBzdGlsbCBjb21wbGFpbnMKICAgICAgICAgICAgICAgaWYgdGhleSBhcmVu J3QgaW4gdGhlIERULgoKICAgPGRzaW1pYz4gQHBnd2lwZW91dDogdGhhbmsgeW91IHZlcnkgbXVj aCBmb3IgdGhlIGV4cGxhbmF0aW9uOyAgeWVzLCBJIApzYXcgdGhhdCB0aGUgInR4X2RlbGF5IiBh bmQgInJ4X2RlbGF5IgogICAgICAgICAgICBwYXJhbWV0ZXJzIGluIHRoZSBEVCBhcmUgbWFuZGF0 b3J5IGV2ZW4gd2hlbiB0aGV5IGVuZCB1cCAKdW51c2VkLCBhbmQgdGhlcmUgYXJlIGV2ZW4gaGFy ZGNvZGVkIGRlZmF1bHRzCiAgICAgICAgICAgIGZvciB0aG9zZSBwYXJhbWV0ZXJzIGluIHRoZSBN QUMgZHJpdmVyLCB3aGljaCBhbGwgbG9va2VkIApzdHJhbmdlCgogICA8cGd3aXBlb3V0PiBNb3Jl IGxpa2VseSB3ZSBqdXN0IGRvbid0IGtub3cgdGhlIHZhbHVlIHRyYW5zbGF0aW9uIGZvciAKdGhl IFJ4IGFuZCBUeCB2YWx1ZXMgYW5kIHRoZXkgYXJlbid0IHBlcmZlY3RseQogICAgICAgICAgICAg ICBsaW5pbmcgdXAuIFNvIHdlIGFyZSByaWdodCBvbiB0aGUgZWRnZSBvZiB0aGUgYmVsbCB3aXRo IApJRCwgYW5kIHZhcmlhdGlvbnMgaW4gbWFudWZhY3R1cmluZyBwdXQgdXMgb24KICAgICAgICAg ICAgICAgb25lIHNpZGUgb3IgdGhlIG90aGVyLgogICA8cGd3aXBlb3V0PiBFaXRoZXIgdGhhdCBv ciB0aGUgcmszNTZ4IGdtYWMgaGFzIGRpZmZlcmVudCBpbnRlcm5hbCAKZGVsYXlzIHRoYW4gcHJl dmlvdXMgY2hpcHMuIFRoZSBkZWZhdWx0IGlzIGJhc2VkCiAgICAgICAgICAgICAgIG9uIHRoZSBy azMzIHNlcmllcyBvZiAweDEwIGJ1dCB0aGUgcmVmIGJvYXJkcyBmb3IgdGhlIHJrMzUgCnNlcmll cyB1c2VzIDB4MWYuCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA48CC54E58 for ; Tue, 12 Mar 2024 18:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZYel6q0i/2IV+QRN5O4PFGL9KlKeI3NQXdbeKSYzxJo=; b=fXG7gomwp0/1aHJEQU8sRLNM+K hrjNPIO8lQJlo+5cQgQCJvlKgHebCJsi67w0Y3A6Sun2LPwJtwkT15IP2gJ4hfRrvJUS0MKKRemON eHk8rNv5pbhEEaseydFh54rjlgs8CwrHmTnQsM/TFpke+nzRDE55/JspCACsZ3SwhO0GWUUM4jpL1 tRBKUPtH+U8YmISFrN+OvkbZSKNBEttk8GMTXCedCkZfmEKBa6RmQ2z3W2PWoPRQ3r4du2Arepmnj WThGDIE3I4rPE/GEMRoxvLdmj7dr8n9BUWcT92+FEsdZaE1xChtMsI6T2h+lcTQhvQudbF1LIhth5 /EVpPlsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk72y-000000079yh-2m2K; Tue, 12 Mar 2024 18:40:20 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk72t-000000079pJ-3eLQ; Tue, 12 Mar 2024 18:40:18 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1710268800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eOUMJrBPVIn9TrkL5mEgCNIRV6gwF48txggiGGe2juM=; b=OvB690bkpxi/60vbeV02MhcF2IMLno9X6xCBTKd0QVdwOdmsBmiAfHneOH1k2as9FrJ64g F9QWggqs34FW6bJQCDjhWktrjDHTh2QoLh7EVcTvHvBndtUgefNze/zf6+K4gETbTyBXya ZVM8beHo7CgTKk6hXXdBO5me5DMQAXr2UfEDr9Xwx7GT2Bdx7Nxym8G58GsAmp3T7436Tn ZggbfmU4aE0vp43KkHzhVjlZTVdkYqn++1wMfgfRaAcJZEv+UrkLv6osHYW1MWPI2tNzjK 76cujQuEmyab/5q+YOWOy8q28T88PehHRek7AH81/m1JtQNGv02TgOjI1eq2rQ== Date: Tue, 12 Mar 2024 19:39:59 +0100 From: Dragan Simic To: Diederik de Haas Cc: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Andrew Lunn , Chen-Yu Tsai , linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jonas Karlman Subject: Re: [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection In-Reply-To: <3640614.1ifTrbWeP9@bagend> References: <20240304084612.711678-2-ukleinek@debian.org> <2662566.GSV3oLgti5@bagend> <3640614.1ifTrbWeP9@bagend> Message-ID: <2973a2cb1f478031ae6d478c853c33ae@manjaro.org> X-Sender: dsimic@manjaro.org Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240312_114016_534049_97F6B59D X-CRM114-Status: GOOD ( 29.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gYWxsLAoKT24gMjAyNC0wMy0wNiAwMTowMywgRGllZGVyaWsgZGUgSGFhcyB3cm90ZToK PiBPbiBNb25kYXksIDQgTWFyY2ggMjAyNCAyMzo0NDo0OCBDRVQgVXdlIEtsZWluZS1Lw7ZuaWcg d3JvdGU6Cj4+ID4gVGhhdCB3YXMgYmVjYXVzZSBpdCdzIGFjdHVhbGx5IGEgYnVnIHJlcG9ydCAo d3J0IFF1YXJ0ejY0IEEgYW5kIEIpLCBidXQKPj4gPiBlc3BlY2lhbGx5IHlvdXIgcmVtYXJrIG1h ZGUgYWxsIHRoZSBwaWVjZXMgSSBmb3VuZCBlYXJsaWVyIGZhbGwgaW50bwo+PiA+IHBsYWNlLgo+ PiA+IFRoZXJlZm9yIEkgJ2FidXNlZCcgdGhpcyB0aHJlYWQvcGF0Y2ggdG8gcmVwb3J0IGl0Lgo+ PiA+Cj4+ID4gSSdtIGhhcHB5IHRvIHRlc3QgcGF0Y2hlcywgYnV0IEkgbGFjayB0aGUga25vd2xl ZGdlIHRvIGNvbWUgdXAgd2l0aCBvbmUKPj4gPiBteXNlbGYuCj4+IAo+PiBJIGd1ZXNzIHRoYXQg d291bGQgYmU6Cj4+IAo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hp cC9yazM1NjYtcXVhcnR6NjQtYS5kdHMKPj4gYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlw L3JrMzU2Ni1xdWFydHo2NC1hLmR0cyBpbmRleAo+PiA1OTg0M2E3YTE5OWMuLmY0ZDFkZWJhMzEx MCAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NjYtcXVh cnR6NjQtYS5kdHMKPj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1NjYt cXVhcnR6NjQtYS5kdHMKPj4gQEAgLTI2OSw3ICsyNjksNyBAQCAmZ21hYzEgewo+PiAgICAgICAg IGFzc2lnbmVkLWNsb2NrLXBhcmVudHMgPSA8JmNydSBTQ0xLX0dNQUMxX1JHTUlJX1NQRUVEPiwg PCZjcnUKPj4gU0NMS19HTUFDMT4sIDwmZ21hYzFfY2xraW4+OyBjbG9ja19pbl9vdXQgPSAiaW5w dXQiOwo+PiAgICAgICAgIHBoeS1zdXBwbHkgPSA8JnZjY18zdjM+Owo+PiAtICAgICAgIHBoeS1t b2RlID0gInJnbWlpIjsKPj4gKyAgICAgICBwaHktbW9kZSA9ICJyZ21paS1pZCI7Cj4+ICAgICAg ICAgcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPj4gICAgICAgICBwaW5jdHJsLTAgPSA8Jmdt YWMxbTBfbWlpbQo+PiAgICAgICAgICAgICAgICAgICAgICAmZ21hYzFtMF90eF9idXMyCj4+IEBA IC0yODEsOCArMjgxLDYgQEAgJmdtYWMxbTBfY2xraW5vdXQKPj4gICAgICAgICBzbnBzLHJlc2V0 LWFjdGl2ZS1sb3c7Cj4+ICAgICAgICAgLyogUmVzZXQgdGltZSBpcyAyMG1zLCAxMDBtcyBmb3Ig cnRsODIxMWYgKi8KPj4gICAgICAgICBzbnBzLHJlc2V0LWRlbGF5cy11cyA9IDwwIDIwMDAwIDEw MDAwMD47Cj4+IC0gICAgICAgdHhfZGVsYXkgPSA8MHgzMD47Cj4+IC0gICAgICAgcnhfZGVsYXkg PSA8MHgxMD47Cj4+ICAgICAgICAgcGh5LWhhbmRsZSA9IDwmcmdtaWlfcGh5MT47Cj4+ICAgICAg ICAgc3RhdHVzID0gIm9rYXkiOwo+PiAgfTsKPj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtNjQvYm9v dC9kdHMvcm9ja2NoaXAvcmszNTY2LXF1YXJ0ejY0LWIuZHRzCj4+IGIvYXJjaC9hcm02NC9ib290 L2R0cy9yb2NrY2hpcC9yazM1NjYtcXVhcnR6NjQtYi5kdHMgaW5kZXgKPj4gMmQ5MjcxM2JlMmEw Li5lYzEzNTFhMTcxZDQgMTAwNjQ0Cj4+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2No aXAvcmszNTY2LXF1YXJ0ejY0LWIuZHRzCj4+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9j a2NoaXAvcmszNTY2LXF1YXJ0ejY0LWIuZHRzCj4+IEBAIC0xNzYsNyArMTc2LDcgQEAgJmdtYWMx IHsKPj4gICAgICAgICBhc3NpZ25lZC1jbG9ja3MgPSA8JmNydSBTQ0xLX0dNQUMxX1JYX1RYPiwg PCZjcnUKPj4gU0NMS19HTUFDMV9SR01JSV9TUEVFRD4sIDwmY3J1IFNDTEtfR01BQzE+OyBhc3Np Z25lZC1jbG9jay1wYXJlbnRzID0gCj4+IDwmY3J1Cj4+IFNDTEtfR01BQzFfUkdNSUlfU1BFRUQ+ LCA8JmNydSBTQ0xLX0dNQUMxPiwgPCZnbWFjMV9jbGtpbj47IAo+PiBjbG9ja19pbl9vdXQgPQo+ PiAiaW5wdXQiOwo+PiAtICAgICAgIHBoeS1tb2RlID0gInJnbWlpIjsKPj4gKyAgICAgICBwaHkt bW9kZSA9ICJyZ21paS1pZCI7Cj4+ICAgICAgICAgcGh5LXN1cHBseSA9IDwmdmNjXzN2Mz47Cj4+ ICAgICAgICAgcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPj4gICAgICAgICBwaW5jdHJsLTAg PSA8JmdtYWMxbTFfbWlpbQo+PiBAQCAtMTg5LDggKzE4OSw2IEBAICZnbWFjMW0xX2Nsa2lub3V0 Cj4+ICAgICAgICAgc25wcyxyZXNldC1hY3RpdmUtbG93Owo+PiAgICAgICAgIC8qIFJlc2V0IHRp bWUgaXMgMjBtcywgMTAwbXMgZm9yIHJ0bDgyMTFmLCBhbHNvIHdvcmtzIHdlbGwgCj4+IGhlcmUg Ki8KPj4gICAgICAgICBzbnBzLHJlc2V0LWRlbGF5cy11cyA9IDwwIDIwMDAwIDEwMDAwMD47Cj4+ IC0gICAgICAgdHhfZGVsYXkgPSA8MHg0Zj47Cj4+IC0gICAgICAgcnhfZGVsYXkgPSA8MHgyND47 Cj4+ICAgICAgICAgcGh5LWhhbmRsZSA9IDwmcmdtaWlfcGh5MT47Cj4+ICAgICAgICAgc3RhdHVz ID0gIm9rYXkiOwo+PiAgfTsKPiAKPiBJdCB0dXJucyBvdXQgbXkgcmVzZWFyY2ggd2FzIGluY29t cGxldGUuIEkgYWxyZWFkeSBmZWx0IHVuZWFzeSB3aGVuIEkgCj4gcmVhbGl6ZWQKPiB0aGF0ICdw Z3dpcGVvdXQnIGhhZCBzZXQgaXQgdG8gcmdtaWkgYW5kIHdoaWxlIEkgd2Fzbid0IGFibGUgdG8g dHJhY2sgCj4gdGhlCj4gY29udmVyc2F0aW9uIGRvd24sIEkgZGlkIGhhdmUgYSB2YWd1ZSByZWNv bGxlY3Rpb24gb2YgdGhlcmUgYmVpbmcgYSAKPiBkaXNjdXNzaW9uCj4gd3J0IHJnbWlpIHZzIHJn bWlpLWlkLiBJT1c6IGhlIG11c3QgaGF2ZSBzZXQgaXQgdG8gcmdtaWkgZGVsaWJlcmF0ZWx5Lgo+ IAo+IEFuZCB0aGVuIEkgZm91bmQgdGhpczoKPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwv MjAyMjA2MDYxNjMwMjMuMzY3NzE0Ny0xLXBnd2lwZW91dEBnbWFpbC5jb20vCj4gCj4gRm9yIE1v ZGVsIEIgaXQgd2FzIGluaXRpYWxseSBzZXQgdG8gcmdtaWktaWQsIGJ1dCB3YXMgbGF0ZXIgY2hh bmdlZCB0byAKPiByZ21paQo+IGR1ZSB0byBjb21wYXRpYmlsaXR5IGlzc3VlcyBvbiB0aGUgcHJv ZHVjdGlvbiBNb2RlbCBCLgo+IEknbSBnb2luZyB0byBhc3N1bWUgdGhhdCBpdCB3YXMgKGluaXRp YWxseSkgc2V0IHRvIHJnbWlpIG9uIE1vZGVsIEEgZm9yCj4gc2ltaWxhciByZWFzb25zLgoKSSB3 ZW50IHRocm91Z2ggc29tZSBvZiBteSBvbGQtaXNoIG5vdGVzIGFuZCBmb3VuZCB0aGUgcmlnaHQg ZXhjZXJwdHMgCmZyb20KbXkgbG9ncyBvZiB0aGUgI3F1YXJ0ejY0IGNoYW5uZWwgb24gdGhlIFBp bmU2NCBJUkMgc2VydmVyLiAgSGVyZSB0aGV5IAphcmUsCmZvciBmdXR1cmUgcmVmZXJlbmNlLCBh bmQgc29ycnkgZm9yIGEgYml0IGxvbmcgbGluZXM6CgogICA8bWVnaTI+IHRoZSBldGhlcm5ldCBp c3N1ZSBpcyByZXNvbHZlZCBieSBwaHktbW9kZSA9ICJyZ21paS1pZCIgLT4gCnBoeS1tb2RlID0g InJnbWlpIj8KICAgPG1lZ2kyPiBkaXNhYmxpbmcgaW50ZXJuYWwgZGVsYXlzIGluIHRoZSBwaHku Li4KCiAgIDxwZ3dpcGVvdXQ+IEkndmUgYmVlbiBydW5uaW5nIHJnbWlpLWlkIGZvciBhIHdoaWxl IG5vdywgb24gc2V2ZXJhbCAKYm9hcmRzLgogICA8cGd3aXBlb3V0PiBUaGUgaW5uZXIgZGVsYXlz IGFyZSBwcm9ncmFtbWVkIG92ZXIgdGhlIG1paSBpbnRlcmZhY2UgaW4gCnRoZSBtYWMgaXRzZWxm LgogICA8cGd3aXBlb3V0PiBUaGUgTW90b3Jjb21tIGhhcyBpbnNhbmUgZGVmYXVsdCBzZXR0aW5n cywgcmdtaWkgbW9kZSAKemVyb3MgdGhlbSAod2VsbCBhcyBjbG9zZSB0byB6ZXJvCiAgICAgICAg ICAgICAgIGFzIHdlIGNhbiBnZXQpLCByZ21paS1pZCBzZXRzIHRoZW0gdG8gdGhlIGRlZmF1bHQg dmFsdWVzIAp0aGUgcmdtaWkgc3BlYyBjYWxscyBmb3IuCiAgIDxtZWdpPiBwZ3dpcGVvdXQ6IGRl bGF5cyBhcmUgaGFyZGNvZGVkIGluIHRoZSBkcml2ZXI/CiAgIDxwZ3dpcGVvdXQ+IFllYWgsIHRo ZXkgYXJlIGN1cnJlbnRseS4gQWRqdXN0YWJsZSBkZWxheXMgYXJlIGF2YWlsYWJsZSAKaW4gdGhl IGdtYWMgZHJpdmVyIGFuZCByZ21paSBtb2RlLgoKICAgPGRzaW1pYz4gQHBnd2lwZW91dCAocmU6 IFRYIGFuZCBSWCBkZWxheXMpIGlmIEkgZ290IGl0IHJpZ2h0LCAKInR4X2RlbGF5IiBhbmQgInJ4 X2RlbGF5IiBwYXJhbWV0ZXJzCiAgICAgICAgICAgIGluIERUIGFyZSBmb3IgdGhlIEdNQUMgaXRz ZWxmLCBhcyBkZXNjcmliZWQgZm9yIHRoZSBSSzMzOTkgb24gCnBhZ2UgNjA0IGluCiAgICAgICAg ICAgIApodHRwczovL3d3dy50LWZpcmVmbHkuY29tL2Rvd25sb2FkL0ZpcmVmbHktUkszMzk5L2Rv Y3MvVFJNL1JvY2tjaGlwJTIwUkszMzk5VFJNJTIwVjEuMyUyMFBhcnQyLnBkZgogICA8ZHNpbWlj PiB3aGlsZSB0aGUgTW90b3Jjb21tIFBIWSBoYXMgaXRzIG93biwgc2VwYXJhdGUgZGVsYXlzLCB3 aGljaCAKYXJlIGNvbmZpZ3VyZWQgaW4gdGhlIE1vdG9yY29tbSBQSFkgZHJpdmVyCiAgIDxkc2lt aWM+IGFuZCBhbGwgdGhhdCBkZXBlbmRzIG9uIHRoZSBzZWxlY3RlZCBpbnRlcmZhY2UgbW9kZSAo UkdNSUksIApSR01JSV9JRCwgZXRjLikKICAgPGRzaW1pYz4gY291bGQgeW91LCBwbGVhc2UsIHRl bGwgbWUgaWYgbXkgdW5kZXJzdGFuZGluZyBpcyByaWdodD8KCiAgIDxwZ3dpcGVvdXQ+IEBkc2lt aWMgQ29ycmVjdCwgdGhlIGdtYWMgcGFyYW1ldGVycyBjb250cm9sIHRoZSBnbWFjJ3MgCmRlbGF5 cy4gUkdNSUkgc3BlYyByZXF1aXJlcyB0aGUgY2xvY2sKICAgICAgICAgICAgICAgdG8gYmUgYWN0 aXZlIGZvciBhIHNwZWNpZmljIHBlcmlvZCBvZiB0aW1lIGJlZm9yZSB0aGUgZGF0YSAKaXMgcmVj ZWl2ZWQuIFJHTUlJIG1vZGUgaXMgc3VwcG9zZWQKICAgICAgICAgICAgICAgdG8gYmUgZm9yIHdo ZW4gdGhlIGNvcnJlY3QgZGVsYXkgaXMgYnVpbHQgaW50byB0aGUgCmhhcmR3YXJlIGJ5IG1ha2lu ZyB0aGUgZGF0YSBsaW5lcyBsb25nZXIKICAgICAgICAgICAgICAgdGhhbiB0aGUgY2xvY2sgbGlu ZXMuIFJHTUlJLUlEIGFzc3VtZXMgYWxsIG9mIHRoZSBsaW5lcyAKYXJlIGV4YWN0bHkgdGhlIHNh bWUgbGVuZ3RoIGFuZCBpbXBsZW1lbnRzCiAgICAgICAgICAgICAgIHRoZSBkZWxheSBpbiB0aGUg TUFDIGluc3RlYWQuIEFkanVzdGluZyB0aGUgZGVsYXlzIGZyb20gCnRoZSBkZWZhdWx0IG1lYW5z IG5laXRoZXIgb2YgdGhlc2UgYXJlIHRydWUuCiAgIDxwZ3dpcGVvdXQ+IFdoZW4gUkdNSUktSUQg bW9kZSBpcyBhY3RpdmUsIHRoZSBHTUFDIGRyaXZlciB6ZXJvcyBvdXQgCml0cyBpbnRlcm5hbCBk ZWxheXMsIGJ1dCBpdCBzdGlsbCBjb21wbGFpbnMKICAgICAgICAgICAgICAgaWYgdGhleSBhcmVu J3QgaW4gdGhlIERULgoKICAgPGRzaW1pYz4gQHBnd2lwZW91dDogdGhhbmsgeW91IHZlcnkgbXVj aCBmb3IgdGhlIGV4cGxhbmF0aW9uOyAgeWVzLCBJIApzYXcgdGhhdCB0aGUgInR4X2RlbGF5IiBh bmQgInJ4X2RlbGF5IgogICAgICAgICAgICBwYXJhbWV0ZXJzIGluIHRoZSBEVCBhcmUgbWFuZGF0 b3J5IGV2ZW4gd2hlbiB0aGV5IGVuZCB1cCAKdW51c2VkLCBhbmQgdGhlcmUgYXJlIGV2ZW4gaGFy ZGNvZGVkIGRlZmF1bHRzCiAgICAgICAgICAgIGZvciB0aG9zZSBwYXJhbWV0ZXJzIGluIHRoZSBN QUMgZHJpdmVyLCB3aGljaCBhbGwgbG9va2VkIApzdHJhbmdlCgogICA8cGd3aXBlb3V0PiBNb3Jl IGxpa2VseSB3ZSBqdXN0IGRvbid0IGtub3cgdGhlIHZhbHVlIHRyYW5zbGF0aW9uIGZvciAKdGhl IFJ4IGFuZCBUeCB2YWx1ZXMgYW5kIHRoZXkgYXJlbid0IHBlcmZlY3RseQogICAgICAgICAgICAg ICBsaW5pbmcgdXAuIFNvIHdlIGFyZSByaWdodCBvbiB0aGUgZWRnZSBvZiB0aGUgYmVsbCB3aXRo IApJRCwgYW5kIHZhcmlhdGlvbnMgaW4gbWFudWZhY3R1cmluZyBwdXQgdXMgb24KICAgICAgICAg ICAgICAgb25lIHNpZGUgb3IgdGhlIG90aGVyLgogICA8cGd3aXBlb3V0PiBFaXRoZXIgdGhhdCBv ciB0aGUgcmszNTZ4IGdtYWMgaGFzIGRpZmZlcmVudCBpbnRlcm5hbCAKZGVsYXlzIHRoYW4gcHJl dmlvdXMgY2hpcHMuIFRoZSBkZWZhdWx0IGlzIGJhc2VkCiAgICAgICAgICAgICAgIG9uIHRoZSBy azMzIHNlcmllcyBvZiAweDEwIGJ1dCB0aGUgcmVmIGJvYXJkcyBmb3IgdGhlIHJrMzUgCnNlcmll cyB1c2VzIDB4MWYuCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D0E9141988 for ; Tue, 12 Mar 2024 18:40:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710268806; cv=none; b=ZLzf7D1fQwZPzLUsEv9hAlRXqQEx1jnlzTnHYJ7x0koqYHkuJgut7Q4PayEpCWKXKrvHA7gE3R+gdjHQNM34I6N1kASiB0KWzN3t/BurPsCsytKqQmdQoMnbqwcF7t9N7LkCz1mYCgNWsGUIn67/ADE+HnK6QPZwi3E+nR0LBWg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710268806; c=relaxed/simple; bh=NbbK3Au+24EsH24s6beLOEXMFKWUqmyA5Vmvpn/dD/Y=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=Imvfp6OU+F0Be41UKEicNyKWtBEhg5R4JcYGSJR1K/Yoh2oK7y/+nQVcE5HNitLZtrUuXLf8IWGDis1nbKQQQe7SUYr17vsjdQ8rsMCRSBK6FpejpS/qIuaph8xQfb4R4W97S3h73EhnVxMXKs7nMN+SDtTd5c/DiLYmtnjlUXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=OvB690bk; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="OvB690bk" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1710268800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eOUMJrBPVIn9TrkL5mEgCNIRV6gwF48txggiGGe2juM=; b=OvB690bkpxi/60vbeV02MhcF2IMLno9X6xCBTKd0QVdwOdmsBmiAfHneOH1k2as9FrJ64g F9QWggqs34FW6bJQCDjhWktrjDHTh2QoLh7EVcTvHvBndtUgefNze/zf6+K4gETbTyBXya ZVM8beHo7CgTKk6hXXdBO5me5DMQAXr2UfEDr9Xwx7GT2Bdx7Nxym8G58GsAmp3T7436Tn ZggbfmU4aE0vp43KkHzhVjlZTVdkYqn++1wMfgfRaAcJZEv+UrkLv6osHYW1MWPI2tNzjK 76cujQuEmyab/5q+YOWOy8q28T88PehHRek7AH81/m1JtQNGv02TgOjI1eq2rQ== Date: Tue, 12 Mar 2024 19:39:59 +0100 From: Dragan Simic To: Diederik de Haas Cc: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Andrew Lunn , Chen-Yu Tsai , linux-rockchip@lists.infradead.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jonas Karlman Subject: Re: [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection In-Reply-To: <3640614.1ifTrbWeP9@bagend> References: <20240304084612.711678-2-ukleinek@debian.org> <2662566.GSV3oLgti5@bagend> <3640614.1ifTrbWeP9@bagend> Message-ID: <2973a2cb1f478031ae6d478c853c33ae@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org Hello all, On 2024-03-06 01:03, Diederik de Haas wrote: > On Monday, 4 March 2024 23:44:48 CET Uwe Kleine-König wrote: >> > That was because it's actually a bug report (wrt Quartz64 A and B), but >> > especially your remark made all the pieces I found earlier fall into >> > place. >> > Therefor I 'abused' this thread/patch to report it. >> > >> > I'm happy to test patches, but I lack the knowledge to come up with one >> > myself. >> >> I guess that would be: >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts >> b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts index >> 59843a7a199c..f4d1deba3110 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts >> @@ -269,7 +269,7 @@ &gmac1 { >> assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>, <&cru >> SCLK_GMAC1>, <&gmac1_clkin>; clock_in_out = "input"; >> phy-supply = <&vcc_3v3>; >> - phy-mode = "rgmii"; >> + phy-mode = "rgmii-id"; >> pinctrl-names = "default"; >> pinctrl-0 = <&gmac1m0_miim >> &gmac1m0_tx_bus2 >> @@ -281,8 +281,6 @@ &gmac1m0_clkinout >> snps,reset-active-low; >> /* Reset time is 20ms, 100ms for rtl8211f */ >> snps,reset-delays-us = <0 20000 100000>; >> - tx_delay = <0x30>; >> - rx_delay = <0x10>; >> phy-handle = <&rgmii_phy1>; >> status = "okay"; >> }; >> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts >> b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts index >> 2d92713be2a0..ec1351a171d4 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts >> @@ -176,7 +176,7 @@ &gmac1 { >> assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru >> SCLK_GMAC1_RGMII_SPEED>, <&cru SCLK_GMAC1>; assigned-clock-parents = >> <&cru >> SCLK_GMAC1_RGMII_SPEED>, <&cru SCLK_GMAC1>, <&gmac1_clkin>; >> clock_in_out = >> "input"; >> - phy-mode = "rgmii"; >> + phy-mode = "rgmii-id"; >> phy-supply = <&vcc_3v3>; >> pinctrl-names = "default"; >> pinctrl-0 = <&gmac1m1_miim >> @@ -189,8 +189,6 @@ &gmac1m1_clkinout >> snps,reset-active-low; >> /* Reset time is 20ms, 100ms for rtl8211f, also works well >> here */ >> snps,reset-delays-us = <0 20000 100000>; >> - tx_delay = <0x4f>; >> - rx_delay = <0x24>; >> phy-handle = <&rgmii_phy1>; >> status = "okay"; >> }; > > It turns out my research was incomplete. I already felt uneasy when I > realized > that 'pgwipeout' had set it to rgmii and while I wasn't able to track > the > conversation down, I did have a vague recollection of there being a > discussion > wrt rgmii vs rgmii-id. IOW: he must have set it to rgmii deliberately. > > And then I found this: > https://lore.kernel.org/all/20220606163023.3677147-1-pgwipeout@gmail.com/ > > For Model B it was initially set to rgmii-id, but was later changed to > rgmii > due to compatibility issues on the production Model B. > I'm going to assume that it was (initially) set to rgmii on Model A for > similar reasons. I went through some of my old-ish notes and found the right excerpts from my logs of the #quartz64 channel on the Pine64 IRC server. Here they are, for future reference, and sorry for a bit long lines: the ethernet issue is resolved by phy-mode = "rgmii-id" -> phy-mode = "rgmii"? disabling internal delays in the phy... I've been running rgmii-id for a while now, on several boards. The inner delays are programmed over the mii interface in the mac itself. The Motorcomm has insane default settings, rgmii mode zeros them (well as close to zero as we can get), rgmii-id sets them to the default values the rgmii spec calls for. pgwipeout: delays are hardcoded in the driver? Yeah, they are currently. Adjustable delays are available in the gmac driver and rgmii mode. @pgwipeout (re: TX and RX delays) if I got it right, "tx_delay" and "rx_delay" parameters in DT are for the GMAC itself, as described for the RK3399 on page 604 in https://www.t-firefly.com/download/Firefly-RK3399/docs/TRM/Rockchip%20RK3399TRM%20V1.3%20Part2.pdf while the Motorcomm PHY has its own, separate delays, which are configured in the Motorcomm PHY driver and all that depends on the selected interface mode (RGMII, RGMII_ID, etc.) could you, please, tell me if my understanding is right? @dsimic Correct, the gmac parameters control the gmac's delays. RGMII spec requires the clock to be active for a specific period of time before the data is received. RGMII mode is supposed to be for when the correct delay is built into the hardware by making the data lines longer than the clock lines. RGMII-ID assumes all of the lines are exactly the same length and implements the delay in the MAC instead. Adjusting the delays from the default means neither of these are true. When RGMII-ID mode is active, the GMAC driver zeros out its internal delays, but it still complains if they aren't in the DT. @pgwipeout: thank you very much for the explanation; yes, I saw that the "tx_delay" and "rx_delay" parameters in the DT are mandatory even when they end up unused, and there are even hardcoded defaults for those parameters in the MAC driver, which all looked strange More likely we just don't know the value translation for the Rx and Tx values and they aren't perfectly lining up. So we are right on the edge of the bell with ID, and variations in manufacturing put us on one side or the other. Either that or the rk356x gmac has different internal delays than previous chips. The default is based on the rk33 series of 0x10 but the ref boards for the rk35 series uses 0x1f.