From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
Cc: dev@dpdk.org, david.marchand@6wind.com
Subject: Re: [PATCH] eal/linuxapp: fix resource leak
Date: Fri, 13 May 2016 12:28:07 +0200 [thread overview]
Message-ID: <2977689.TnkrfoPGVf@xps13> (raw)
In-Reply-To: <72463300-a846-43a7-11d4-65a48b6370d0@intel.com>
2016-05-12 08:55, Sergio Gonzalez Monroy:
> On 11/05/2016 17:01, Daniel Mrzyglod wrote:
> > Fix issue reported by Coverity.
> > Coverity ID 97920
> >
> > munmap structure of hugepage
> >
> > leaked_storage: Variable hugepage going out of scope leaks the storage
> > it points to.
> >
> > The system resource will not be reclaimed and reused, reducing the future
> > availability of the resource.
>
> I'm not really fond of this commit messages, but if no one minds them,
> so be it.
Me too. It looks like a Machine2Machine message.
I'd prefer an explanation of what is wrong first, then an explanation of
the fix, and at the end, the Coverity ID (can be a tag like
Fixes-Coverity-ID: 97920).
> > In rte_eal_hugepage_init: Leak of memory or pointers to system resources
> >
> > Fixes: b6a468ad41d5 ("memory: add --socket-mem option")
> >
> > Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
next prev parent reply other threads:[~2016-05-13 10:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 16:01 [PATCH] eal/linuxapp: fix resource leak Daniel Mrzyglod
2016-05-12 7:55 ` Sergio Gonzalez Monroy
2016-05-13 10:28 ` Thomas Monjalon [this message]
2016-05-12 9:12 ` [PATCH v2] " Daniel Mrzyglod
2016-06-20 9:33 ` Thomas Monjalon
2016-06-22 16:50 ` [PATCH v3] " Daniel Mrzyglod
2016-06-30 13:31 ` Sergio Gonzalez Monroy
2016-07-06 10:44 ` [PATCH v4] " Daniel Mrzyglod
2016-07-06 10:48 ` Sergio Gonzalez Monroy
2016-07-10 13:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2977689.TnkrfoPGVf@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.