From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v6 6/7] dt-bindings: display: rockchip: fill Documents for vop series Date: Fri, 28 Jul 2017 11:25:36 +0200 Message-ID: <2981514.6HN6ClsfAP@phil> References: <1501049930-5794-1-git-send-email-mark.yao@rock-chips.com> <1501049975-6185-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1501049975-6185-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Yao Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgTWFyaywKCkFtIE1pdHR3b2NoLCAyNi4gSnVsaSAyMDE3LCAxNDoxOTozNSBDRVNUIHNjaHJp ZWIgTWFyayBZYW86Cj4gU2lnbmVkLW9mZi1ieTogTWFyayBZYW8gPG1hcmsueWFvQHJvY2stY2hp cHMuY29tPgo+IEFja2VkLWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgo+IC0tLQo+ IENoYW5nZXMgaW4gdjU6Cj4gLSBjbGVhbiBkb2N1bWVudCBjb21taXQgdGl0bGUKPiAtIG1vdmUg Y2hhbmdlcyBkZXNjcmlwdGlvbiBvdXQgb2YgZG9jdW1taXQgY29tbWl0IG1zZwo+IAo+IENoYW5n ZXMgaW4gdjI6Cj4gLSByZW5hbWUgcmszMjJ4IHRvIHJrMzIyOAo+IC0gY29ycmVjdCBzb21lIHZv cCByZWdpc3RlcnMgZGVmaW5lCj4gCj4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9kaXNwbGF5L3JvY2tjaGlwL3JvY2tjaGlwLXZvcC50eHQgfCA0ICsrKysKPiAgMSBmaWxlIGNo YW5nZWQsIDQgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9yb2NrY2hpcC9yb2NrY2hpcC12b3AudHh0IGIvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2NoaXAvcm9ja2NoaXAt dm9wLnR4dAo+IGluZGV4IDllYjNmMGEuLjVkODM1ZDkgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRh dGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcm9ja2NoaXAvcm9ja2NoaXAtdm9wLnR4 dAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3JvY2tj aGlwL3JvY2tjaGlwLXZvcC50eHQKPiBAQCAtOCw4ICs4LDEyIEBAIFJlcXVpcmVkIHByb3BlcnRp ZXM6Cj4gIC0gY29tcGF0aWJsZTogdmFsdWUgc2hvdWxkIGJlIG9uZSBvZiB0aGUgZm9sbG93aW5n Cj4gIAkJInJvY2tjaGlwLHJrMzAzNi12b3AiOwo+ICAJCSJyb2NrY2hpcCxyazMyODgtdm9wIjsK PiArCQkicm9ja2NoaXAscmszMzY4LXZvcCI7Cj4gKwkJInJvY2tjaGlwLHJrMzM2Ni12b3AiOwo+ ICAJCSJyb2NrY2hpcCxyazMzOTktdm9wLWJpZyI7Cj4gIAkJInJvY2tjaGlwLHJrMzM5OS12b3At bGl0IjsKPiArCQkicm9ja2NoaXAscmszMjI4LXZvcCI7Cj4gKwkJInJvY2tjaGlwLHJrMzMyOC12 b3AiOwoKd2hhdCBpcyB5b3VyIG9yZGVyaW5nIHNjaGVtZSBoZXJlPwpBcyB0aGUgbnVtYmVyIG9m IHJrWFhYWCBzb2NzIHdpbGwgdmVyeSBsaWtlbHkgaW5jcmVhc2UgaW4gdGhlIGZ1dHVyZQpvcmRl cmluZyBhbHBoYW51bWVyaWNhbCBtaWdodCBtYWtlIGV2ZXJ5dGhpbmcgbW9yZSBtYW5hZ2VhYmxl IHdoZW4KdGhlIGxpc3QgZ3Jvd3MuCgpTbyBtYXliZSBzd2FwIHJrMzM2OCBhbmQgcmszMzY2IGFu ZCBtb3ZlIHJrMzIyOCtyazMzMjggdG8gc29ydGVkCnBvc2l0aW9ucz8KCgpIZWlrbwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Fri, 28 Jul 2017 11:25:36 +0200 Subject: [PATCH v6 6/7] dt-bindings: display: rockchip: fill Documents for vop series In-Reply-To: <1501049975-6185-1-git-send-email-mark.yao@rock-chips.com> References: <1501049930-5794-1-git-send-email-mark.yao@rock-chips.com> <1501049975-6185-1-git-send-email-mark.yao@rock-chips.com> Message-ID: <2981514.6HN6ClsfAP@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, Am Mittwoch, 26. Juli 2017, 14:19:35 CEST schrieb Mark Yao: > Signed-off-by: Mark Yao > Acked-by: Rob Herring > --- > Changes in v5: > - clean document commit title > - move changes description out of docummit commit msg > > Changes in v2: > - rename rk322x to rk3228 > - correct some vop registers define > > Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > index 9eb3f0a..5d835d9 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > @@ -8,8 +8,12 @@ Required properties: > - compatible: value should be one of the following > "rockchip,rk3036-vop"; > "rockchip,rk3288-vop"; > + "rockchip,rk3368-vop"; > + "rockchip,rk3366-vop"; > "rockchip,rk3399-vop-big"; > "rockchip,rk3399-vop-lit"; > + "rockchip,rk3228-vop"; > + "rockchip,rk3328-vop"; what is your ordering scheme here? As the number of rkXXXX socs will very likely increase in the future ordering alphanumerical might make everything more manageable when the list grows. So maybe swap rk3368 and rk3366 and move rk3228+rk3328 to sorted positions? Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751719AbdG1JZo (ORCPT ); Fri, 28 Jul 2017 05:25:44 -0400 Received: from gloria.sntech.de ([95.129.55.99]:49770 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751045AbdG1JZn (ORCPT ); Fri, 28 Jul 2017 05:25:43 -0400 From: Heiko Stuebner To: Mark Yao Cc: David Airlie , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 6/7] dt-bindings: display: rockchip: fill Documents for vop series Date: Fri, 28 Jul 2017 11:25:36 +0200 Message-ID: <2981514.6HN6ClsfAP@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1501049975-6185-1-git-send-email-mark.yao@rock-chips.com> References: <1501049930-5794-1-git-send-email-mark.yao@rock-chips.com> <1501049975-6185-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, Am Mittwoch, 26. Juli 2017, 14:19:35 CEST schrieb Mark Yao: > Signed-off-by: Mark Yao > Acked-by: Rob Herring > --- > Changes in v5: > - clean document commit title > - move changes description out of docummit commit msg > > Changes in v2: > - rename rk322x to rk3228 > - correct some vop registers define > > Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > index 9eb3f0a..5d835d9 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt > @@ -8,8 +8,12 @@ Required properties: > - compatible: value should be one of the following > "rockchip,rk3036-vop"; > "rockchip,rk3288-vop"; > + "rockchip,rk3368-vop"; > + "rockchip,rk3366-vop"; > "rockchip,rk3399-vop-big"; > "rockchip,rk3399-vop-lit"; > + "rockchip,rk3228-vop"; > + "rockchip,rk3328-vop"; what is your ordering scheme here? As the number of rkXXXX socs will very likely increase in the future ordering alphanumerical might make everything more manageable when the list grows. So maybe swap rk3368 and rk3366 and move rk3228+rk3328 to sorted positions? Heiko