From: Thomas Monjalon <thomas@monjalon.net>
To: "Huang, Wei" <wei.huang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"nipun.gupta@nxp.com" <nipun.gupta@nxp.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
stable@dpdk.org, "stable@dpdk.org" <stable@dpdk.org>,
"Xu, Rosen" <rosen.xu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Zhang, Tianfei" <tianfei.zhang@intel.com>
Subject: Re: [PATCH] raw/ifpga: avoid potential integer overflow
Date: Sun, 26 Jun 2022 12:16:22 +0200 [thread overview]
Message-ID: <2981798.izSxrag8PF@thomas> (raw)
In-Reply-To: <BN9PR11MB54839BBCC7FB00071481BB5AE3B59@BN9PR11MB5483.namprd11.prod.outlook.com>
> > Expression "tx_chunks * ctx->dma_buf_size" in dma_fpga_to_fpga() is evaluated
> > using 32-bit arithmetic, which would overflow potentially. Change tx_chunks to
> > type "uint64_t" to avoid such issue.
> >
> > Coverity issue: 379203
> > Fixes: 7d63899a5c19 ("raw/ifpga: add N3000 AFU driver")
> >
> > Signed-off-by: Wei Huang <wei.huang@intel.com>
>
> It looks good for me.
>
> Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
Applied, thanks.
next prev parent reply other threads:[~2022-06-26 10:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 3:11 [PATCH] raw/ifpga: avoid potential integer overflow Wei Huang
2022-06-23 5:52 ` Zhang, Tianfei
2022-06-26 10:16 ` Thomas Monjalon [this message]
2022-06-23 6:35 ` Xu, Rosen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2981798.izSxrag8PF@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
--cc=qi.z.zhang@intel.com \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
--cc=wei.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.