From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4 0/5] lpm allocation fixes
Date: Tue, 22 Mar 2016 17:14:58 +0100
Message-ID: <2983189.UJ094KPj7K@xps13>
References: <1458131629-21925-1-git-send-email-christian.ehrhardt@canonical.com>
 <1458569175-8742-1-git-send-email-christian.ehrhardt@canonical.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, bruce.richardson@intel.com, olivier.matz@6wind.com
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 480222B98
 for <dev@dpdk.org>; Tue, 22 Mar 2016 17:16:38 +0100 (CET)
Received: by mail-wm0-f45.google.com with SMTP id r129so100863186wmr.1
 for <dev@dpdk.org>; Tue, 22 Mar 2016 09:16:38 -0700 (PDT)
In-Reply-To: <1458569175-8742-1-git-send-email-christian.ehrhardt@canonical.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-21 15:06, Christian Ehrhardt:
> Poking a bit on autotest revealed a few shortcomings in the lpm allocation path.
> Thanks to the feedback to the first revision of the patches here v2.
> Also Oliver Matz spotted similar issues and made me aware - thanks!
> Integrating them revealed even more use after free / leak issues.
> 
> *updates in v4*
> - re-removing the { } on single line ifs accidentially droped in v3
> - adding the ack of Oliver Matz
> 
> *updates in v3*
> - lpm create/free path for v20 and v1604 got the same fixes that were
>   already identified for lpm6 before
> 
> *updates in v2*
> - lpm/lpm6 patches split
> - following dpdk coding guidelines regarding single line if's
> - adding singed-off and acked-bys gathered so far
> - combine all three related patches in one series
> 
> Christian Ehrhardt (5):
>   lpm6: fix use after free of lpm in rte_lpm6_create
>   lpm6: fix missing free of rules_tbl and lpm
>   lpm: fix missing free of lpm
>   lpm: fix use after free of lpm in rte_lpm_create*
>   lpm: fix missing free of rules_tbl and lpm in rte_lpm_free*

Applied, thanks