From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Tue, 01 Aug 2017 15:43:24 +0000 Subject: Re: [PATCH] fbdev: Nuke FBINFO_MODULE Message-Id: <2983645.ftmugOAeCm@amdc3058> List-Id: References: <20170706125735.28299-3-daniel.vetter@ffwll.ch> <3012281.mcLmPQijCc@amdc3058> In-Reply-To: <3012281.mcLmPQijCc@amdc3058> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Linux Fbdev development list , DRI Development On Thursday, July 13, 2017 04:01:50 PM Bartlomiej Zolnierkiewicz wrote: > On Wednesday, July 12, 2017 05:07:42 PM Daniel Vetter wrote: > > On Wed, Jul 12, 2017 at 2:54 PM, Bartlomiej Zolnierkiewicz > > wrote: > > > On Wednesday, July 12, 2017 02:42:14 PM Daniel Vetter wrote: > > >> On Wed, Jul 12, 2017 at 12:41:34PM +0200, Bartlomiej Zolnierkiewicz wrote: > > >> > On Tuesday, July 11, 2017 04:52:19 PM Daniel Vetter wrote: > > >> > > Instead check info->ops->owner, which amounts to the same. > > >> > > > > >> > > Spotted because I want to remove the pile of broken and cargo-culted > > >> > > fb_info->flags assignments in drm drivers. > > >> > > > > >> > > v2: Fixup matrox (reported by kbuild). Also nuke FBINFO_FLAG_* defines > > >> > > that I've failed to spot. > > >> > > > > >> > > v3: Don't nuke FBINFO_FLAG_DEFAULT, that's used all over the place. > > >> > > > > >> > > Cc: Bartlomiej Zolnierkiewicz > > >> > > Cc: linux-fbdev@vger.kernel.org > > >> > > Signed-off-by: Daniel Vetter > > >> > > > >> > Acked-by: Bartlomiej Zolnierkiewicz > > >> > > >> Do you plan to pick these two patches up yourself, or do you expect me to > > >> merge them? > > > > > > Since the original patchset contained DRM changes (two last patches) > > > depending on fbdev changes (two first patches, the patch being discussed > > > was the second one) I assumed that you would like to take them all > > > through DRM tree. If this is not what is preferred, please tell me. > > > > There's no direct depency between 1&2 and 3&4, the only effect of > > merging them through separate trees is that the bootup logo might not > > show up when it's expected, until the trees are merged together. We > > could merge them through separate trees if you prefer that (I forgot > > to mention that in the cover letter), but I'm fine with putting them > > all into drm-misc with your ack for 4.14. > > > > Whatever you prefer, I don't mind either way. > > Then I will merge patches 1&2 for v4.14 through fbdev tree (there are > some other changes pending touching fbdev core and I would like to avoid > conflicts between fbdev & drm-misc trees). Thanks! Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] fbdev: Nuke FBINFO_MODULE Date: Tue, 01 Aug 2017 17:43:24 +0200 Message-ID: <2983645.ftmugOAeCm@amdc3058> References: <20170706125735.28299-3-daniel.vetter@ffwll.ch> <3012281.mcLmPQijCc@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <3012281.mcLmPQijCc@amdc3058> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , Linux Fbdev development list , DRI Development List-Id: dri-devel@lists.freedesktop.org T24gVGh1cnNkYXksIEp1bHkgMTMsIDIwMTcgMDQ6MDE6NTAgUE0gQmFydGxvbWllaiBab2xuaWVy a2lld2ljeiB3cm90ZToKPiBPbiBXZWRuZXNkYXksIEp1bHkgMTIsIDIwMTcgMDU6MDc6NDIgUE0g RGFuaWVsIFZldHRlciB3cm90ZToKPiA+IE9uIFdlZCwgSnVsIDEyLCAyMDE3IGF0IDI6NTQgUE0s IEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3oKPiA+IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+ IHdyb3RlOgo+ID4gPiBPbiBXZWRuZXNkYXksIEp1bHkgMTIsIDIwMTcgMDI6NDI6MTQgUE0gRGFu aWVsIFZldHRlciB3cm90ZToKPiA+ID4+IE9uIFdlZCwgSnVsIDEyLCAyMDE3IGF0IDEyOjQxOjM0 UE0gKzAyMDAsIEJhcnRsb21pZWogWm9sbmllcmtpZXdpY3ogd3JvdGU6Cj4gPiA+PiA+IE9uIFR1 ZXNkYXksIEp1bHkgMTEsIDIwMTcgMDQ6NTI6MTkgUE0gRGFuaWVsIFZldHRlciB3cm90ZToKPiA+ ID4+ID4gPiBJbnN0ZWFkIGNoZWNrIGluZm8tPm9wcy0+b3duZXIsIHdoaWNoIGFtb3VudHMgdG8g dGhlIHNhbWUuCj4gPiA+PiA+ID4KPiA+ID4+ID4gPiBTcG90dGVkIGJlY2F1c2UgSSB3YW50IHRv IHJlbW92ZSB0aGUgcGlsZSBvZiBicm9rZW4gYW5kIGNhcmdvLWN1bHRlZAo+ID4gPj4gPiA+IGZi X2luZm8tPmZsYWdzIGFzc2lnbm1lbnRzIGluIGRybSBkcml2ZXJzLgo+ID4gPj4gPiA+Cj4gPiA+ PiA+ID4gdjI6IEZpeHVwIG1hdHJveCAocmVwb3J0ZWQgYnkga2J1aWxkKS4gQWxzbyBudWtlIEZC SU5GT19GTEFHXyogZGVmaW5lcwo+ID4gPj4gPiA+IHRoYXQgSSd2ZSBmYWlsZWQgdG8gc3BvdC4K PiA+ID4+ID4gPgo+ID4gPj4gPiA+IHYzOiBEb24ndCBudWtlIEZCSU5GT19GTEFHX0RFRkFVTFQs IHRoYXQncyB1c2VkIGFsbCBvdmVyIHRoZSBwbGFjZS4KPiA+ID4+ID4gPgo+ID4gPj4gPiA+IENj OiBCYXJ0bG9taWVqIFpvbG5pZXJraWV3aWN6IDxiLnpvbG5pZXJraWVAc2Ftc3VuZy5jb20+Cj4g PiA+PiA+ID4gQ2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZwo+ID4gPj4gPiA+IFNpZ25l ZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+ID4gPj4g Pgo+ID4gPj4gPiBBY2tlZC1ieTogQmFydGxvbWllaiBab2xuaWVya2lld2ljeiA8Yi56b2xuaWVy a2llQHNhbXN1bmcuY29tPgo+ID4gPj4KPiA+ID4+IERvIHlvdSBwbGFuIHRvIHBpY2sgdGhlc2Ug dHdvIHBhdGNoZXMgdXAgeW91cnNlbGYsIG9yIGRvIHlvdSBleHBlY3QgbWUgdG8KPiA+ID4+IG1l cmdlIHRoZW0/Cj4gPiA+Cj4gPiA+IFNpbmNlIHRoZSBvcmlnaW5hbCBwYXRjaHNldCBjb250YWlu ZWQgRFJNIGNoYW5nZXMgKHR3byBsYXN0IHBhdGNoZXMpCj4gPiA+IGRlcGVuZGluZyBvbiBmYmRl diBjaGFuZ2VzICh0d28gZmlyc3QgcGF0Y2hlcywgdGhlIHBhdGNoIGJlaW5nIGRpc2N1c3NlZAo+ ID4gPiB3YXMgdGhlIHNlY29uZCBvbmUpIEkgYXNzdW1lZCB0aGF0IHlvdSB3b3VsZCBsaWtlIHRv IHRha2UgdGhlbSBhbGwKPiA+ID4gdGhyb3VnaCBEUk0gdHJlZS4gSWYgdGhpcyBpcyBub3Qgd2hh dCBpcyBwcmVmZXJyZWQsIHBsZWFzZSB0ZWxsIG1lLgo+ID4gCj4gPiBUaGVyZSdzIG5vIGRpcmVj dCBkZXBlbmN5IGJldHdlZW4gMSYyIGFuZCAzJjQsIHRoZSBvbmx5IGVmZmVjdCBvZgo+ID4gbWVy Z2luZyB0aGVtIHRocm91Z2ggc2VwYXJhdGUgdHJlZXMgaXMgdGhhdCB0aGUgYm9vdHVwIGxvZ28g bWlnaHQgbm90Cj4gPiBzaG93IHVwIHdoZW4gaXQncyBleHBlY3RlZCwgdW50aWwgdGhlIHRyZWVz IGFyZSBtZXJnZWQgdG9nZXRoZXIuIFdlCj4gPiBjb3VsZCBtZXJnZSB0aGVtIHRocm91Z2ggc2Vw YXJhdGUgdHJlZXMgaWYgeW91IHByZWZlciB0aGF0IChJIGZvcmdvdAo+ID4gdG8gbWVudGlvbiB0 aGF0IGluIHRoZSBjb3ZlciBsZXR0ZXIpLCBidXQgSSdtIGZpbmUgd2l0aCBwdXR0aW5nIHRoZW0K PiA+IGFsbCBpbnRvIGRybS1taXNjIHdpdGggeW91ciBhY2sgZm9yIDQuMTQuCj4gPiAKPiA+IFdo YXRldmVyIHlvdSBwcmVmZXIsIEkgZG9uJ3QgbWluZCBlaXRoZXIgd2F5Lgo+IAo+IFRoZW4gSSB3 aWxsIG1lcmdlIHBhdGNoZXMgMSYyIGZvciB2NC4xNCB0aHJvdWdoIGZiZGV2IHRyZWUgKHRoZXJl IGFyZQo+IHNvbWUgb3RoZXIgY2hhbmdlcyBwZW5kaW5nIHRvdWNoaW5nIGZiZGV2IGNvcmUgYW5k IEkgd291bGQgbGlrZSB0byBhdm9pZAo+IGNvbmZsaWN0cyBiZXR3ZWVuIGZiZGV2ICYgZHJtLW1p c2MgdHJlZXMpLiBUaGFua3MhCgpQYXRjaCBxdWV1ZWQgZm9yIDQuMTQsIHRoYW5rcy4KCkJlc3Qg cmVnYXJkcywKLS0KQmFydGxvbWllaiBab2xuaWVya2lld2ljegpTYW1zdW5nIFImRCBJbnN0aXR1 dGUgUG9sYW5kClNhbXN1bmcgRWxlY3Ryb25pY3MKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=