All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Andre Richter <andre.o.richter-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] tools: Fix some strings and functions regarding VFIO support
Date: Mon, 23 Mar 2015 12:09:45 +0100	[thread overview]
Message-ID: <2986196.1mfTVxFWUh@xps13> (raw)
In-Reply-To: <1426691107-7399-1-git-send-email-andre.o.richter-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Hi,

Your patch looks good.
Please could you resend it with a Signed-off-by line?
Procedure is described here:
	http://dpdk.org/dev#send

Thanks

2015-03-18 16:05, Andre Richter:
> This patch fixes several minor issues in setup.sh:
> 
>      - show_nics() would not display the current Ethernet settings if
>        the user only loads the vfio-pci module, b/c it only checks for
>        presence of igb_uio. Fix this by adding a check for vfio-pci.
> 
>      - unbind_nics(): Fix option naming and string inside function.
> 
>      - Exchange a forgotten "igb_uio" with "vfio-pci" in a comment.

  parent reply	other threads:[~2015-03-23 11:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 15:05 [PATCH] tools: Fix some strings and functions regarding VFIO support Andre Richter
     [not found] ` <1426691107-7399-1-git-send-email-andre.o.richter-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-23 11:09   ` Thomas Monjalon [this message]
2015-03-23 11:52     ` Andre Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2986196.1mfTVxFWUh@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=andre.o.richter-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.