From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] dma: sh: inherit debug options from the subsystem for sh
Date: Sun, 29 Jun 2014 19:56:43 +0000 [thread overview]
Message-ID: <29880309.jbmcOH83Zx@avalon> (raw)
In-Reply-To: <1404033022-3014-1-git-send-email-wsa@the-dreams.de>
Hi Wolfram,
Thank you for the patch.
On Sunday 29 June 2014 11:10:05 Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/dma/sh/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma/sh/Makefile b/drivers/dma/sh/Makefile
> index 1ce88b28cfc6..275297a89bd5 100644
> --- a/drivers/dma/sh/Makefile
> +++ b/drivers/dma/sh/Makefile
> @@ -1,3 +1,6 @@
> +ccflags-$(CONFIG_DMADEVICES_DEBUG) := -DDEBUG
Isn't this discouraged in favour of using dynamic printk ? I've recently
submitted a similar patch for the OMAP4 ISS driver and it got nacked.
> +ccflags-$(CONFIG_DMADEVICES_VDEBUG) += -DVERBOSE_DEBUG
> +
> obj-$(CONFIG_SH_DMAE_BASE) += shdma-base.o shdma-of.o
> obj-$(CONFIG_SH_DMAE) += shdma.o
> shdma-y := shdmac.o
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-06-29 19:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 9:10 [PATCH] dma: sh: inherit debug options from the subsystem for sh Wolfram Sang
2014-06-29 9:32 ` Geert Uytterhoeven
2014-06-29 19:56 ` Laurent Pinchart [this message]
2014-06-30 13:51 ` Vinod Koul
2014-07-03 8:48 ` Wolfram Sang
2014-07-03 9:14 ` Vinod Koul
2014-07-10 11:56 ` Wolfram Sang
2014-07-10 12:25 ` Laurent Pinchart
2014-07-10 12:48 ` Wolfram Sang
2014-07-10 15:21 ` Vinod Koul
2014-07-10 15:22 ` Vinod Koul
2014-07-10 15:42 ` Laurent Pinchart
2014-07-11 8:32 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29880309.jbmcOH83Zx@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.