From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Matthew Hall <mhall@mhcomputing.net>
Cc: dev@dpdk.org
Subject: Re: missing __rte_deprecated on rte_eth_stats.imcasts ?
Date: Mon, 23 Nov 2015 01:20:48 +0100 [thread overview]
Message-ID: <2992545.C0cUSYYlcR@xps13> (raw)
In-Reply-To: <20151122235342.GA28210@mhcomputing.net>
2015-11-22 18:53, Matthew Hall:
> I was reading through the deprecations in rte_eth_stats to see if I could fix
> the pktgen. Of course many fields were marked with __rte_deprecated .
>
> However I found this one field which said deprecated in its comment, but it
> lacked __rte_deprecated .
When setting the __rte_deprecated attribute, Stephen wanted to keep imcasts:
http://dpdk.org/dev/patchwork/patch/8732/
> Is the comment wrong, or is the field definition wrong, or did I miss
> something?
We have to decide if we really want to deprecate it.
I think we should set the deprecated attribute and it seems agreed.
> uint64_t imcasts;
> /**< Deprecated; Total number of multicast received packets. */
prev parent reply other threads:[~2015-11-23 0:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-22 23:53 missing __rte_deprecated on rte_eth_stats.imcasts ? Matthew Hall
2015-11-23 0:20 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2992545.C0cUSYYlcR@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=mhall@mhcomputing.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.